Content deleted Content added
m Archiving 4 discussion(s) from Module talk:WikiProject banner) (bot |
m Archiving 1 discussion(s) from Module talk:WikiProject banner) (bot Tag: Disambiguation links added |
||
Line 582:
:I have closed this discussion with consensus to remove the B-class checklist from any banner which has not opted out of PIQA, i.e. has not set {{para|QUALITY_CRITERIA|custom}} — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 15:03, 14 November 2023 (UTC)
:Updated code on sandbox. B-class checklist will not be displayed unless {{para|QUALITY_CRITERIA|custom}} — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 08:17, 16 November 2023 (UTC)
== Dab being generated to [[Wikipedia:Lists]] ==
{{Ping|MSGJ}} but it's [[Special:Diff/1185760174|fixed]] in the sandbox! But I'm not familiar with rest of the code at all, so there might be a better solution. Plus there're 10e7 transclusions, so I'd rather someone more knowledgable take a look at it. <b>~</b> <span style="font-family:Monotype Corsiva; font-size:16px;">[[User:Tom.Reding|Tom.Reding]] ([[User talk:Tom.Reding|talk]] ⋅[[WP:DGAF|dgaf]])</span> 21:28, 18 November 2023 (UTC)
:Is there an example page with a banner but no direct links to [[Wikipedia:Lists]] on the rest of the talk page? I looked at a few and all had a direct link somewhere on the page. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 21:50, 18 November 2023 (UTC)
::{{Ping|WOSlinker}} see [[Talk:Meanings of minor planet names: 599001–600000]]. <b>~</b> <span style="font-family:Monotype Corsiva; font-size:16px;">[[User:Tom.Reding|Tom.Reding]] ([[User talk:Tom.Reding|talk]] ⋅[[WP:DGAF|dgaf]])</span> 22:06, 18 November 2023 (UTC)
:::I went to [https://en.wikipedia.org/w/index.php?title=Special:WhatLinksHere/Wikipedia:Lists&namespace=1&limit=5000] but didn't see that page in the list. Am I looking in the wrong place? -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 23:01, 18 November 2023 (UTC)
::::[[Special:Diff/1185757933|This edit]], which added {{tl|WikiProject Lists}}, was automatically tagged with "Disambiguation links added", but [[Special:Diff/1185759771|this edit]], which added {{tl|WikiProject Lists/sandbox}}, did not. <b>~</b> <span style="font-family:Monotype Corsiva; font-size:16px;">[[User:Tom.Reding|Tom.Reding]] ([[User talk:Tom.Reding|talk]] ⋅[[WP:DGAF|dgaf]])</span> 00:48, 19 November 2023 (UTC)
:::::When I added the sandbox version to a page, with [https://en.wikipedia.org/w/index.php?title=User:WOSlinker/lint14&diff=prev&oldid=1185843610 this edit], it showed that tag as well, so I'm not sure your sandbox fix fully works. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 09:41, 19 November 2023 (UTC)
::::::[[Special:Diff/1185850355|Fixed]]! <b>~</b> <span style="font-family:Monotype Corsiva; font-size:16px;">[[User:Tom.Reding|Tom.Reding]] ([[User talk:Tom.Reding|talk]] ⋅[[WP:DGAF|dgaf]])</span> 10:51, 19 November 2023 (UTC)
:::::::I've had a look at this in a bit more detail and it wasn't the project link causing the issue. It wasn't looking at [[Wikipedia:Lists]] at all. What it was doing was looking at [[Lists]] (which is also a disambig page). The code that is causing the issue is on line 191 and is checking for the existance of the Lists page. I've done an [https://en.wikipedia.org/w/index.php?title=Module:WikiProject_banner/sandbox&diff=prev&oldid=1185859111 update in the sandbox] that avoids the checking if the MAIN_TEXT parameter is set which seems to fix this. [[User:MSGJ|MSGJ]], would you be able to check that this change works ok? -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 12:25, 19 November 2023 (UTC)
::::::::Looks good - thanks for looking into this! — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 21:29, 19 November 2023 (UTC)
| |||