Content deleted Content added
m Archiving 1 discussion(s) from Module talk:WikiProject banner) (bot |
m Archiving 1 discussion(s) from Module talk:WikiProject banner) (bot |
||
Line 357:
:I've fixed a few but I noticed that a bot can easily fix most if not all of these and just needs to check if a page is in that category and also in [[:Category:Living people]]. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 09:12, 16 September 2024 (UTC)
== False positive demo ==
{{ping|MSGJ}} I think your recent edits to this module might have caused it to treat real transclusions as demo. A box with the text {{tqb|Categories:
* {{c|Articles with WikiProject banners but without a banner shell}}}} is showing up underneath WikiProject banners on talk pages, e.g. [[WT:NFC]]. (This includes banners that ''are'' inside a banner shell, but tracking category issues aren't as urgent.)
[[User:Jlwoodwa|jlwoodwa]] ([[User talk:Jlwoodwa|talk]]) 06:11, 8 September 2024 (UTC)
:Looks like a problem with the inactive banners. I'll check ... — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:15, 8 September 2024 (UTC)
:Think I've fixed it — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 08:05, 8 September 2024 (UTC)
::The inactive banners seem to be populating the quality categories now. For example see [[Talk:By the Way Tour]]. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 10:28, 8 September 2024 (UTC)
:::Arghh noted. Fix in sandbox — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:47, 8 September 2024 (UTC)
::::Inactive banners are now missing categorization completely. [[Talk:Sudbury school]] should be in at least [[:Category:Articles with WikiProject banners but without a banner shell]]. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 22:36, 9 September 2024 (UTC)
:::::Actually I'm not sure that category ever worked on inactive banners. It probably should, but turning categorisation on selectively is going to be a pain — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 08:07, 10 September 2024 (UTC)
::::::It did work, as that page was (currently still is) in the category (that's how I found it). [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 08:28, 10 September 2024 (UTC)
:::::::I can't explain this. Will have to dig deeper into the code. The problem arises because of a compromise to display the quality assessments on these banners but without the categories. It would be much simpler if we could remove all the assessments from inactive banners, but some people found them useful. Perhaps this is less of an issue now with PIQA. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 09:54, 10 September 2024 (UTC)
:::::::I reverted to the 5th September version of the code in the sandbox and [[Talk:Sudbury school]] is still not in that category. So I don't understand why you found it in that category, unless it was from a much older version of the code. I agree it would be better if it was in that category, but the way the code is currently set up is either no categories work or all of them work. The category opt-out mechanism would get rather messy otherwise. So this is my proposal: we stop displaying the class on inactive banners. Then I won't need to suppress the categories on inactive banners, and these tracking caegories should then work properly — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 21:41, 17 September 2024 (UTC)
:::::::Fix is on the sandbox — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 14:00, 20 September 2024 (UTC)
{{fixed}}. I have tested this as much as I can, and it seems to work now — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 09:17, 23 September 2024 (UTC)
| |||