Content deleted Content added
m Archiving 1 discussion(s) from Module talk:WikiProject banner) (bot |
m Archiving 2 discussion(s) from Module talk:WikiProject banner) (bot |
||
Line 520:
::Do you mean on-wiki? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 13:32, 20 October 2024 (UTC)
:::Yes, otherwise, the module wouldn't find the correct pages. -- [[Special:Contributions/65.92.246.77|65.92.246.77]] ([[User talk:65.92.246.77|talk]]) 18:06, 20 October 2024 (UTC)
== auto doc category ==
Can {{para|DOC|auto}} also add the template to the project category? Either <code>Category:WikiProject {{var|project}}</code> or <code>Category:WikiProject {{var|project}} templates</code> category. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 11:27, 28 May 2024 (UTC)
:Don't see any reason not to do this. Will sort in the next couple of days — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 15:35, 2 June 2024 (UTC)
:Do you want it to check to see if <code>Category:WikiProject {{var|project}} templates</code> exists first. If so use it, otherwise use <code>Category:WikiProject {{var|project}}</code>? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 08:24, 4 June 2024 (UTC)
::Yes, I think it's best to place it in the templates category if it exists. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 08:30, 4 June 2024 (UTC)
:::I agree. That is now coded in the sandbox, and will currently appear on sandbox templates for testing. When deployed it will only categorise the live templates. You can check [[Template:WikiProject Deaf/sandbox]] (which does not have a templates category) and [[Template:WikiProject Cycling/sandbox]] (which does have a templates category) — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 08:52, 4 June 2024 (UTC)
::::Great, looks good! [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 09:19, 4 June 2024 (UTC)
{{Ul|Gonnym}} there are about 80 templates (see [[:Category:WikiProject banners with errors]]) which are not able to populate the project category, because it either doesn't exist or because it is a category redirect. Would you like to review these? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:09, 10 August 2024 (UTC)
:Yeah I'm taking a look at these. So far some sent to CfD, RM, or MfD. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 12:20, 10 August 2024 (UTC)
:@[[User:MSGJ|MSGJ]] most of the GLAM sub projects have a category titled: Category:Wikipedia-<project name> collaboration" (such as [[:Category:Wikipedia-Philadelphia Museum of Art collaboration]]). So a template like [[Template:WikiProject Philadelphia Museum of Art]] that has a {{para|PROJECT_LINK|Wikipedia:GLAM/Philadelphia Museum of Art}} can be placed there. That should remove most pages in the category. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 11:35, 11 August 2024 (UTC)
::Or we can just leave them to add the categories manually, as they are currently doing? When you are done reviewing those, I can turn off the tracking — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 20:00, 11 August 2024 (UTC)
::Are you finished reviewing these - and can I turn off the tracking, rather than keeping them in the error category indefinitely — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 19:23, 3 September 2024 (UTC)
:::Well I've added some code to the sandbox to support these (if we want), but you could turn it off. I've reviewed most, but I'm not a fan of reviewing categories that can never be cleared as it has me checking things I've already looked at before. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 23:02, 3 September 2024 (UTC)
::::Yes that is my concern too - that we can never resolve some of these issues, so they are not actually "errors" — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:38, 4 September 2024 (UTC)
::::Is [[Module:WikiProject banner/templatepage/sandbox]] ready to deploy or not needed? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 23:04, 5 October 2024 (UTC)
:::::I think it's ready for deploy. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 13:17, 30 October 2024 (UTC)
:::::The CSS should still be moved though. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 13:37, 30 October 2024 (UTC)
== invert parenthesis on inactive WikiProject bubble ==
[[User:Matrix]] made [https://en.wikipedia.org/w/index.php?title=Module:WikiProject_banner/styles.css&diff=prev&oldid=1250151568 this edit] without any discussion whatsoever. Can you explain what this does, and can you ensure you discuss changes to widely used modules in future? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 18:11, 9 October 2024 (UTC)
:{{ping|MSGJ}} wait I thought I did that in the sandbox module... sorry for being stupid. It was supposed to invert the parenthesis on the text "(inactive)" in the banner for inactive wikiprojects. —'''Matrix(!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|user]] - [[User talk:Matrix|talk?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>contributions]]''} 18:13, 9 October 2024 (UTC)
::I don't think it works. —'''Matrix(!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|user]] - [[User talk:Matrix|talk?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>contributions]]''} 18:13, 9 October 2024 (UTC)
::You want [[Module:WikiProject banner/sandbox/styles.css]] then. We don't play around on a module with 11 million transclusions! — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 18:26, 9 October 2024 (UTC)
:::{{ping|MSGJ}} calm down mate it was an honest error :/ —'''Matrix(!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|user]] - [[User talk:Matrix|talk?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>contributions]]''} 18:41, 9 October 2024 (UTC)
:::{{ping|MSGJ}} All right, I got it working now and checked with testcases, everything looks fine to you? —'''Matrix(!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|user]] - [[User talk:Matrix|talk?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>contributions]]''} 19:03, 9 October 2024 (UTC)
::::Please explain what "invert parenthesis" means? I cannot see any difference on the testcases — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:03, 10 October 2024 (UTC)
:::::I'm curious as well. I created {{tl|WikiProject Occupations/sandbox}}, since that was the first inactive WP that came to mind. <b>~</b> <span style="font-family:Monotype Corsiva; font-size:16px;">[[User:Tom.Reding|Tom.Reding]] ([[User talk:Tom.Reding|talk]] ⋅[[WP:DGAF|dgaf]])</span> 13:37, 10 October 2024 (UTC)
:::::{{ping|MSGJ|Tom.Reding}} you can't see any difference between the sandbox and live versions because the templatestyles on the sandbox version also applies to the live version on that page. At the bottom of the testcases you can see the parenthesis saying "([[Wikipedia:INACTIVEWP|inactive]])" is correctly coded as white, whilst on [[WT:Logos]] it's black during dark mode, because usually the WikiProject bubble is not inverted in dark mode. However in this case it should be black. —'''Matrix(!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|user]] - [[User talk:Matrix|talk?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>contributions]]''} 16:34, 10 October 2024 (UTC)
::::::I see no difference between [[Module talk:WikiProject banner/testcases#Inactive WikiProject|the testcase]] & [[Wikipedia talk:Logos]]. Which skin(s) does your change affect? <b>~</b> <span style="font-family:Monotype Corsiva; font-size:16px;">[[User:Tom.Reding|Tom.Reding]] ([[User talk:Tom.Reding|talk]] ⋅[[WP:DGAF|dgaf]])</span> 17:27, 10 October 2024 (UTC)
:::::::{{ping|Tom.Reding}} Are you using Vector 2022 dark mode as was specified earlier? —'''Matrix(!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|user]] - [[User talk:Matrix|talk?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>contributions]]''} 18:18, 10 October 2024 (UTC)
::::::::{{Ping|Matrix}} I'm using Vector 2010, but I opened those pages in Vector 2022 and still see no change between any of those banners in both light and dark modes. <b>~</b> <span style="font-family:Monotype Corsiva; font-size:16px;">[[User:Tom.Reding|Tom.Reding]] ([[User talk:Tom.Reding|talk]] ⋅[[WP:DGAF|dgaf]])</span> 17:34, 11 October 2024 (UTC)
:::::::::{{ping|Tom.Reding}} I created an [https://imgur.com/a/ETHb18R Imgur] for you. Look carefully at the parenthesis saying "inactive". First is WT:Logos, second is testcases. —'''Matrix(!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|user]] - [[User talk:Matrix|talk?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>contributions]]''} 17:39, 11 October 2024 (UTC)
::::::::::I'm using Vector 2022 and I went to dark mode but what I'm seeing does not match the image on that link. On mine the brackets are white (just like your second image) and it looks fine — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:47, 12 October 2024 (UTC)
:::::::::::{{ping|MSGJ}} mb I didn't see this comment (next time pls ping me as my signature says). Which page did you visit? [[WT:Logos]] or testcases. The problem is in testcases due to templatestyles applying everywhere and not just the sandbox due to [[phab:T155813#2996589]]. —'''[[User:Matrix|Matrix]](!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|u]] - [[User talk:Matrix|t?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>c]]''} 11:11, 30 October 2024 (UTC)
:::::{{ping|MSGJ}} Any objections to implementing this edit? —'''Matrix(!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|user]] - [[User talk:Matrix|talk?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>contributions]]''} 19:11, 11 October 2024 (UTC)
::::::implementing now —'''Matrix(!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|user]] - [[User talk:Matrix|talk?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>contributions]]''} 16:00, 16 October 2024 (UTC)
:::::::You still haven't explained what this does. We can't see any difference on the test cases — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 16:47, 16 October 2024 (UTC)
::::::::I've explained this at [[Module_talk:WikiProject_banner#c-Matrix-20241010181800-Tom.Reding-20241010172700]]. Due to the way templatestyles works, the css rule would apply to the whole testcases page not just the sandbox version. You could view an archive of [[WT:Logos]] to see the difference. —'''[[User:Matrix|Matrix]](!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|u]] - [[User talk:Matrix|t?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>c]]''} 11:14, 30 October 2024 (UTC)
:::::::I see you went ahead with this change, despite unanswered questions from myself and Tom.Reding on this talk page — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 17:12, 17 October 2024 (UTC)
::::::::{{ping|MSGJ}} I assume Tom.Reding had no issues with the edit since he thanked my reply. I simply overlooked your reply as it got lost in the swathe of comments. Next time please ping. —'''[[User:Matrix|Matrix]](!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|u]] - [[User talk:Matrix|t?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>c]]''} 11:13, 30 October 2024 (UTC)
:::::::::{{Ping|Matrix}} the thank you was for the imgur, which at least showed the problem we were unable to reproduce, not a validation of your change. We still don't know the root cause, only that your change papered over it. <b>~</b> <span style="font-family:Monotype Corsiva; font-size:16px;">[[User:Tom.Reding|Tom.Reding]] ([[User talk:Tom.Reding|talk]] ⋅[[WP:DGAF|dgaf]])</span> 12:01, 30 October 2024 (UTC)
::::::::::{{ping|Tom.Reding}} The root cause of the black parenthesis is the following code: <syntaxhighlight lang=css>.wpb-header-bubbles {
border-radius: .5em;
padding: 0 .3em;
margin-left: 0.5em;
white-space: nowrap;
font-weight: normal;
color: black;
}</syntaxhighlight> This code is here so the little bubbles that say "C‑class" and "B-class", etc are in black even in dark mode. But the text saying "(inactive)" is also a member of wpb-header-bubbles so the parenthesis is also black, which is undesirable. My change to the css therefore has a higher specificity and overrides the previous code, making the parenthesis white. Hope this helps. —'''[[User:Matrix|Matrix]](!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|u]] - [[User talk:Matrix|t?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>c]]''} 12:55, 30 October 2024 (UTC)
:::::::::::Just to be clear, in the image example you gave, is the top after your change or the bottom? [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 13:16, 30 October 2024 (UTC)
::::::::::::Bottom is after my change. —'''[[User:Matrix|Matrix]](!)''' <sub>ping one</sub><sup>when replying</sup> {''[[User:Matrix|u]] - [[User talk:Matrix|t?]] - [[Special:Contribs/Matrix|<sub><small><s>useless</s></small></sub>c]]''} 16:59, 30 October 2024 (UTC)
| |||