Content deleted Content added
Line 460:
:::Fair enough, but my primary concern is that we are transforming a slightly slow but maintainable and readable module into one that requires specialized Lua knowledge to debug. By introducing a dependency on a highly complex and intricate module, we risk increasing the likelihood that errors related to <code>PrepareText</code> will be hard to debug for passing administrators and instead demand the expertise of someone really familiar with the inner working of the Wikitext parsing module. [[User:Sohom Datta|<b class="skin-invert" style="color:#795cb2; display: inline-block; transform: rotate(1deg)">Sohom</b>]] ([[User talk:Sohom Datta|<span class="skin-invert" style="color: #36c;">talk</span>]]) 16:58, 22 January 2025 (UTC)
::::That's fair. I've annotated it with a comment to at least explain what it does functionally so that any person reading it should be able to figure out why something might be (intentionally) not getting picked up. If you're worried about the parsing module itself bugging, it's already used in a couple commonly used modules with no bugs reported yet, so it shouldn't be the direct cause of any bugs itself, though I understand the concern. I'm fine with this being rejected if you think the simplicity is worth, since the performance hit isn't incredibly significant. [[User:Aidan9382|Aidan9382]] <sub>([[User talk:Aidan9382|talk]])</sub> 17:31, 22 January 2025 (UTC)
:::::I am intending to deploy the code, unless anyone objects. The current code is doing something which can be done better by an existing module. I'm not seeing a huge benefit in trying to keep this module simple — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 20:52, 28 January 2025 (UTC)
| |||