Module talk:Disambiguation: Difference between revisions

Revision as of 08:21, 4 February 2025

Revision as of 08:22, 4 February 2025

Line 452:

== Edit request 18 January 2025 - Speed improvements ==

{{Editedit fully-protected|answered=yes}}

Replaces the recently added nowiki/comment removal code with a module that does the same thing but a bit faster (~30% faster overall, though the general performance hit isn't much anyways). Normally wouldn't worry about it too much, but this module is decently used and might have good reason to be invoked more than one time on a page. [[User:Aidan9382|Aidan9382]] _{([[User talk:Aidan9382|talk]])} 20:46, 18 January 2025 (UTC)

Line 461 ⟶ 460:

::::That's fair. I've annotated it with a comment to at least explain what it does functionally so that any person reading it should be able to figure out why something might be (intentionally) not getting picked up. If you're worried about the parsing module itself bugging, it's already used in a couple commonly used modules with no bugs reported yet, so it shouldn't be the direct cause of any bugs itself, though I understand the concern. I'm fine with this being rejected if you think the simplicity is worth, since the performance hit isn't incredibly significant. [[User:Aidan9382|Aidan9382]] _{([[User talk:Aidan9382|talk]])} 17:31, 22 January 2025 (UTC)

:::::I am intending to deploy the code, unless anyone objects. The current code is doing something which can be done better by an existing module. I'm not seeing a huge benefit in trying to keep this module simple &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 20:52, 28 January 2025 (UTC)

:{{done}}<!-- Template:EP --> &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 08:22, 4 February 2025 (UTC)

== Request update of Module:Disambiguation/templates (4 February 2025) ==