Content deleted Content added
m Archiving 2 discussion(s) from Module talk:Location map) (bot |
m Archiving 2 discussion(s) from Module talk:Location map) (bot |
||
Line 709:
::{{ping|Pppery}} The change you made [https://en.wikipedia.org/w/index.php?title=Module:Location_map/multi&diff=prev&oldid=1221445143] includes the base Location map sandbox suffix require 😅. [[User:Alexiscoutinho|Alexis Coutinho]] ([[User talk:Alexiscoutinho|talk]]) <sup>[''[[WP:PING|ping me]]'']</sup> 01:21, 30 April 2024 (UTC)
::: Fixed. Sorry, I really should know better given I'm the guy systematically removing inappropriate sandbox uses. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 01:23, 30 April 2024 (UTC)
== Linter errors with <code>span</code> ==
{{ping|Jonesey95}} In your recent revert in the sandbox, do you mean if a user passes a label like this: <code><nowiki>label=<div style="color:green">New York</div></nowiki></code> (when using module syntax)? [[User:Alexiscoutinho|Alexis Coutinho]] ([[User talk:Alexiscoutinho|talk]]) 16:23, 20 May 2024 (UTC)
:Yes. A span tag cannot wrap a div tag. Many real-world examples appear in [https://en.wikipedia.org/w/index.php?search=hastemplate%3A%22Location+map%22+insource%3A%2Flabel%5C%3D%5C%3Cdiv%2F&title=Special:Search&profile=advanced&fulltext=1&ns0=1&ns4=1&ns10=1&ns12=1 these search results]. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 20:23, 20 May 2024 (UTC)
::👍 [[User:Alexiscoutinho|Alexis Coutinho]] ([[User talk:Alexiscoutinho|talk]]) 20:44, 20 May 2024 (UTC)
== Map label background bug in dark mode ==
The map labels in dark mode have a black background and black text. The background should either be transparent on maps where the label text colour has sufficient contrast with the background or white so the black text has sufficient contrast. Here are three examples from [[Moulins, Allier]], and [[Con Mine]].
[[File:Con Min map label bug.png|thumb]]
[[File:Con mine screenshot.png|thumb]]
[[File:Screen_shot_of_moulins,_allier_wiki_page_in_dark_mode.png|thumb]] [[User:JScherer-WMF|JScherer-WMF]] ([[User talk:JScherer-WMF|talk]]) 21:18, 29 May 2024 (UTC)
:In case this helps debugging: I noticed that the maps in [[Grand Canyon]] use the same template but do not have the bug. [[User:JScherer-WMF|JScherer-WMF]] ([[User talk:JScherer-WMF|talk]]) 16:55, 30 May 2024 (UTC)
::Hey @[[User:JScherer-WMF|JScherer-WMF]] this should be fixed now with the recent additions to [[Module:Location_map/styles.css]]. <span style="background:white; color: black;">🐸</span> [[User:Jdlrobson|Jdlrobson]] ([[User talk:Jdlrobson|talk]]) 04:35, 31 May 2024 (UTC)
:::I think these changes got broken again. See [[Caen]] [[User:Kabelsalat22|Kabelsalat22]] ([[User talk:Kabelsalat22|talk]]) 19:23, 13 June 2024 (UTC)
| |||