|
| minthreadstoarchive = 2
}}
== Big ole whitelist request ==
[[Template:Cite Cambridge History of China]] (which I've had no involvement in yet) is needing the module-level whitelisting to avoid miscategorisation. There are (to date) seventeen volumes, so there are a lot of things.{{pb}}{{ping|Renata3}} can you add (*deep breath*):{{pb}}['CITEREFLoeweShaughnessy1999'] = {'Cite Cambridge History of China'}, ['CITEREFDienKnapp2019'] = {'Cite Cambridge History of China'}, ['CITEREFPeterson2016'] = {'Cite Cambridge History of China'}, ['CITEREFChaffeeTwitchett2015'] = {'Cite Cambridge History of China'}, ['CITEREFTwitchettSmith2009'] = {'Cite Cambridge History of China'}, ['CITEREFPeterson2002'] = {'Cite Cambridge History of China'}, ['CITEREFTwitchettMote1998'] = {'Cite Cambridge History of China'}, ['CITEREFMoteTwitchett1998'] = {'Cite Cambridge History of China'}, ['CITEREFFrankeTwitchett1994'] = {'Cite Cambridge History of China'}, ['CITEREFMacFarquharFairbank1991'] = {'Cite Cambridge History of China'}, ['CITEREFMacFarquharFairbank1987'] = {'Cite Cambridge History of China'}, ['CITEREFTwitchettLoewe1986'] = {'Cite Cambridge History of China'}, ['CITEREFFairbankFeuerwerker1986'] = {'Cite Cambridge History of China'}, ['CITEREFFairbank1983'] = {'Cite Cambridge History of China'}, ['CITEREFFairbankLiu1980'] = {'Cite Cambridge History of China'}, ['CITEREFTwitchett1979'] = {'Cite Cambridge History of China'}, ['CITEREFFairbank1978'] = {'Cite Cambridge History of China'}{{pb}} Thanks in advance and sorry. (Noting for clarity that "TwitchettMote1998" alongside "MoteTwitchett1998" is not an error) [[User:Folly Mox|Folly Mox]] ([[User talk:Folly Mox|talk]]) 14:58, 19 October 2024 (UTC)
:Oh actually it turns out I'm the most recent contributor to that template 🫠 I added a parameter two months ago and forgot all about it. Anyway though [[User:Folly Mox|Folly Mox]] ([[User talk:Folly Mox|talk]]) 17:01, 19 October 2024 (UTC)
Sure, {{done}}. [[User:Renata3|Renata]]•[[User talk:Renata3|3]] 00:41, 20 October 2024 (UTC)
:Oh my gosh I'm so stupid! I actually went to cite one of the two relevant volumes today, and it turns out both the CITEREFs I specifically called out as {{tqq|not errors}} '''are errors'''. I must have fatfingered 1998 for 1988 and copypasted it three times without double checking the publication information.{{pb}}I feel like I heard there is a new process for the whitelist, but now I'm requesting an alteration rather than an addition, so I don't know if anyone other than {{u|Renata3}} can perform it. Can '{{!xt|CITEREFTwitchettMote1998}}' be changed to 'CITEREFTwitchettMote19'''8'''8' and '{{!xt|CITEREFMoteTwitchett1998}}' changed to 'CITEREFMoteTwitchett19'''8'''8'? The relevant books are {{doi|10.1017/CHOL9780521243339}} and {{doi|10.1017/CHOL9780521243322}}, in case anyone understandably wants to check my work.{{pb}}Sorry again. [[User:Folly Mox|Folly Mox]] ([[User talk:Folly Mox|talk]]) 14:41, 25 January 2025 (UTC)
:{{Done}}. It's an easy edit of [[Module:Footnotes/whitelist]] which can be done by any template editor. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 15:24, 25 January 2025 (UTC)
::Thank you, {{u|hike395}}! (a road I've not exactly hiked from, but definitely camped near){{Pb}}In [[Special:Diff/1271758480]] I undid the manual {{para|ref}} I added to counteract the previously incorrect whitelist CITEREFs, but my {{tl|harvc}}s are still throwing {{red|no target}} errors. Are you able to tell what I'm doing wrong? [[User:Folly Mox|Folly Mox]] ([[User talk:Folly Mox|talk]]) 15:34, 25 January 2025 (UTC)
:::You've done nothing wrong: there's some other problem. I'm investigating. (Camping on the Sierra side of US395 can be delightful, also; some people like the solitude of the Great Basin, though). — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 16:20, 25 January 2025 (UTC)
::::{{ping|Folly Mox}} The problem is in [[Module:Harvc]]. It doesn't use the whitelist/wrapper mechanism in this module. For now, I would set {{para|ignore_err|yes}} in {{tl|Harvc}} to suppress the spurious errors. I'll think about whether we can use the mechanism here over there. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 18:36, 25 January 2025 (UTC)
:::::Huh! Ok, thank you so much for identifying the issue! Using {{tl|harvc}} was a pretty big reason I wanted to whitelist the ''[[Cambridge History of China]]'' CITEREFs above (duplicating all that bibliographic information for each chapter is pretty bloaty), and I feel like it used to work?{{pb}}Anyway, thanks again and I'll just hide the errors, like when the building inspector comes round. [[User:Folly Mox|Folly Mox]] ([[User talk:Folly Mox|talk]]) 19:17, 25 January 2025 (UTC)
::::::{{tq|I feel like it used to work?}} It did used to work. I guess I gotta wonder if all of this churn was a good idea.
::::::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 19:26, 25 January 2025 (UTC)
:::::::{{ping|Trappist the monk}} I'm not sure how {{tl|harvc}} could have used the whitelist? Take a look at target_check() at line 21 in [[Module:Harvc]] (which is called from {{tl|harvc}}). It is completely separate code from target_check() in [[Module:Footnotes]]: the comment in that function explicitly says that it does not work with wrapped templates. If I'm misunderstanding something, please let me know.
:::::::Fortunately, the two functions are similar enough where we can call the [[Module:Footnotes]] target_check() from [[Module:Harvc]]. I have a version of this working in [[Module:Harvc/sandbox]], but just puzzling out how to test it. Advice is welcome. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 19:40, 25 January 2025 (UTC)
::::::::You may be correct; I would have expected that it looked in [[Module:Footnotes/whitelist]] but apparently it doesn't do that but only looks at locally constructed anchor ids. If you have a fix, apply it.
::::::::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 20:46, 25 January 2025 (UTC)
:::::::::Oops, I just asked for comments over at [[Template talk:Harvc#Adding whitelist/wrapper template handling to this template]], not having seen your comment here. Not sure if anyone else will respond. Is it ok to wait a day or two? — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 21:32, 25 January 2025 (UTC)
::::::::::Posting here because it's the tab that spawned when I closed the last one, with the acknowledgement of the ping to the other discussion.{{pb}}I'm also favouring an immediate implementation; if new errors arise as a consequence, a rollback is easy, and no one is likely to weigh in against an update pitched as a pure bugfix. [[User:Folly Mox|Folly Mox]] ([[User talk:Folly Mox|talk]]) 15:29, 26 January 2025 (UTC)
{{Implemented}} Please let me know if you see anything odd. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 16:14, 26 January 2025 (UTC)
== Push to clear the last few ones. ==
| 