Module talk:WikiProject banner/Archive 2: Difference between revisions

Revision as of 07:57, 29 December 2008

Revision as of 08:02, 1 January 2009

Line 311:

I'm converting the template for WikiProject Thailand to use WPBannerMeta, but WPBannerMeta categorizes pages without class designation into ''Category:Unassessed foo articles'' instead of ''Category:Unassessed-Class foo articles''. I understand that the categories will update in time, but I wonder if this will confuse the WP 1.0 bot. Shouldn't there a way to keep the old categorizing scheme? --[[User:Paul_012|Paul_012]] ^{([[User talk:Paul_012|talk]])} 16:30, 13 December 2008 (UTC)

:The 1.0 bot is fairly good at picking up on category renames such as this; it shouldn't give you any problems. Just make sure that the new category is in the same parent categories (particularly [[:Category:Unassessed articles]]) as the old. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 22:51, 13 December 2008 (UTC)

== Redesign needs testing ==

I have spent most of this evening refining a complete redesign of the template's code flow, to reduce duplication of processor-intensive code snippets and make the design more streamlined and hence more robust. It should also make it possible/easier to complete some of the tasks on the todo list and requests outstanding on this page, most notably a more refined implementation of the extended quality scale. The changes are very substantial and involve modifications to every code subpage; consequently, I'm anxious to test the new design thoroughly before deploying it on all 600,000-some pages where the live banner appears. I would very much appreciate the assistance of anyone floating around this page who has some spare time (<tt>:D</tt>) to test the innumerable features to make sure they all still function as expected. {{tlx|WPBannerMeta/sandbox}} is running the new code at the moment; there is a test banner at [[template:WPBannerMeta/test]] and some examples at [[Template:WPBannerMeta/testcases]]. Please feel free to edit either of those pages to test any new functions or construct your own tests, but note that the new code runs from unprotected templates, so should ''not'' be deployed on any live banners. Categories can be enabled by removing the {{para|category}} parameters in the examples at /testcases. Please post any bugs or comments here. Many thanks in advance, <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 00:03, 1 December 2008 (UTC)

:I am not sure what parts are meant to be working for this test and what aren't, so forgive me if I provide a redundant comment:

:*|COMMENTS=yes seems to be making a call to [[Template:WPBannerMeta/comments/sandbox]], which doesn't exist right now.

:*|FULL_QUALITY_SCALE=yes used to produce a warning about missing categories for the extended criteria, but this now appears to be missing.

:*Category space, Image space, Portal space, User space, Help space and Wikipedia space cause the importance field to automatically default to NA, but Template space defaults to unknown importance. Is this intentional? [[User:Road Wizard|Road Wizard]] ([[User talk:Road Wizard|talk]]) 00:40, 1 December 2008 (UTC)

::*All {{fixed}}, I believe. Thanks, <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 17:38, 1 December 2008 (UTC)

:My initial comments:

:*I have changed the link from the comments/sandbox.

:*It still is giving the warnings about missing categories, see [[Template:WPBannerMeta/test]].

:*The width of the picture and assessment labels seems to have increased. Therefore the taskforce text does not line up properly. See the testcase on [[Template:WPBannerMeta/testcases]]. [[User talk:Msgj|Martin]] 12:55, 1 December 2008 (UTC)

::*All {{fixed}}, I believe. Thanks, <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 17:38, 1 December 2008 (UTC)

:Okay a more serious error. Look what happens if you use more than one taskforce. (Bottom of [[Template:WPBannerMeta/testcases]].) [[User talk:Msgj|Martin]] 13:00, 1 December 2008 (UTC)

::Ouch! {{fixed}}. Many thanks, keep up the good work! <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 17:38, 1 December 2008 (UTC)

:Do you know you have two hook_notes on your video games test template? [[User talk:Msgj|Martin]] 13:11, 2 December 2008 (UTC)

::Wasn't me, guv', I just used whatever happened to be there at the time <tt>:D</tt>. Fixed it, although it doesn't really matter. Thanks for noticing tho. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 14:56, 2 December 2008 (UTC)

Request: could you do a mask for [[Template:WPBannerMeta/importancescale]] as you have done with [[Template:WPBannerMeta/qualityscale]] and [[Template:WPBannerMeta/qualityscale/class]]? I think it would help in some ways. [[User talk:Msgj|Martin]] 19:16, 2 December 2008 (UTC)

:Actually the mask for the new code is at [[Template:WPBannerMeta/class]], merging /bcheck and /qualityscale/class. I haven't made a mask for {{para|importance}} before now because there isn't very much normalising to perform, just case-insensitivity AFAIK. Can you think of other values that need to be handled? <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 19:27, 2 December 2008 (UTC)

::It's a bit more complicated than that because it depends on the class as well, doesn't it? It's used more than once on the importancescale page and also it would help when adapting complex project templates. For example, some projects use categories such as X-Class Y-importance Foo articles and these are quite hard to code currently. [[User talk:Msgj|Martin]] 23:00, 2 December 2008 (UTC)

:::This is {{done}}, but I'm not sure how you expect this to make it easier to do category intersections. Note that they will be deprecated by the second generation 1.0 bot anyway. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 15:45, 15 December 2008 (UTC)

== NA importance error? ==

I think that there might be an error somewhere. Talk pages that used to be tagged with {{tl|D&D}} and a class like "redirect" or "category" had "importance" automatically set to NA without having it typed in. Just today or yesterday, the automatic NA-assesment seems to have disappeared and all of those articles are now Unknown-importance. There haven't been any real edits recently to {{tl|D&D}}, so I was wondering if one of the recent changes to this one did something. Thanks! -[[User:Drilnoth|Drilnoth]] ([[User talk:Drilnoth|talk]]) 02:09, 15 December 2008 (UTC)

:Can you provide a link to a page that is displaying incorrectly? The first one I looked at ([[Category talk:Dungeons & Dragons planes of existence]]) seemed to be working okay. [[User talk:Msgj|Martin]] 10:02, 15 December 2008 (UTC)

::[[File talk:CN2 Conan the Mercenary.jpg]] is one. I know that it used to have NA-importance automatically because I created a lot of the file talk pages to assess them. The same thing seems to be the case on cats, project pages, templates, redirects, etc. An example of a redirect is [[Talk:Ellifain]]. The category that you mentioned has "Importance=cat" in it, which I guess translates to "Importance=NA", although before "Quality=cat" would automatically set "Importance=NA." -[[User:Drilnoth|Drilnoth]] ([[User talk:Drilnoth|talk]]) 14:08, 15 December 2008 (UTC)

::Actually [[Category talk:Dungeons & Dragons planes of existence]] works without any parameter. Which suggests it's working for categories but not for redirects or images. Hmmm. [[User talk:Msgj|Martin]] 14:31, 15 December 2008 (UTC)

::Okay, here's a partial answer. The images don't work because of the recent change in the name of that namespace (Image -> File). The banner needs to be updated for this. The redirect and disambiguation ones don't work because of the recent overhaul of the banner. It seems that namespace detection is used now, but of course these two are in mainspace so this doesn't work with them. Happy-melon, can you fix it? :) [[User talk:Msgj|Martin]] 14:37, 15 December 2008 (UTC)

:::(edit conflict) Huh. Indeed; I'd just assumed that all of the ones that used to set it automatically had stopped. It looks like redirects, files, and disambiguation pages are the only ones affected. My bad. -[[User:Drilnoth|Drilnoth]] ([[User talk:Drilnoth|talk]]) 14:40, 15 December 2008 (UTC)

::::{{fixed}} "file" - well spotted Martin! Looks like you get your wish for the importance mask as well - this is too complicated to do inline. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 14:56, 15 December 2008 (UTC)

:::::Great! So the images are fixed, but it still doesn't look like the redirects and disambig pages are fixed. -[[User:Drilnoth|Drilnoth]] ([[User talk:Drilnoth|talk]]) 15:27, 15 December 2008 (UTC)

Ok, we now have an importance mask at {{tlx|WPBannerMeta/importance}}. No support for custom masks until there's evidence that it's actually desired. Does this fix the issues? <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 15:41, 15 December 2008 (UTC)

:Looks like it, although I think that all of the pages need a purge for it to show up right (presumably that'll fix itself over time, though). Thanks for all your help! -[[User:Drilnoth|Drilnoth]] ([[User talk:Drilnoth|talk]]) 15:44, 15 December 2008 (UTC)

::Shouldn't List-class also default to NA-importance? [[User talk:Msgj|Martin]] 20:32, 15 December 2008 (UTC)

:::I don't personally think so; lists are content, sometimes just as important as articles. I can imagine [[list of tulips]] would be important to [[WikiProject Tulips]]. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 20:43, 15 December 2008 (UTC)

::::Okay, you have a good point. But has this changed or has it always been the case? [[User talk:Msgj|Martin]] 21:04, 15 December 2008 (UTC)

:::::I don't think that lists ever set to NA-importance on their own. -[[User:Drilnoth|Drilnoth]] ([[User talk:Drilnoth|talk]]) 21:05, 15 December 2008 (UTC)

There seems to be another problem. <nowiki>{{D&D|class=redirect}}</nowiki> was recently added to two articles, and the template now shows up as being NA-importance and NA-class, not NA-importance and Redirect-class. -[[User:Drilnoth|Drilnoth]] ([[User talk:Drilnoth|talk]]) 23:38, 15 December 2008 (UTC)

:These seem to be working fine now. And I don't think anything was fixed or changed in the meantime, so not sure what happened there. [[User talk:Msgj|Martin]] 11:01, 16 December 2008 (UTC)

Another problem at [[Template_talk:Australian-baseball-stadiums]], the task force is going into a category of "-importance" with no NA in the front. —[[User:Borgarde|Borgarde]]^{[[User Talk:Borgarde|talk]]} 00:58, 16 December 2008 (UTC)

:Yes, this is definitely an error. It seems the taskforces are not using the new importance mask. [[User talk:Msgj|Martin]] 11:01, 16 December 2008 (UTC)

::{{fixed}}. Now I'm ''definitely'' not implementing custom importance masks. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 14:09, 16 December 2008 (UTC)

:::Thanks for that fix, but just to let you know, there is still a problem when there has been no importance assigned, for example, at [[Talk:Alfonso_Soriano]], it displays as the same problem. —[[User talk:Borgarde|Borgarde]] 02:35, 17 December 2008 (UTC)

::::These ones are using the taskforce hook to display extra taskforces so I guess it's because the hook has not yet been updated. [[User talk:Msgj|Martin]] 07:50, 17 December 2008 (UTC)

:::::{{fixed}}, although that makes the /hooks/taskforces hook ''horribly'' inefficient... oh well, what can you do? <tt>:D</tt> <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 14:20, 17 December 2008 (UTC)

== FQS ==

#Can someone replace the two instances of "FULL_QUALITY_SCALE" on [[Template:WPBannerMeta/core]] with "FQS" to fix an error.

#Why isn't FQS passed to the qualityscale subtemplate? I think that, if FQS is not enabled, classifying a page as, for example, Image-class, should result in NA-class. This is not happening anymore. [[User talk:Msgj|Martin]] 21:03, 15 December 2008 (UTC)

:{{para|FQS}} is no longer passed into /core, so that won't fix the issue. The whole /templatepage code needs to be rewritten. The output of /qualityscale is now entirely controlled by what is given to it by /class, so any errors will come from there. Can you show me an example of the second error, please? <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 21:13, 15 December 2008 (UTC)

::#Sorry, I saw FQS on the main template but see now that it is not passed. I haven't worked out this core yet. Just as I was working out how everything worked, you changed it all :)

::#Sorry again, seems I am mistaken.

::#I'll have a go at the templatepage coding. But FQS will need passing to the core, won't it? [[User talk:Msgj|Martin]] 21:53, 15 December 2008 (UTC)

:::Since it needs to take account of custom masks if they exist, I was thinking of caling /class each time to see which inputs are accepted. But then again, it will still need {{para|FQS}} to do that correctly... I can pass it through if you think it would help you... <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 14:01, 16 December 2008 (UTC)

::::I think if someone is clever enough to set up a custom mask then they should be able to create the categories without prompting :) So I suggest we just use the standard ones. However I would like to set up prompting for ATTENTION_CAT, INFOBOX_CAT, NOTE_1_CAT, etc. Would it make more sense to call templatepage from the main template rather than the core? [[User talk:Msgj|Martin]] 14:11, 16 December 2008 (UTC)

:::::It doesn't really make much difference, since all those parameters have to be passed through anyway. In fact if you want to check for the other categories you'd be better off taking the parameters out of /core once they've already been normalised. But I agree with you on the custom mask thing. So we don't need to check /class every time, just one check for the existance of a custom mask (in which case abort). What parameters do you want passed to /templatepage? <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 14:16, 16 December 2008 (UTC)

::::::I'll need to think about this (and work out what on earth you've done with this template :P) but for now I'd say quality scale, full quality scale, assessment cat (defaulting to project+articles), plus '''all''' other category parameters. [[User talk:Msgj|Martin]] 14:32, 16 December 2008 (UTC)

::The short answer to "what on earth have I done with this template?" is that I moved the code that was in the main template to /core, and replaced the main template with a transparency, just passing every parameter through unchanged. Then I went through all the subtemplates looking for where tests were done repeatedly on the same value, and instead of doing them repeatedly I moved the code such that it's only done once, when the parameter is passed through to /core. For instance, the link to the project page, {{para|PROJECT_LINK}}, was regularly tested; if it wasn't defined, it defaulted to "Wikipedia:WikiProject {{{PROJECT}}}". So I moved that code to only do that once. Thus I got to remove a lot of duplication. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 17:25, 16 December 2008 (UTC)

== Comments ==

On [[Talk:Pink Floyd]], look at the Pink Floyd banner and check the comments. A table of contents for the whole talk page (not the comment page) is appearing in there. Has something gone wrong? [[User talk:Msgj|Martin]] 10:36, 17 December 2008 (UTC)

:It was due to a header in the comments sub page. —[[User talk:Borgarde|Borgarde]] 12:59, 17 December 2008 (UTC)