Module talk:WikiProject banner/Archive 3: Difference between revisions

Content deleted Content added
MiszaBot II (talk | contribs)
m Archiving 3 thread(s) from Template talk:WPBannerMeta.
MiszaBot II (talk | contribs)
m Archiving 5 thread(s) from Template talk:WPBannerMeta.
Line 239:
What does the listas parameter do for WPBannerMeta?--[[User:Ipatrol|Ipatrol]] ([[User talk:Ipatrol|talk]]) 20:52, 8 January 2009 (UTC)
:It kind of works as a defaultsort for banner categories. For a working verson check out {{tl|WPBIO}} <font color="green" face="Comic Sans MS">[[User:Stepshep|§hep]]</font> • <font color="green" face="Comic Sans MS">[[User talk:Stepshep|¡Talk to me!]]</font> 17:32, 9 January 2009 (UTC)
== extra | in importance ==
 
High, mid and low importance ratings have gained an extra | in the rating box, eg [[Talk:Australian dollar]]. [[Template:WikiProject Business & Economics]] is particularly badly affected, with some text missing eg [[Talk:Bank of New York Mellon Corporation]]. [[User:TRS-80|TRS-80]] ([[User talk:TRS-80|talk]]) 18:16, 11 January 2009 (UTC)
:{{Fixed}} nothing to do with WPBM: [http://en.wikipedia.org/w/index.php?title=Special:Contributions&dir=prev&offset=20090111182606&limit=6&target=Happy-melon]. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 18:32, 11 January 2009 (UTC)
 
== Quality Hooks ==
 
Currently, there are two hooks for adding extra quality scales into a banner: {{tl|WPBannerMeta/hooks/qualitycats}} and {{tl|WPBannerMeta/hooks/additquals}}. Just wondering if there is really a need for both versions. We just really need one. Which one is best? -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 09:37, 12 January 2009 (UTC)
 
:/aditquals is less cleanly-coded (missing case-insensitivity, etc), but /qualitycats can only handle one set of categories at a time. Which one is more widely used? <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 10:29, 12 January 2009 (UTC)
 
:: All there appears to be is one use of each: [http://en.wikipedia.org/w/index.php?title=Special%3AWhatLinksHere&target=Template%3AWPBannerMeta%2Fhooks%2Fqualitycats&namespace=10 qualitycats], [http://en.wikipedia.org/w/index.php?title=Special%3AWhatLinksHere&target=Template%3AWPBannerMeta%2Fhooks%2Fadditquals&namespace=10 additquals]. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 10:50, 12 January 2009 (UTC)
 
:::It was a pretty marathon effort (I had about ten catgory warning boxes under the template at one point!) but I converted WPBeatles to use /qualitycats, so /additquals is unused. Msjg, do you mind if we delete in the interests of cleanliness, rather than redirecting? <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 12:14, 12 January 2009 (UTC)
 
::::You've gone and used {{tl|WPBannerMeta/qualityscale}} in WPBeatles. So do we actually need either hook? -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 12:38, 12 January 2009 (UTC)
 
:::::Argh! On a pure technical level, no we don't, in the same way we don't ''need'' /hooks/notes or /hooks/taskforces. They're just wrappers for the internal templates. But they're wrappers that we need, because otherwise if we change the way things feed into the internal subtemplates, we have to update every banner that calls the subtemplates directly. If there's a complete and consistent 'shell' around the 'core' functions, we only need to ensure that the two interface ''with each other'' properly, and don't have to go hunting all over wikipedia to find the wierd and wonderful ways people have used the core templates directly. So while they might just be wrappers at the moment, it's still important to have them, and use them. So I've updated WPBeatles, and fixed the /hooks/qualitycats documentation that prompted me to use the internal template in the first place <tt>:D</tt> <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 13:15, 12 January 2009 (UTC)
 
No, I don't mind. It's good to be clean. A problem with the Beatles template, as I noted [[Template_talk:WPBeatles#Quality_and_importance_scales|here]] last year is that FQS is selectively used. I don't think you have sorted this problem yet. [[User talk:Msgj|Martin]] 13:06, 12 January 2009 (UTC)
 
:Thanks. Indeed not, that's a problem, and one that's become ''more'' difficult to fix with the new class masks... Hmn.... <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 13:19, 12 January 2009 (UTC)
::Of course, if you call the taskforce hook, you can specify FQS separately. [[User talk:Msgj|Martin]] 13:20, 12 January 2009 (UTC)
 
== Funny spacing ==
 
<s>On my browser the two NA's are not aligned in this banner:</s>
{{tlx|WP Crime|category=no}}
:That was quick! [[User talk:Msgj|Martin]] 13:38, 12 January 2009 (UTC)
::I'm bored <tt>:D</tt> <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 13:40, 12 January 2009 (UTC)
 
== WPBannerMeta/hooks/priorityscale ==
 
In the hook, [[Template:WPBannerMeta/hooks/priorityscale]], could the importance parameter be changed from
<pre> |importance={{{importance|}}}</pre>
to
<pre> |importance={{WPBannerMeta/importance|{{{importance|}}}|{{{class|}}}}}</pre>
as currently, it's use on {{tl|Business}} doesn't quite work properly on some pages.
Thanks.
(PS: Once it's fixed, {{tl|WikiProject Mathematics}} could also use it)
-- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 21:51, 12 January 2009 (UTC)
 
:Also, PROJECT_LINK can be removed as it doesn't do anything. And is there any reason why SHOW shouldn't always be YES and not a parameter as well? -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 21:57, 12 January 2009 (UTC)
 
::The 'invisible' version is used on eg {{tlx|WPBeatles}}. Rest is {{done}} <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 22:11, 12 January 2009 (UTC)
 
Just wondering if the following would be better, which would then show the scale on the template page (as the importance scale usually is).
<pre>
<includeonly>{{#ifeq:{{{BANNER_NAME}}}|{{FULLPAGENAME}}|{{#ifeq:{{{category|¬}}}|¬|<!--
Template Version -->{{WPBannerMeta/importancescale
|importance={{WPBannerMeta/importance|High|{{{class|}}} }}
|class={{{class|}}}
|SHOW={{{SHOW|}}}
|BANNER_NAME={{{BANNER_NAME}}}
|ASSESSMENT_CAT={{{ASSESSMENT_CAT|}}}
|ASSESSMENT_LINK={{{ASSESSMENT_LINK|}}}
|category=no
|{{#if:{{{IMPORTANCE_SCALE_NAME|}}}|IMPN|xxx}}={{{IMPORTANCE_SCALE_NAME|}}}
}}|<!--Core Version -->{{WPBannerMeta/importancescale
|importance={{WPBannerMeta/importance|{{{importance|}}}|{{{class|}}} }}
|class={{{class|}}}
|SHOW={{{SHOW|}}}
|BANNER_NAME={{{BANNER_NAME}}}
|ASSESSMENT_CAT={{{ASSESSMENT_CAT|}}}
|ASSESSMENT_LINK={{{ASSESSMENT_LINK|}}}
|category={{{category|¬}}}
|{{#if:{{{IMPORTANCE_SCALE_NAME|}}}|IMPN|xxx}}={{{IMPORTANCE_SCALE_NAME|}}}
}}}}|<!--Core Version -->{{WPBannerMeta/importancescale
|importance={{WPBannerMeta/importance|{{{importance|}}}|{{{class|}}} }}
|class={{{class|}}}
|SHOW={{{SHOW|}}}
|BANNER_NAME={{{BANNER_NAME}}}
|ASSESSMENT_CAT={{{ASSESSMENT_CAT|}}}
|ASSESSMENT_LINK={{{ASSESSMENT_LINK|}}}
|category={{{category|¬}}}
|{{#if:{{{IMPORTANCE_SCALE_NAME|}}}|IMPN|xxx}}={{{IMPORTANCE_SCALE_NAME|}}}
}}}}</includeonly><noinclude>
{{documentation}}
</noinclude>
</pre>
-- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 22:19, 12 January 2009 (UTC)
 
:{{done}}, kinda. I tweaked the code a bit to remove duplication, but it's essentially yours. Good idea: we should try and do that for the other hooks as well. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 22:55, 12 January 2009 (UTC)
 
== Documentation and To-Do Lists ==
 
Someone might want to change the Documentation from showing to-do lists as to be done with <tt>[[Template:WPBannerMeta#Collapsed_section|Collapsed section]]</tt> to do it with the <tt>HOOK_BOTTOM</tt> settings. [[User:Peachey88|Peachey88]] <sup>([[User_Talk:Peachey88|Talk Page]] | [[Special:Contributions/Peachey88|Contribs]])</sup> 00:12, 13 January 2009 (UTC)
 
:Hi, I've changed the docs for that section a bit & added a note about the hook for todo lists. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 07:45, 13 January 2009 (UTC)