Content deleted Content added
MiszaBot II (talk | contribs) m Archiving 2 thread(s) from Template talk:WPBannerMeta. |
MiszaBot II (talk | contribs) m Archiving 3 thread(s) from Template talk:WPBannerMeta. |
||
Line 586:
Right I am now sick of [[Template:D&D]]. I lost count of how many times I had to use the custom class and importance masks so I did something which is probably a Bad Idea: put the whole thing into a core. <s>It seems to be working except that the core doesn't think it's the templatepage and I can't work out why not.</s> Any help to make this code more efficient is definitely welcome! [[User talk:Msgj|Martin]] 14:53, 19 January 2009 (UTC)
:And another thing which is completely annoying me. Sometimes it accepts D&D, other times you have to type D&D and there doesn't seem to be any logic to it. [[User talk:Msgj|Martin]] 14:55, 19 January 2009 (UTC)
== Sandbox templates ==
How about putting the templates that are in /sandbox pages into a separate category, [[:Category:WikiProject banners under development]] say, instead of putting them into either of the two main categories. Could also do the same for any versions in the User space as well. What do you think? -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 22:34, 14 January 2009 (UTC)
:Good idea, but I'm not sure how you detect whether a page is in a /sandbox. Maybe the titleparts parser function? [[User talk:Msgj|Martin]] 22:39, 14 January 2009 (UTC)
::<tt><nowiki>{{lc:{{SUBPAGENAME}}}}</nowiki></tt> can be used to detect if you are on a sandbox page. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 23:02, 14 January 2009 (UTC)
:::I've created that cat & it is now populated. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 23:20, 14 January 2009 (UTC)
::::Wow, great! [[User talk:Msgj|Martin]] 23:38, 14 January 2009 (UTC)
:::::There are some in [[:Category:WikiProject banners with formatting errors]] though at the moment (due to the issue with the BANNER_NAME as you mention below) -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 23:54, 14 January 2009 (UTC)
On a related note, I would like to request the following. When BANNER_NAME = Template:XXX, the template will behave the same if it is in the sandbox, i.e. if the page name is Template:XXX/sandbox. This will help when moving a template from the sandbox into the main template. [[User talk:Msgj|Martin]] 22:41, 14 January 2009 (UTC)
:{{done}}. Note that my implementation breaks instances where {{para|BANNER_NAME}} is ''set'' as eg [[Template:WPAstronomy/sandbox]], these need to be fixed. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 16:13, 15 January 2009 (UTC)
::We have a small problem here on my own WikiProject's template. We have {{tl|WPAFC/project}} which is a separate banner to {{tl|WPAFC}}. (Finally sorted out for good that problem of separating the two types of article!) But now your tweak to implement the above is affecting this template ... [[User talk:Msgj|Martin]] 22:16, 19 January 2009 (UTC)
:::Surely you can just set {{para|BANNER_NAME|Template:WPAFC}} and it will function normally, albeit by a somewhat counterintuitive method? <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 22:29, 19 January 2009 (UTC)
::::No, because it's looking for the custom mask in the wrong place! [[User talk:Msgj|Martin]] 22:32, 19 January 2009 (UTC)
:::::OH. <tt>:X</tt> Can't really think of how to resolve that without restricting the sandbox functionality purely to BANNER_NAME/sandbox pages, which is not desirable. You might have to move the template to {{tlx|WPAFC-project}} or somesuch. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 23:20, 19 January 2009 (UTC)
::::::You should move it to {{tl|WPAFC administration}} (or something similar) and the redirect link would still be there. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 23:38, 19 January 2009 (UTC)
:::::::I suppose I could ... but would it not be possible to interpret either the actual page name ''or'' the base page as the templatepage? [[User talk:Msgj|Martin]] 21:15, 20 January 2009 (UTC)
:{{fixed}}, although I see you've already moved the template. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 21:17, 24 January 2009 (UTC)
== B-class checklist ==
A couple of people have made a comment (and I agree) that the B-class checklist can be a bit confusing, mainly because the "B" is very prominent and it can give the impression of having two classes, or of having class B when it isn't. With this in mind I asked [[User:RobHar]] (who is good with images) to design something where the B is less prominent. He came up with
::{| cellspacing="0" style="width: 100px;"
| style="width: 45px; height: 45px; background:#c8fb7b; text-align: center;" | [[File:Bclass-checklist.svg|40px]]
|}
which combines the B with the magnifying glass and which I quite like. I suggest that when collapsed, the B-class checklist line takes just one line compared with two currently and that this image be used. Perhaps when it is expanded, the separate B and magnifying glass is used again (if this is possible). Thoughts? [[User talk:Msgj|Martin]] 22:01, 18 January 2009 (UTC)
:I ''love'' that, but please can we have it without the green background built into the image. We're moving towards having the colours coming entirely from CSS, which means they can be fully skinned. But if someone changes the B-Class colour (or if the default colour is changed) the image will look ''horrible''. But if we can have it with a fully-transparent background, then we're on to a winner.
:It's not possible to change the image when the collapsible section is opened. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 23:01, 18 January 2009 (UTC)
::Might have to purge your cache, but the background is gone. This might be my lucky day after all. I've been without InkScape for..geez, verging on two monthsish? Anyways, it's working now. <font color="green" face="Comic Sans MS">[[User:Stepshep|§hep]]</font> • <font color="green" face="Comic Sans MS"><sup>[[User talk:Stepshep|Talk]]</sup></font> 00:29, 20 January 2009 (UTC)
:::Great! Well done. Can we implement please? [[User talk:Msgj|Martin]] 21:17, 20 January 2009 (UTC)
::::{{done}} Looks great! <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 22:24, 21 January 2009 (UTC)
Just saw the updated version on [[Talk:German Empire]] and the greens don't quite match.
*MediaWiki:Common.css - #B2FF66;
*Template:WPBannerMeta/bchecklist - #B2FF66
*Template:Cat class - #b2ff66
*Template:B-Class - #c2ff66
It's not actually an issue with the banner code, but actually to be a problem with [[Template:B-Class]] template. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 23:27, 21 January 2009 (UTC)
:Further evidence of why we need these colours centralised. {{fixed}} in {{tlx|B-Class}}. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 23:37, 21 January 2009 (UTC)
::<s>I'm interested in why it's rated B-class and not all the criteria are checked</s> ... Secondly, my idea was that this could take up just one line when it was collapsed. Did you try this? [[User talk:Msgj|Martin]] 23:41, 21 January 2009 (UTC)
:::<small>Oops, that would be my fault as I converted this banner! [[User talk:Msgj|Martin]] 23:43, 21 January 2009 (UTC)</small>
::::On my screen it ''does'' take up just one line, although the row is slightly taller than the others thanks to the image. What screen resolution are you using? Or have I misunderstood you entirely? <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 23:52, 21 January 2009 (UTC)
:::::On mt screen, the cell is twice the height as the C-class box above it. Resolution currently 1280x800. [[User talk:Msgj|Martin]] 23:56, 21 January 2009 (UTC)
::::::Appears to be double the class template size for me to; I also noticed on this particular banner the first [Show] is cut off. ([[:File:BannerMeta B-Class.png|Screenshot]]) Vista/IE7 1440x900 <font color="green" face="Comic Sans MS">[[User:Stepshep|§hep]]</font> • <font color="green" face="Comic Sans MS"><sup>[[User talk:Stepshep|Talk]]</sup></font> 01:16, 22 January 2009 (UTC)
It's not this particular banner. It seems to be on all those that use the B-class checklist. I can see it happening on, e.g. {{tl|WikiProject Iran}} and {{tl|WikiProject Nevada}} as well. [[User talk:Msgj|Martin]] 08:53, 22 January 2009 (UTC)
{{WPBannerMeta/test|class=C|b1=yes|b2=no|b3=|cleanup=yes|~IMG_SIZE=30px|category=no}}
{{WPBannerMeta/test|class=C|b1=yes|b2=no|b3=|cleanup=yes|~IMG_SIZE=25px|category=no}}
{{WPBannerMeta/test|class=C|b1=yes|b2=no|b3=|cleanup=yes|~IMG_SIZE=20px|category=no}}
{{WPBannerMeta/test|class=C|b1=yes|b2=no|b3=|cleanup=yes|~IMG_SIZE=15px|category=no}}
Here are a few different sizes of image. Which one is preferred? <s>I would also quite like to find a way of centering the "B" within the box, but we can play with that once we have a good size.</s> Preferences? <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 12:05, 22 January 2009 (UTC)
:Third one down? [[User talk:Msgj|Martin]] 14:03, 22 January 2009 (UTC)
::Could we have one where the [Show] for the checklist isn't cutoff? <font color="green" face="Comic Sans MS">[[User:Stepshep|§hep]]</font> • <font color="green" face="Comic Sans MS"><sup>[[User talk:Stepshep|Talk]]</sup></font> 22:29, 22 January 2009 (UTC)
:::We could, yes, but it's so much cooler to only show the "sh", don't you think? <tt>:D</tt> Of course we can try and fix it; I'll see what can be done (or you can have an experiment yourself). As to ''this'' question, though, which image size do you prefer? <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 08:38, 23 January 2009 (UTC)
::::Hehe, 3rd one down. <font color="green" face="Comic Sans MS">[[User:Stepshep|§hep]]</font> • <font color="green" face="Comic Sans MS"><sup>[[User talk:Stepshep|Talk]]</sup></font> 22:08, 23 January 2009 (UTC)
:::::I think I've now fixed the cutting-off issue. Does it look ok in all your browsers? <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 21:41, 24 January 2009 (UTC)
::::::Looks great. 01:27, 25 January 2009 (UTC)
== /istemplate ==
Is a new subtemplate that takes {{para|BANNER_NAME}} and {{para|category}} and returns "yes" if it thinks the banner being rendered should display as an 'all options showing' example ''a la'' its appearance on template pages (null otherwise). This is to make it easier to be consistent in separating templatepage demonstrations from 'real' templates, and to make it easier to improve thsi functionality at a later date if desired, without having to chase things all over the code.
A couple of consequences: first, there's now no excuse for us not to add 'all options showing' examples to all hooks. I've done a few already, let me know if I miss any. Secondly, it means that we now need to pass {{para|BANNER_NAME}} pretty much everywhere, so we need to update docs etc, and existing banners, to make sure that examples are shown when they've been coded.
Thanks for all your help as always. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 22:16, 21 January 2009 (UTC)
:The change you did to hook/peerreview didn't make it show in the templates but I've got a [[Template:WPBannerMeta/hooks/peerreview/sandbox|sandbox version]] that works. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 22:36, 21 January 2009 (UTC)
::If you wanted to make the /istemplate, work with Martins {{tl|WPAFC/project}} banner, the following code should work.
<pre>
{{#ifexpr:({{#ifeq:{{{BANNER_NAME}}}|{{FULLPAGENAME}}|1|0}}+{{#ifeq:{{lc:{{{BANNER_NAME}}}/sandbox}}|{{lc:{{FULLPAGENAME}}}}|1|0}})*{{#ifeq:{{{category|¬}}}|¬|1|0}}|yes|<!--no-->}}
</pre> -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 23:52, 21 January 2009 (UTC)
:{{done}}, kinda. It works, anyway. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 21:42, 24 January 2009 (UTC)
| |||