Module talk:WikiProject banner/Archive 4: Difference between revisions

Revision as of 08:07, 15 March 2009

Revision as of 08:09, 18 March 2009

Line 19:

:::Thanks for fixing that. I'm pretty sure that all of the task forces were displayed before I created the hide subpage, but since it is working now, I guess it doesn't really matter. --[[User:Scottalter|Scott Alter]] 22:35, 27 February 2009 (UTC)

Doing sanity-checks for things added by hooks is probably ''possible'', but certainly rather complicated. I'll have to have a think about it... <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 18:25, 28 February 2009 (UTC)

== Migrating [[Template:WPAVIATION]] ==

I would like to switch [[Template:WPAVIATION]] over to this code. The only thing stopping me from already having done this is the fact that out b-class checklist has only 5 items, the same as the Military history checklist, and not the 6 I thought the meta required. But I just found [[Template:WPBannerMeta/class]] and am wondering if I'm reading it right. Can it be used to incorporate our style of checklist? - [[User:Trevor MacInnis|Trevor]] [[User talk:Trevor MacInnis|MacInnis]] <small>([[Special:Contributions/Trevor MacInnis|Contribs]])</small> 20:25, 19 February 2009 (UTC)

:Yes, you can implement it with the five items. Alternatively you could use six items but set the 6th to "yes" by default so that the existing articles are not affected. That might be confusing though. [[User talk:Msgj|Martin]] 21:04, 19 February 2009 (UTC)

::Actually, looking at [[Template:WPBannerMeta/class]], it doesn't look like the 6th parameter is currently checked for the B class assessment. That might be a bug in the WPBannerMeta code. For more complicated banners such as WPAVIATION, it's alway good to start the changes in a [[Template:WPAVIATION/sandbox|sandbox]] version first and see how it goes. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 21:14, 19 February 2009 (UTC)

:::That is indeed a bug, now {{fixed}}. How well do the 5 milhist criteria map onto the 6 WP1.0 criteria? <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 22:42, 19 February 2009 (UTC)

::::It looks like it's just that they don't use b6. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 08:02, 20 February 2009 (UTC)

An option in core to use a custom bchecklist, just like the custom class would would (I think).

Change

<pre>

{{#if:{{{B_CHECKLIST|}}}|

{{WPBannerMeta/bchecklist|class={{{class|}}}|b1={{{b1|}}}|b2={{{b2|}}}|b3={{{b3|}}}|b4={{{b4|}}}|b5={{{b5|}}}|b6={{{b6|}}} }}

}}

</pre>

To

<pre>

{{#if:{{{B_CHECKLIST|}}}|{{#ifexist:{{{BANNER_NAME}}}/bchecklist

|{{ {{{BANNER_NAME}}}/bchecklist|class={{{class|}}}|b1={{{b1|}}}|b2={{{b2|}}}|b3={{{b3|}}}|b4={{{b4|}}}|b5={{{b5|}}}|b6={{{b6|}}} }}

|{{WPBannerMeta/bchecklist|class={{{class|}}}|b1={{{b1|}}}|b2={{{b2|}}}|b3={{{b3|}}}|b4={{{b4|}}}|b5={{{b5|}}}|b6={{{b6|}}} }}

}}

}}

</pre>

-- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 08:11, 20 February 2009 (UTC)

:It would be kinder to write a hook for {{para|HOOK_IMPORTANCE}} rather than add another #ifexist: call to all million-odd transclusions. This is the first project other than MilHist that I've seen to use the 5-point scale. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 08:47, 20 February 2009 (UTC)

::WikiProject Films and WikiProject Comics also use the 5-point scale. :) [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 16:49, 20 February 2009 (UTC)

The template is almost ready for the changover, but there is just one issue (that I can see) that needs fixing. The hooks for collaboration and peer review are not giving the links I'm looking for. The "currently" link in the peer review doubles the subject page name, so the link is <nowiki>[[Wikipedia:WikiProject_Aviation/Peer_review/SUBJECTPAGENAME/SUBJECTPAGENAME]]</nowiki>. The same happens in the "archived" link, and the "candidate" link in the collaboration hook. - [[User:Trevor MacInnis|Trevor]] [[User talk:Trevor MacInnis|MacInnis]] <small>([[Special:Contributions/Trevor MacInnis|Contribs]])</small> 18:39, 1 March 2009 (UTC)

:I've made a change to the sandbox banner & that should be fixed now. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 19:33, 1 March 2009 (UTC)

== Issues to fix ==

I've found a few issues while trying to convert the aviation banner to this format:

#the b-class checklist allow you to enter random text into the 6 items and still get a b-class assessment, even though the items are still not checked off.

#"y" and "n" seem to work for some items (notes, collaboration, etc) but not for other (bclass checklist, taskforces). Our banner curently uses a subpage [[Template:WPAVIATION/YesNo]] that allow for a variety of entries (y, yes, Yes, YES, etc), can this be incorporated somehow? - [[User:Trevor MacInnis|Trevor]] [[User talk:Trevor MacInnis|MacInnis]] <small>([[Special:Contributions/Trevor MacInnis|Contribs]])</small> 03:05, 26 February 2009 (UTC)

:I've just looked at the code to give you a definitive answer. As things stand:

:#For notes, any value except no, No, NO, or nO or a blank will result in a "yes";

:#For taskforces, any value will result in a "yes" (even "no"!) So you have to leave it blank or undefined to get a "no". We could look at changing this maybe.

:#For the B-class checklist:

:#*yes, Yes, yEs, yeS, etc. produce "criterion met"

:#*No, no, NO, nO produce "criterion not met"

:#*Anything else or blank value produces "not checked"

:Hope this helps, [[User:Msgj|Martin]]^{[[User talk:Msgj|msgj]]} 09:27, 26 February 2009 (UTC)

Sounds good. There are a few things I think the code guru's should check and fix though. You're correct that in the B-class checklist "Anything else or blank value produces "not checked"" in the checklist, but if you were to enter the "anything else" into all 6 parameters, say by copying and pasting the example code from the banner <code>| b1 <!--Referencing & citations--> = <yes/no>

| b2 <!-- Coverage and accuracy --> = <yes/no>

| b3 <!-- Structure --> = <yes/no>

| b4 <!-- Grammar and style --> = <yes/no>

| b5 <!-- Supporting materials --> = <yes/no>

| b6 = <yes/no></code>, this will result in the article assessment being automatically, and incorrectly, changed to "B-Class". It may not be a big issue...unless someone decides to auto tag articles, including the checklist for future use.

Secondly, I think "y" and "n" should be added to the list of accepted terms for "yes" and "no"- [[User:Trevor MacInnis|Trevor]] [[User talk:Trevor MacInnis|MacInnis]] <small>([[Special:Contributions/Trevor MacInnis|Contribs]])</small> 16:16, 27 February 2009 (UTC)

:<s>I am not able to replicate this error. Can you link to an example? [[User:Msgj|Martin]]^{[[User talk:Msgj|msgj]]} 16:30, 27 February 2009 (UTC)</s> Oh, wait. I think I just did. I'll look further. [[User:Msgj|Martin]]^{[[User talk:Msgj|msgj]]} 16:32, 27 February 2009 (UTC)

::Yes, this does seem to be an error. Well done for spotting it. Although the checklist display takes anything other than "no" to mean "yes", the actual calculation of the class takes anything other than "yes" to mean "no"! I think my code in [[Template:WPBannerMeta/class/sandbox]] will fix it. Can someone just check it? [[User:Msgj|Martin]]^{[[User talk:Msgj|msgj]]} 16:49, 27 February 2009 (UTC)

:::I've been tagging articles for [[WP:MEASURE]] over the last couple of days. Our project banner (which uses the checklist) certainly wouldn't let me assess any articles at B-class until I'd filled out the checklist: they were automagically placed at C-class instead. I think that includes C-class articles where I left the checklist unfilled to come back to later, but I can't quickly find an example. On the other hand, the template lets me assess at any other class (including FA!) without a problem. [[User:Physchim62|Physchim62]] [[User talk:Physchim62|(talk)]] 17:07, 27 February 2009 (UTC)

The error is only apparent if something other than yes or no is entered. For example setting b1-b6 as "gobbledygook" and class=b currently results in b-class. I might make one further suggestion, based on something I've seen other banners do. That if the 6 criteria are marked as satisfied, then the article is classified as B-class even if class=start or class=C. Any thoughts on this? [[User:Msgj|Martin]]^{[[User talk:Msgj|msgj]]} 17:13, 27 February 2009 (UTC)

::No. I think it's an important freedom of the project reviewer not to give B-class ''even if'' the criteria are fulfilled. Such a situation should be rare, but I don't think we should make it technically impossible. [[User:Physchim62|Physchim62]] [[User talk:Physchim62|(talk)]] 21:42, 27 February 2009 (UTC)

:The changes you made in class/sandbox nearly work but the b1..b6 parameters need to be put though the lc: thingy somewhere. It may be better to do that in WPBannerMeta or core before it is passed over to class. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 19:23, 27 February 2009 (UTC)

::{{fixed}} I hope. Thanks for the lc reminder. I couldn't avoid doing it twice though. It seems to be working correctly. If not, please let me know. [[User:Msgj|Martin]]^{[[User talk:Msgj|msgj]]} 22:07, 27 February 2009 (UTC)

:::I've updated the example code in the [[Template:WPBannerMeta/class/doc|class docs]] as well. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 22:16, 27 February 2009 (UTC)

===More on the B-class checklist===

I've put a new version on the B-class checklist in the [[Template:WPBannerMeta/bchecklist/sandbox|sandbox]]. It has the following two possible advantages:

#Gives warning of incorrect parameters. The following values are accepted:

#*yes, y, 1 = criterion met

#*no, n, 0 = criterion not met

#*<yes/no>, yes/no, ? or (blank) = not checked

#*Anything else = incorrect parameter warning

#It will accept an input of "unused" from the project banner in which case it will not display anything for that criterion. This might allow projects which use 5-point checklists to use the standard code instead of an extra hook. (But I'm not sure how to change the prompt which appears when no parameters are entered ...)

See my [[User:Msgj/Sandbox2|sandbox]] for an example. What do people think about this? [[User:Msgj|Martin]]^{[[User talk:Msgj|msgj]]} 14:05, 2 March 2009 (UTC)

:"NA" would be a better term than "not used". <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 16:58, 3 March 2009 (UTC)

::Well, maybe, but NA often means "not article" rather than "not applicable", so that's why I tried to avoid it! [[User:Msgj|Martin]]^{[[User talk:Msgj|msgj]]} 17:39, 3 March 2009 (UTC)

Based on your idea I have implemented a "n/a" option so that if the reviewer of an article believes that a criterion is not relevant to an article, he/she can use "n/a" instead of "yes" and still award the B-class. (Of course this is only implemented on the default class mask and not on custom ones yet.) I still think an "unused" option might be useful when a project decides they won't use a particular criterion, and this would alleviate the need for the separate hook. But I think this needs some more thought to do properly. [[User:Msgj|Martin]]^{[[User talk:Msgj|msgj]]} 23:34, 3 March 2009 (UTC)

:That would allow the 5 item b-class checklist to merge into this, but it would need to have a way of having a specific item be "n/a" without having to enter it into every use. - [[User:Trevor MacInnis|Trevor]] [[User talk:Trevor MacInnis|MacInnis]] <small>([[Special:Contributions/Trevor MacInnis|Contribs]])</small> 23:39, 3 March 2009 (UTC)

::Yes, of course. The "unused" parameter, if implemented, would be passed by the project banner template, not the individual instances on talk pages. I think in this case it would be better if the unused criterion was hidden and not marked as "not applicable". [[User:Msgj|Martin]]^{[[User talk:Msgj|msgj]]} 23:49, 3 March 2009 (UTC)

== Custom messages for class/importance ==

A while ago the physics banner linked to the project's [[Wikipedia:WikiProject Physics/Quality Control#Importance Guidelines|guidelines for importance ratings]], but this is not possible under the metabanner. Could custom messages be shown instead (I'm sure other projects would like to link to their own A/B class guidelines too)?[[User:Headbomb|Headbomb]]&nbsp;{^{[[User talk:Headbomb|ταλκ]]}<sub style="margin-left:-4.0ex;">[[Special:Contributions/Headbomb|κοντριβς]]</sub>&nbsp;&ndash;&nbsp;[[WP:PHYS|WP Physics]]} 20:07, 3 March 2009 (UTC)

:You can use the ASSESSMENT_LINK parameter to define what the "rated" link points to. [[User:Msgj|Martin]]^{[[User talk:Msgj|msgj]]} 22:13, 3 March 2009 (UTC)