Content deleted Content added
MiszaBot II (talk | contribs) m Archiving 2 thread(s) from Template talk:WPBannerMeta. |
MiszaBot II (talk | contribs) m Archiving 2 thread(s) from Template talk:WPBannerMeta. |
||
Line 361:
:{{fixed}} was just on that template and others using one particular hook, but I corrected that. Thanks for pointing that out! <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 21:33, 27 March 2009 (UTC)
::Thanks again! --[[User:Funandtrvl|Funandtrvl]] ([[User talk:Funandtrvl|talk]]) 21:41, 27 March 2009 (UTC)
== Bottom importance ==
{{tlx|editprotected}}
Some projects are using a "bottom" option for importance (see [[Template:Bottom-importance]] and [[:Category:Bottom-importance articles]]). This template does not seem to support it at the moment (see the WPRocketry template on [[Talk:Cape Canaveral Air Force Station Launch Complex 1]]). Would it be possible to enable support for it. Thanks. --'''''[[User:GW Simulations|<font color="#115566">G</font>]][[User talk:GW_Simulations|<font color="#496636">W</font>]]'''''[[Special:Contributions/GW_Simulations|…]] 08:29, 29 March 2009 (UTC)
:Please see [[/Archive 3#Bottom-importance]]. —[[User:Ms2ger|Ms2ger]] ([[User talk:Ms2ger|talk]]) 08:51, 29 March 2009 (UTC)
::There is actually a greater use of {{tl|No-importance}}, though I suppose that would be handled by the meta in the same way? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 11:32, 29 March 2009 (UTC)
:As I understand it from the archived page linked to above, the main opposition to the introduction of these features is complexity. I've just created a custom version of this template for WPRocketry to support these parameters. The difference is '''two lines of code''' to allow both options:
<pre>
|no = No
|bottom = Bottom
</pre>
:Inserted between the fourth and fifth lines of [[Template:WPBannerMeta/importance]]. Am I missing something? --'''''[[User:GW Simulations|<font color="#115566">G</font>]][[User talk:GW_Simulations|<font color="#496636">W</font>]]'''''[[Special:Contributions/GW_Simulations|…]] 13:40, 29 March 2009 (UTC)
::That most projects don't want to use No- and/or Bottom-importance. —[[User:Ms2ger|Ms2ger]] ([[User talk:Ms2ger|talk]]) 15:12, 29 March 2009 (UTC)
:However some do, and providing the means for these projects to use this template should not affect those that do not. The fact that a feature is enabled doesn't mean it has to be used. Some projects don't have rating, but the template still provides a means to rate articles. --'''''[[User:GW Simulations|<font color="#115566">G</font>]][[User talk:GW_Simulations|<font color="#496636">W</font>]]'''''[[Special:Contributions/GW_Simulations|…]] 15:24, 29 March 2009 (UTC)
::If a project does not use bottom-importance then it would not usually be desirable for the template to accept such a rating, as it would be classifying articles into non-existent importance classes and categorising into non-existent categories. I agree that this issue is something which needs to be thought about though. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:33, 2 April 2009 (UTC)
::The issue is that by adding the functionality in the manner you suggest, we unavoidably add it for ''all projects'' using WPBM. This means that setting {{para|importance|bottom}} on ''any'' banner will mark it as "Bottom-importance", whether the necessary infrastructure (categories, assessments, project support) exists or not. This is unlike custom quality classes where the class is added only for that project, and is not 'forced' upon all projects. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 18:18, 2 April 2009 (UTC)
== Taskforce hook parameter capitalization bug ==
Currently, for task forces to be enabled that are coded by the hook ([[Template:WPBannerMeta/hooks/taskforces]]), the parameter on talk pages needs to be set to "yes" in lowercase. Using "Yes" as a value will not work. However, task forces coded by WPBannerMeta directly can be set to any capitalization of yes. To fix this, the lc function should be used in [[Template:WPBannerMeta/hooks/taskforces]].
"<code><nowiki>{{#ifeq:{{{tf 1|}}}|yes|</nowiki></code>" should be changed to "<code><nowiki>{{#ifeq:{{lc:{{{tf 1|}}}}}|yes|</nowiki></code>" for each of the 10 tf variables. Thanks. --[[User:Scottalter|Scott Alter]] 13:35, 29 March 2009 (UTC)
:<s>Yes, good idea. I think perhaps we could move the parameter checking to the [[Template:WPBannerMeta/taskforce]] code to avoid repeating it many times. We should also accept "y" as well as "yes". — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:14, 2 April 2009 (UTC)</s> Scratch that. The 5 main taskforces will accept any non-blank parameter (even "no"), so it would seem to make sense to adjust the hook to mimic this behaviour. It might seem illogical to accept "no" but this is the probably simplest and consistent with other parameters. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:24, 2 April 2009 (UTC)
I've created {{tlx|yesno}} as a generic normaliser for this sort of thing and implemented it pretty much universally across WPBM and hooks; it's a bit funny with having to handle the tildes differently in different situations, but it should improve consistency in this area. <font color="forestgreen">[[User:Happy-melon|'''Happy''']]</font>‑<font color="darkorange">[[User talk:Happy-melon|'''melon''']]</font> 18:09, 2 April 2009 (UTC)
:Thanks. --[[User:Scottalter|Scott Alter]] 23:37, 2 April 2009 (UTC)
| |||