Content deleted Content added
MiszaBot II (talk | contribs) m Archiving 2 thread(s) from Template talk:WPBannerMeta. |
MiszaBot II (talk | contribs) m Archiving 2 thread(s) from Template talk:WPBannerMeta. |
||
Line 109:
:Not in the banner code as far as I'm aware. The way to fix it is to add <nowiki>__TOC__</nowiki> below all the banners on the affected talk pages. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 06:36, 11 August 2009 (UTC)
== B-class checklist help ==
I've noticed that [[Template:WPAVIATION]] no longer displays the text showing how to add the b-class checklist (see:[[Talk:Bahrain International Airport]]). Is this an error? I'd like to get it back. - '''[[User:Trevor MacInnis|<span style="font-family:Century Gothic;color:SteelBlue">Trevor</span>]] [[User talk:Trevor MacInnis|<span style="font-family:Century Gothic;color:IndianRed">MacInnis</span>]] [[Special:Contributions/Trevor MacInnis|<span style="font-family:Century Gothic;color:DarkOliveGreen"><sup>contribs</sup></span>]]''' 18:44, 8 August 2009 (UTC)
:To fix it, in [[Template:WPBannerMeta/core]], the following code should be changed to pass through the BANNER_NAME parameter:
<pre>
{{#if:{{{B_CHECKLIST|}}}|{{WPBannerMeta/bchecklist
|class={{{class|}}}
|b1={{lc:{{{b1|}}}}}
|b2={{lc:{{{b2|}}}}}
|b3={{lc:{{{b3|}}}}}
|b4={{lc:{{{b4|}}}}}
|b5={{lc:{{{b5|}}}}}
|b6={{lc:{{{b6|}}}}}
|ASSESSMENT_LINK={{{ASSESSMENT_LINK|}}} }}
</pre>
to
<pre>
{{#if:{{{B_CHECKLIST|}}}|{{WPBannerMeta/bchecklist
|BANNER_NAME={{{BANNER_NAME}}}
|class={{{class|}}}
|b1={{lc:{{{b1|}}}}}
|b2={{lc:{{{b2|}}}}}
|b3={{lc:{{{b3|}}}}}
|b4={{lc:{{{b4|}}}}}
|b5={{lc:{{{b5|}}}}}
|b6={{lc:{{{b6|}}}}}
|ASSESSMENT_LINK={{{ASSESSMENT_LINK|}}} }}
</pre>
-- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 20:12, 8 August 2009 (UTC)
:Will that work for WPAVIATION, which only has 5 b-class parameters? - '''[[User:Trevor MacInnis|<span style="font-family:Century Gothic;color:SteelBlue">Trevor</span>]] [[User talk:Trevor MacInnis|<span style="font-family:Century Gothic;color:IndianRed">MacInnis</span>]] [[Special:Contributions/Trevor MacInnis|<span style="font-family:Century Gothic;color:DarkOliveGreen"><sup>contribs</sup></span>]]''' 20:20, 8 August 2009 (UTC)
::Should do but I haven't been able to fully test. If you look at [[Template:WPBannerMeta/bchecklist]], you'll see that it uses the BANNER_NAME parameter but [[Template:WPBannerMeta/core]] isn't passing that parameter through. WPAVIATION uses a custom class template at [[Template:WPAVIATION/class]] which handles that part, but since BANNER_NAME is not being passed through to [[Template:WPBannerMeta/bchecklist]] it is looking at [[Template:WPBannerMeta/class]] instead of [[Template:WPAVIATION/class]]. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 20:38, 8 August 2009 (UTC)
{{tl|editrequest}}
:::Sounds good, but I don't know enough about the template and its various subpages to do this edit myself. Can someone more familiar with its workings do it? - '''[[User:Trevor MacInnis|<span style="font-family:Century Gothic;color:SteelBlue">Trevor</span>]] [[User talk:Trevor MacInnis|<span style="font-family:Century Gothic;color:IndianRed">MacInnis</span>]] [[Special:Contributions/Trevor MacInnis|<span style="font-family:Century Gothic;color:DarkOliveGreen"><sup>contribs</sup></span>]]''' 02:23, 11 August 2009 (UTC)
:{{done}} and seems to be working. —[[User:TheDJ|Th<span style="color: green">e</span>DJ]] ([[User talk:TheDJ|talk]] • [[Special:Contributions/TheDJ|contribs]]) 11:35, 11 August 2009 (UTC)
Hmm, was this an error of mine? I thought I/we had tested this one thoroughly before changing it ... — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 15:46, 14 August 2009 (UTC)
:Somehow it got removed in [http://en.wikipedia.org/w/index.php?title=Template:WPBannerMeta/core&diff=next&oldid=296321848 this edit]. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 16:14, 14 August 2009 (UTC)
== Suggestions for A-Class and Peer Review hooks ==
A few minor suggestions to make these two hooks more visually consistant...
* At [[Template:WPBannerMeta/hooks/aclass]], change:
<pre>
|TEXT = This article '''[[{{{SUBPAGE_LINK}}}|is undergoing]]''' an [[{{{REVIEW_LINK}}}|A-Class review]].
...
|TEXT = This article '''[[{{{SUBPAGE_LINK}}}|{{#switch:{{lc:{{{a class|}}}}}|pass=has passed|fail=has failed|current=is undergoing}}]]''' an [[{{{REVIEW_LINK|}}}|A-Class review]].
</pre>
to:
<pre>
|TEXT = This article '''[[{{{SUBPAGE_LINK}}}|is currently undergoing]]''' an [[{{{REVIEW_LINK}}}|A-Class review]].
...
|TEXT = This article '''[[{{{SUBPAGE_LINK}}}|{{#switch:{{lc:{{{a class|}}}}}|pass=has passed|fail=has failed|current=is currently undergoing}}]]''' an [[{{{REVIEW_LINK|}}}|A-Class review]].
</pre>
This one is just an idea, but why not use the different icons for current/pass/fail, e.g.
<pre>
|IMAGE = {{#if:{{{IMAGE|}}}|{{{IMAGE}}}|{{#switch:{{lc:{{{a class|}}}}}|pass=Symbol a class|fail=Symbol unsupport A vote|current=A candidate}}.svg}}
</pre>
* At [[Template:WPBannerMeta/hooks/peerreview]], change:
<pre>
|TEXT = This {{#if:{{SUBJECTSPACE}}|page|article}} is [[{{{LINK}}}/{{SUBJECTPAGENAME}}|currently]] being [[{{{LINK|}}}|peer reviewed]].
...
|TEXT = This {{#if:{{SUBJECTSPACE}}|page|article}} has had a [[{{{LINK}}}|peer review]] which is now [[{{{LINK}}}/{{SUBJECTPAGENAME}}|archived]].
...
|TEXT = This {{#ifeq:{{{class|}}}|NA|page|article}} is [[{{{LINK}}}/{{SUBJECTPAGENAME:{{#if:{{{title|}}}|{{{title}}}|{{FULLPAGENAME}}}}}}|currently]] being [[{{{LINK|}}}|peer reviewed]].
...
|TEXT = This {{#ifeq:{{{class|}}}|NA|page|article}} has had a [[{{{LINK}}}|peer review]] which is now [[{{{LINK}}}/{{SUBJECTPAGENAME:{{#if:{{{title|}}}|{{{title}}}|{{FULLPAGENAME}}}}}}|archived]].
</pre>
to:
<pre>
|TEXT = This {{#if:{{SUBJECTSPACE}}|page|article}} '''[[{{{LINK}}}/{{SUBJECTPAGENAME}}|is currently undergoing]]''' a [[{{{LINK|}}}|peer review]].
...
|TEXT = This {{#if:{{SUBJECTSPACE}}|page|article}} has had a [[{{{LINK}}}|peer review]] which is '''[[{{{LINK}}}/{{SUBJECTPAGENAME}}|now archived]]'''.
...
|TEXT = This {{#ifeq:{{{class|}}}|NA|page|article}} '''[[{{{LINK}}}/{{SUBJECTPAGENAME:{{#if:{{{title|}}}|{{{title}}}|{{FULLPAGENAME}}}}}}|is currently undergoing]]''' a [[{{{LINK|}}}|peer review]].
...
|TEXT = This {{#ifeq:{{{class|}}}|NA|page|article}} has had a [[{{{LINK}}}|peer review]] which is '''[[{{{LINK}}}/{{SUBJECTPAGENAME:{{#if:{{{title|}}}|{{{title}}}|{{FULLPAGENAME}}}}}}|now archived]]'''.
</pre>
Also (I've mentioned this elsewhere) add a {{para|SIZE}} parameter as per the A-Class hook by changing all instances of:
<pre>
|SIZE = 30px
</pre>
to:
<pre>
|SIZE = {{#if:{{{SIZE|}}}|{{{SIZE}}}|30px}}
</pre>
Thoughts? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 23:01, 27 July 2009 (UTC)
:The <tt><nowiki>{{#ifeq:{{{class|}}}|NA|page|article}}</nowiki></tt> part of the peerreview template should be changed to <tt><nowiki>{{pagetype}}</nowiki></tt> as class isn't even a parameter in the peerreview template. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 06:37, 28 July 2009 (UTC)
{{done}} I like all of these suggestions. [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 11:00, 28 July 2009 (UTC)
:Thanks! Not sure if it was intentional or not, but you missed the bold text in the peer review hook... ;) [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 21:17, 28 July 2009 (UTC)
::It was accidental, but I'm not sure which I prefer. {{tlx|ChicagoWikiProject}} has both in play; what do people think? [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 21:28, 28 July 2009 (UTC)
:::I don't mind terribly whether you opt for bolded or unbolded text, I just think it should be consistant across the two hooks. But personally I would say the bold because it highlights the most relevant link. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 22:02, 28 July 2009 (UTC)
<nowiki>*</nowiki>bumped out of archive* If there is no objection here can we get this finished up and make these two hooks consistant on their use of bolded text? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 16:25, 14 August 2009 (UTC)
:{{done}} — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 21:09, 14 August 2009 (UTC)
| |||