Content deleted Content added
MiszaBot II (talk | contribs) m Archiving 2 thread(s) from Template talk:WPBannerMeta. |
MiszaBot II (talk | contribs) m Archiving 2 thread(s) from Template talk:WPBannerMeta. |
||
Line 255:
Is it possible to set up the banner in such a way that an article can be assessed for two different work groups while displaying only the name, etc., of one work group? [[User:John Carter|John Carter]] ([[User talk:John Carter|talk]]) 15:58, 25 August 2009 (UTC)
:Sure. Tell me which banner and work group you have in mind? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 23:00, 25 August 2009 (UTC)
== Feature request for A-Class hook ==
The coding for A-Class review in a number of non-meta project banners (specifically {{tl|WPBiography}}, {{tl|Film}} and {{tl|WPMILHIST}}) includes a number of checks to ensure that articles are tagged correctly. To facilitate the conversion of {{tl|WPBiography}} (and perhaps in time those other two) I would like to request that the necessary support for this feature be added to the A-Class hook here.
I've prepared some code at {{tl|WPBannerMeta/hooks/aclass/sandbox}} and tested it with {{tl|WPBiography/sandbox}}. This adds <s>two</s> one optional parameter<s>s</s> to the existing hook:
*<s>{{para|CHECK_SUBPAGE}} which should be set to "yes" to perform an ifexist check for {{{SUBPAGE_LINK}}}, and</s>
*{{para|INVALID_CAT}} which both activates the check and sets the category for incorrectly tagged articles.
What this does:
*If {{para|a class}} is set to pass/fail/current but a review subpage does not exist, then {{{PASS_CAT}}}, {{{FAIL_CAT}}} and {{{CURRENT_CAT}}} will be ignored in favour of {{{INVALID_CAT}}}.
*If {{para|a class}} is not set but a review subpage exists, then an article is added to {{{INVALID_CAT}}}.
Thoughts on the above? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 23:52, 26 August 2009 (UTC)
:Support in principle. Last feature is unlikely to work because the hook is not even called if the parameter is not defined. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 06:19, 27 August 2009 (UTC)
::I think this stuff ought to just be enabled by default. No need to have to specifically request it. Certainly it should be done if {{para|INVALID_CAT}} is defined. [[User:Also-Happy-melon|<small style="color:red">(also)</small>]][[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 11:02, 27 August 2009 (UTC)
:::Good call, I've removed {{para|CHECK_SUBPAGE}} and the checks are now enabled if {{para|INVALID_CAT}} is defined. The last feature seems to work fine in the testing I've done. You guys should of course check over the code I've written, though. :) [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 17:44, 27 August 2009 (UTC)
::::Looks ok to me. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 19:47, 27 August 2009 (UTC)
::::{{twomanrule}} I tweaked the code a little to remove redundancy: can you confirm that it still does what it should? AFAICT it does... [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 19:46, 29 August 2009 (UTC)
:::::Hmmm, for the most part yes. However, if I preview <code><nowiki>{{WPBiography/sandbox|A-Class=pass}}</nowiki></code> at [[Talk:Milla Jovovich]] it tries to add the page to {{cl|Wikipedia:WikiProject Biography/A-class review/Milla Jovovich}}. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 00:13, 30 August 2009 (UTC)
:::::Ah-ha, you inadvertantly replaced PASS_CAT with SUBPAGE_LINK. Fixed, and does indeed work as intended. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 11:24, 30 August 2009 (UTC)
::::::Lol oops! Anything else? [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 12:48, 30 August 2009 (UTC)
:::::::No, I think we're good here. :) [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 13:38, 30 August 2009 (UTC)
=== ...and for Peer Review ===
For the same reasons I've added the same feature to {{tl|WPBannerMeta/hooks/peerreview/sandbox}}; again this will need someone to check over it, but it appears to work OK. Incidentally, this would be required for {{tl|Comicsproj}} if anyone is still working on converting it. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 18:37, 29 August 2009 (UTC)
:{{twomanrule}} I made similar changes to the logic in that one. Do they work? [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 13:45, 30 August 2009 (UTC)
::No, the last check isn't adding to INVALID_CAT if the parameter is used and a review subpage exists. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 14:13, 30 August 2009 (UTC)
:::''Oh'', I see what the point of that check is; I thought it was redundant at first, then went barking up the wrong tree (and left in some triple logical negation, which didn't help!). Fixed? [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 15:36, 30 August 2009 (UTC)
::::No. You fixed the last problem, but now it's not adding to INVALID_CAT if the parameter ''is'' used and the review subpage ''doesn't'' exist. <small>(Just noticed I said "is" when I meant "isn't" in my last comment. Sorry if that caused any confusion!)</small> [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 16:18, 30 August 2009 (UTC)
Just to clarify how the checks are supposed to work in case I've muddied the waters:
*If {{para|peer review|yes}} and review page exists, add to CAT
*If {{para|old peer review|yes}} and review page exists, add to OLD_CAT
*If {{para|peer review}} or {{para|old peer review}} are unused (or set to "no" etc.) and review page exists, add to INVALID_CAT
*If {{para|peer review|yes}} or {{para|old peer review|yes}} and review page does not exist, add to INVALID_CAT
-- [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 16:22, 30 August 2009 (UTC)
:Hehe, you made me break one check to fix another! Nm, we can do that easily enough: xor is my favourite logical statement, after all <tt>:D</tt><small> Yay! First smiley after coming back!</small> How does that look? [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 16:40, 30 August 2009 (UTC)
::Argh, now I'm not getting INVALID_CAT at all! ;) [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 16:59, 30 August 2009 (UTC)
:::Where are you testing these? It's rather lazy of me to expect you to do all my debugging <tt>:D</tt> [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 17:37, 30 August 2009 (UTC)
::::{{tl|WPBiography/sandbox}} is rigged up with the sandboxed meta code. I don't have any tests saved anywhere. Typically I test the banner on a page like [[Talk:qhekwqjehj]] by previewing without saving, and on [[Talk:Jada Pinkett Smith]] for an example of an article with a peer review. :) [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 18:18, 30 August 2009 (UTC)
:::::Fixed I believe (just a missing |). However it might be preferable to use CAT and OLD_CAT regardless of whether INVALID_CAT is used. For example, it is quite possible that the {{para|peer review}} parameter is to the template before creating the subpage for it. Due to the nature of categorising pages by template it would then be necessary to make another edit to the talk page before the category was updated. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 10:14, 2 September 2009 (UTC)
::::::I've just done a quick test; it's currently working in the manner you suggest, I'm not sure if that was intentional or not. It's possibly a good idea though, I was just going by how these things are currently coded elsewhere. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 10:36, 2 September 2009 (UTC)
:::::::Okay, shall I do the same thing with the A-class hook then and keep it consistent? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 11:06, 2 September 2009 (UTC)
::::::::Sure, why not. :) [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 11:11, 2 September 2009 (UTC)
:::::::::Could you have a final check of these two sandboxes again please and then I'll implement them. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 11:51, 2 September 2009 (UTC)
::::::::::Both of them are fine. :) [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 13:03, 2 September 2009 (UTC)
:::::::::::{{done|Both implemented}} — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 13:47, 2 September 2009 (UTC)
==== More thoughts on peer review ====
May as well post these here while we're on the subject. :)
*Not that I mind as long as it works, but why is the review subpage defined as <code><nowiki>{{{LINK}}}/{{SUBJECTPAGENAME:{{#if:{{{title|}}}|{{{title}}}|{{FULLPAGENAME}}}}}}</nowiki></code> as opposed to <code><nowiki>{{{LINK}}}/{{#if:{{{title|}}}|{{{title}}}|{{{PAGENAME}}}}}</nowiki></code>
*Would it be better to use [[:File:Searchtool.svg]] as the default icon? I'm thinking it would be more visually consistant with [[:File:Bclass-checklist.svg]]. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 13:03, 2 September 2009 (UTC)
:*I believe that these equalities always hold so it makes little difference. It's only because of a quirk that we need it at all.
:*:<code><nowiki>{{SUBJECTPAGENAME}} = {{SUBJECTPAGENAME:{{PAGENAME}}}} = {{SUBJECTPAGENAME:{{FULLPAGENAME}}}}</nowiki></code>
:*No strong opinion. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 13:47, 2 September 2009 (UTC)
== Default image sizes ==
Hi - Are the default image sizes 40px & 80px now? What are the default sizes for the TF link images? Please update the doc page under simple options and task forces, if the values have changed. Thanks --[[User:Funandtrvl|Funandtrvl]] ([[User talk:Funandtrvl|talk]]) 06:05, 9 September 2009 (UTC)
:I've done it (but why didn't you just fix it?). The taskforce picture still defaults to 30. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 10:34, 9 September 2009 (UTC)
| |||