Content deleted Content added
MiszaBot II (talk | contribs) m Archiving 2 thread(s) from Template talk:WPBannerMeta. |
MiszaBot II (talk | contribs) m Archiving 2 thread(s) from Template talk:WPBannerMeta. |
||
Line 319:
Hi - Are the default image sizes 40px & 80px now? What are the default sizes for the TF link images? Please update the doc page under simple options and task forces, if the values have changed. Thanks --[[User:Funandtrvl|Funandtrvl]] ([[User talk:Funandtrvl|talk]]) 06:05, 9 September 2009 (UTC)
:I've done it (but why didn't you just fix it?). The taskforce picture still defaults to 30. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 10:34, 9 September 2009 (UTC)
== Support for priority ==
For projects using "priority" instead of "importance" it is necessary to set {{para|IMPORTANCE_SCALE_NAME|priority}} in {{tl|WPBannerMeta/hooks/priorityscale}} to ensure that categories are named correctly. However, if the project uses task forces with priority ratings, the categories appear to use "importance" regardless. As far as I can tell, this is because neither {{tl|WPBannerMeta/core}} or {{tl|WPBannerMeta/hooks/taskforces/core}} have an option to set {{para|IMPN}} when transcluding {{tl|WPBannerMeta/taskforce}}. Assuming I'm right, can the necessary parameters be added? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 01:50, 29 August 2009 (UTC)
:OK, I've run a quick test by adding {{para|IMPN|{{{IMPORTANCE_SCALE_NAME{{!}}}}}}} to {{tl|WPBannerMeta/core/sandbox}} and {{para|IMPORTANCE_SCALE_NAME|{{{IMPORTANCE_SCALE_NAME{{!}}}}}}} to {{tl|WPBannerMeta/sandbox}}. It seems fairly straightforward and has the desired effect. Can this change be implemented? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 14:33, 29 August 2009 (UTC)
::The Template:WPBannerMeta/hooks/taskforces should have a IMPORTANCE_SCALE_NAME option but it doesn't. That needs fixing. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 14:52, 29 August 2009 (UTC)
I've been tinkering in the sandbox and have made all the changes necessary (that I can see) to fix this issue and (assuming there are no objections) implement my request below. Can someone please review the changes I have made at the following templates:
*{{tl|WPBannerMeta/taskforce/sandbox}}
*{{tl|WPBannerMeta/core/sandbox}}
*{{tl|WPBannerMeta/sandbox}}
*{{tl|WPBannerMeta/hooks/taskforces/core/sandbox}}
*{{tl|WPBannerMeta/hooks/taskforces/sandbox}}
As an aside, can anyone tell me why {{tl|WPBannerMeta}} supports ten task forces when {{tl|WPBannerMeta/core}} only defines five? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 19:57, 29 August 2009 (UTC)
:What's with the {{para|TF_1_HOOK_CAT}} parameters??
:WRT your last point, ask Martin; he added them IIRC. Something to do with /templatepage? [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 20:57, 29 August 2009 (UTC)
::See below for {{para|HOOK_CAT}}. ;) FWIW I think it would be a good move to increase the number of task forces in the main banner code to ten. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 07:30, 30 August 2009 (UTC)
:::Then I would use the format {{para|HOOK_TF_1_CAT}}, to clarify that it's a hook. Although I'm still not 100% sure that it's necessary... [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 09:28, 30 August 2009 (UTC)
::::I merely named it after the existing TF parameters; I don't know about greater clarity, but I'm unconcerned about how they are named. This is more about usefulness rather than necessity, though I do think it allows for a better way of doing things. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 10:05, 30 August 2009 (UTC)
Yes TF6-10 were added for the convenience of those constructing banner templates. They will give the category prompts on /templatepage but will not operate in any other way. I would support increasing the number of taskforces supported by the main banner to 10. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 09:23, 2 September 2009 (UTC)
:This discussion is getting derailed somewhat (largely my own fault). Can the required fix for IMPORTANCE_SCALE_NAME be implemented? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 10:28, 2 September 2009 (UTC)
::Yes, you've been mixing two different requests I think. Supporting a custom IMPN in the main banner would be quite a big change, but would have with several advantages. I guess one of the disadvantages is that it could be seen as encouraging each project to have a different name for their importance scale, which is anti-standardisation. Overall though I think this might be a good idea. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 10:53, 2 September 2009 (UTC)
For information, apart from all the biography workgroups, the following projects use "priority". — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 11:00, 2 September 2009 (UTC)
* British royalty
* Economics
* Kingdom of Naples
* mathematics
* Sheffield
* Sicily
* Spooks
* Square Enix
* strategy game
* taxation
* WikiProject Business
:I'm not entirely sure I follow. It's necessary in the main banner so that the task forces can use the custom name (i.e. priority), but it doesn't do anything else. Defining the parameter in the main banner ''without'' using task forces doesn't do anything, you still need the priority hook for that. I don't share your anti-standardisation concerns, though I don't see how this change would increase them. However, if necessary I assume it would be possible to recode the meta so that priority was the only valid alternative to importance? I'm certainly not aware of any projects using anything else. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 11:10, 2 September 2009 (UTC)
::Currently the projects above have to hook [[Template:WPBannerMeta/hooks/priorityscale]] onto HOOK_ASSESS or similar in order to get their priority scale. Adding an IMPN option would allow this to be implemented more easily by just using something like:
<pre>|importance={{{priority|}}}
|IMPN=priority</pre>
::Now, as for taskforces, out of the list above only Business has any and that one doesn't use priority, so it wouldn't affect any of them. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 14:04, 2 September 2009 (UTC)
:::I'm still not entirely with you there. So far as I can see, you would still need to define {{para|importance}} and {{para|IMPORTANCE_SCALE_NAME}} in {{tl|WPBannerMeta/hooks/priorityscale}}, so the extra parameter in the main banner would offer no advantage in that respect. Likewise, if a banner ''didn't'' use the priorityscale hook ''or'' task forces, then the parameter wouldn't do anything.
:::Granted, this isn't a problem that affects any existing uses of the meta. However, is it not logical that if a banner is set to use priority as opposed to importance, then you need some way of passing that onto the task forces? In that respect I'm still inclined to view this as a bug. As with my other recent requests here, this is something that will facilitate the conversion of {{tl|WPBiography}}. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 22:54, 2 September 2009 (UTC)
::::Sorry for my lack of clarity. What I'm saying is this. If we added the IMPN option to the main template, then the projects listed above would no longer need to use the /priorityscale hook as it could be done by the main template. And yes, I guess it makes sense for taskforces to use the same scale-name as their parent project by default. So I suppose I am supporting this proposal. What do others think? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:45, 3 September 2009 (UTC)
:::::OK, now I'm with you. :) Is that basically all the hook does then? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 12:50, 3 September 2009 (UTC)
::::::Yes, /qualityscale just calls [[Template:WPBannerMeta/importancescale]] with a custom value of IMPN. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 13:21, 3 September 2009 (UTC)
Given that there are exactly two importancescale terms being used, {{para|importance}} and {{para|priority}}, do you think we should admit defeat and build the "priority" version into the main banner? That is, passing the {{para|priority}} parameter instead of the {{para|importance}} parameter makes that switch automagically? It would probably be easier to clean up this issue if we did that. [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 14:15, 3 September 2009 (UTC)
:That's an interesting idea, and would avoid the need to define an extra parameter. The only consideration is that maths use Priority with a capital P, but that could be changed if they ever convert ... So I suppose we can use some code like the following on [[Template:WPBannerMeta]]? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 15:27, 3 September 2009 (UTC)
<pre>
|importance={{{importance|{{{priority|¬}}}}}}
|IMPN={{#if:{{{importance|}}}|importance|priority}}
</pre>
===Code review===
{{two-man-rule}} Would anyone care to check my changes to the following pages?
*[[Template:WPBannerMeta/sandbox]]
*[[Template:WPBannerMeta/core/sandbox]]
There is also the /templatepage stuff:
*[[Template:WPBannerMeta/templatepage]]
*[[Template:WPBannerMeta/templatepage/checkcat]]
*[[Template:WPBannerMeta/templatepage/deduceimportance]]
:(This stuff isn't working fully yet. It will correctly deduce the priority, but it won't use {{tl|cat priority}} instead of {{tl|cat importance}} yet. Hmm.)
There are some examples:
*[[Template:WikiProject Spooks/sandbox]] (with a fake taskforce added)
*Test case on [[Template talk:WikiProject Spooks/sandbox]] showing nested priority rating
*To check the category prompts, there's [[Template:WikiProject New York/sandbox]]
Thanks, — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 13:28, 4 September 2009 (UTC)
:I think the change in layout on /core/sandbox was necessary, but it does make for a very messy diff. Looks ok though. I don't think it's a good idea to expose {{para|IMPN}} on WPBM, though: it destroys our Zero <s>One</s> Two Inifinity rule on scale names, isn't necessary AFAICT given that there are only two scales in use, and is going to make life even more difficult on /templatepage... Is there a reason to expose it?
:I'm not surprised the /templatepage stuff isn't working; the substitution stuff ''desperately'' needs string functions. I once tried adding optional subst to {{tlx|str sub}}, it was a complete disaster <tt>:D</tt> [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 09:34, 7 September 2009 (UTC)
::I think it is necessary to expose it. (You'll notice it was added as an after-thought.) The main reason for supporting this is to aid the conversion of WPBiography, and they use priority for their taskforces but do not have an "overall" priority scale. The only way to do this (I think) is to pass IMPN but not to pass ''importance'' or ''priority''. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 09:44, 7 September 2009 (UTC)
:::You could get around that issue by only using the hooks to add taskforces for WPBiography. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 10:06, 7 September 2009 (UTC)
::::Or apply the same switching logic independently to each tf, and have WPBio use {{para|tf 1 priority}}, etc. I don't know if there are any banners (presumably not now that there are so few left) that have mixed importance/priority scales, but we could support them if we did it that way. [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 11:46, 7 September 2009 (UTC)
:::::Isn't that overcomplication? It might be a good method if there were likely to be any uses of mixed importance/priority. I don't think I've ever come across this. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:14, 7 September 2009 (UTC)
::::::The only banner I've seen with both is [[Template:Christianmusic]] -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 12:25, 7 September 2009 (UTC)
::::Could do. A bit of a shame that the largest potential user of this feature won't be able to use it though :( — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:14, 7 September 2009 (UTC)
To help us towards closure of this little discussion, my thoughts are as follows:
*I don't really want to add separate importance/priority parameters for each taskforce. This would add to the complexity with very little benefit. It's reasonable that a project that wants mixed ratings, e.g. Christian music, should need to use a hook.
*I accept that this will then be inconsistent with the use of the main importance/priority parameters.
*I personally can't see the harm in allowing IMPN to be set from project banners, but if you two think that's a "bad idea" then I don't mind disabling it.
*WPBiography taskforces are now all hooked, so this issue won't affect them at all.
— Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 08:11, 8 September 2009 (UTC)
:{{done|All done}}. I even remembered to remove /sandbox from the code this time :) — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 22:10, 8 September 2009 (UTC)
::Well you're certainly doing [[rev:55991|better than me]] <tt>:D</tt> Looks nice... [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 22:17, 9 September 2009 (UTC)
:::Aww, is that the equivalent of being rolled back? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:23, 10 September 2009 (UTC)
::::Yeah, essentially; Brion said to work it up in a branch so any creases could be ironed out. Essentially I broke the login form on translatewiki for 12 hours; people had to log in using the API because the regular login form just looped the cookie check ad infinitum... <tt>:S</tt> [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 08:59, 10 September 2009 (UTC)
== SMALL_TEXT? ==
Any thoughts on adding a {{para|SMALL_TEXT}} parameter to the main banner? It might help encourage projects using {{para|MAIN_TEXT}} to add more concise wording for small banners, and for those that already do it would eliminate the need to use parser functions in {{para|MAIN_TEXT}}. Just an idea. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 14:33, 11 September 2009 (UTC)
:Last discussed [[Template_talk:WPBannerMeta/Archive_4#.7B.7B.7Bsmall.7D.7D.7D_and_template_length|here]]. If this option was used widely, then it would be a good idea. But it's hardly used at all I think. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 18:03, 11 September 2009 (UTC)
::A whopping 0.02% of banners, in fact. I hate the small parameter, and the small tmbox style in general (as opposed to the small ambox, which I think is adorably cute <tt>:D</tt>). I remember having a cleanout of that category once, and found a lot of 'small' banners ''also'' inside shells; so many that I tweaked the tmbox CSS to ensure that the nesting automagic overrides the small parameter. I just ran a Toolserver DB query: 141 of those 513 pages also transclude {{tlx|WPBS}}. So some of those 'small' banners could actually not be small at all... [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 21:15, 11 September 2009 (UTC)
Listy. Sorry for the text explosion, can't think of a better place to put it... [[User:Happy-melon|<span style="color:forestgreen">'''Happy'''</span>]]‑[[User talk:Happy-melon|<span style="color:darkorange">'''melon'''</span>]] 21:46, 11 September 2009 (UTC)
{{hidden|Pages which contain a WPBM banner with {{para|small|yes}} ''and'' {{tlx|WPBS}}|2=
{{columns-list|5|
* [[Talk:Asteroid]]
* [[Talk:AIDS]]
* [[Talk:Calvin and Hobbes]]
* [[Talk:Computational complexity theory]]
* [[Talk:Milgram experiment]]
* [[Talk:Manga]]
* [[Talk:Plato]]
* [[Talk:Submarine]]
* [[Talk:The Adventures of Tintin]]
* [[Talk:United States Constitution]]
* [[Talk:United States Congress]]
* [[Talk:Greek mythology]]
* [[Talk:Extrasolar planet]]
* [[Talk:Philip K. Dick]]
* [[Talk:Autism]]
* [[Talk:Swastika]]
* [[Talk:New York Stock Exchange]]
* [[Talk:Yosemite National Park]]
* [[Talk:Parliament of the United Kingdom]]
* [[Talk:The Hitchhiker's Guide to the Galaxy]]
* [[Talk:Gustav Mahler]]
* [[Talk:Douglas Adams]]
* [[Talk:Cyndi Lauper]]
* [[Talk:Toyotomi Hideyoshi]]
* [[Talk:Roy Orbison]]
* [[Talk:Prisoner's dilemma]]
* [[Talk:Anne of Great Britain]]
* [[Talk:Igor Stravinsky]]
* [[Talk:Action potential]]
* [[Talk:Supreme Court of the United States]]
* [[Talk:Rosa Parks]]
* [[Talk:Chuck Palahniuk]]
* [[Talk:William Thomson, 1st Baron Kelvin]]
* [[Talk:Latin]]
* [[Talk:Sabbatai Zevi]]
* [[Talk:Han Dynasty]]
* [[Talk:The Smashing Pumpkins]]
* [[Talk:Emu]]
* [[Talk:Srinivasa Ramanujan]]
* [[Talk:Futurama]]
* [[Talk:Metal umlaut]]
* [[Talk:Flag of the Republic of China]]
* [[Talk:Mount Vesuvius]]
* [[Talk:Romanian language]]
* [[Talk:Dim sum]]
* [[Talk:Debit card]]
* [[Talk:Lego]]
* [[Talk:Shanghai]]
* [[Talk:Singapore]]
* [[Talk:The Economist]]
* [[Talk:Comfort women]]
* [[Talk:The Wonderful Wizard of Oz]]
* [[Talk:Treaty of Nanking]]
* [[Talk:Treaties of Tianjin]]
* [[Talk:Not the Nine O'Clock News]]
* [[Talk:Charles Ives]]
* [[Talk:First Opium War]]
* [[Talk:United States House of Representatives]]
* [[Talk:Murder of James Bulger]]
* [[Talk:Madeleine L'Engle]]
* [[Talk:Eureka Stockade]]
* [[Talk:Search engine optimization]]
* [[Talk:Space Race]]
* [[Talk:Second Opium War]]
* [[Talk:Durand Line]]
* [[Talk:Hawker Hurricane]]
* [[Talk:Cirque du Soleil]]
* [[Talk:Humpback Whale]]
* [[Talk:Wernher von Braun]]
* [[Talk:King Crimson]]
* [[Talk:Ogham]]
* [[Talk:List of Stargate SG-1 episodes]]
* [[Talk:England expects that every man will do his duty]]
* [[Talk:Wheat]]
* [[Talk:Exploding whale]]
* [[Talk:California Gold Rush]]
* [[Talk:Second Congo War]]
* [[Talk:Cyclone Tracy]]
* [[Talk:Rwandan Genocide]]
* [[Talk:William Gibson]]
* [[Talk:Mark Webber]]
* [[Talk:Lost (TV series)]]
* [[Talk:Mass Rapid Transit (Singapore)]]
* [[Talk:Indian Railways]]
* [[Talk:The Giver]]
* [[Talk:Faye Wong]]
* [[Talk:Edvard Munch]]
* [[Talk:Stuttering]]
* [[Talk:Samuel Hahnemann]]
* [[Talk:House (TV series)]]
* [[Talk:Comet Shoemaker-Levy 9]]
* [[Talk:John Fahey (musician)]]
* [[Talk:Waterfall Gully, South Australia]]
* [[Talk:Altrincham]]
* [[Talk:The West Wing]]
* [[Talk:History of Bengal]]
* [[Talk:North by North Quahog]]
* [[Talk:Ima Hogg]]
* [[Talk:Alexander the Great]]
* [[Talk:Rabindranath Tagore]]
* [[Template:WikiProject Food and drink]]
* [[Talk:Liberation of Goa]]
* [[Talk:Manuel da Assumpção]]
* [[Talk:Jimmy Wales]]
* [[Talk:Salwar kameez]]
* [[Talk:Hindkowans]]
* [[Talk:Hamlet chicken processing plant fire]]
* [[Talk:Bigfoot]]
* [[Talk:Cheese]]
* [[Talk:Confederate government of Kentucky]]
* [[Talk:Government of the Han Dynasty]]
* [[Talk:Tamil language]]
* [[Talk:Ancient Egyptian literature]]
* [[Talk:History of the Jews in Northern Ireland]]
* [[Template:WikiProject Canada/testcases]]
* [[Talk:Sitka Naval Operating Base and U.S. Army Coastal Defenses]]
* [[Talk:Myojo 56 building fire]]
* [[Talk:Battle of Tiger Hill]]
* [[Template:WPBiography/testcases]]
* [[Talk:List of Golden Gate Transit routes]]
* [[Talk:Cat]]
* [[Talk:Julius Caesar]]
* [[Wikipedia:WikiProject Food and drink/Banners]]
* [[Template:WikiProject Food and drink/doc]]
* [[Talk:Henry VIII of England]]
* [[User talk:SMcCandlish/Banner]]
* [[Talk:United States Senate]]
* [[Talk:Same-sex marriage in Spain]]
* [[Talk:Go (game)]]
* [[Talk:Jesuit Missions of the Chiquitos]]
* [[Template:Maths rating/testcases]]
* [[Talk:Usher (entertainer)]]
* [[Wikipedia talk:WikiProject Napoleonic Fiction/Template:projectbanner/testcases]]
* [[Wikipedia talk:WikiProject Napoleonic Fiction/Template:projectbanner/test]]
* [[Talk:Fuck]]
* [[Talk:Economy of the Han Dynasty]]
* [[Template talk:WikiProject Japan/testcases]]
* [[Template talk:WikiProject Japan/usecases]]
* [[Template:WikiProject Adoption, fostering, orphan care and displacement]]
* [[Template:WikiProject Adoption, fostering, orphan care and displacement/doc]]
* [[Talk:List of Stargate Universe episodes]]
}}
}}
Ah well. I'll get my coat... :) [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 00:08, 12 September 2009 (UTC)
:Quite a few on that list have a {{tl|FAOL}} or {{tl|Talk Spoken Wikipedia}} with the <tt>small=yes</tt> parameter outside of the {{tl|WPBS}} though. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 09:42, 12 September 2009 (UTC)
| |||