MediaWiki talk:Common.js/Archive 17: Difference between revisions

Revision as of 08:25, 14 August 2009

Revision as of 08:19, 16 October 2009

Line 8:

:: Well, since it's a brand name, how about adding 'search', e.g.: Yahoo! search, 'Bing search' with all of them to neutralize the perception. --[[User:MMuzammils|'''I'''ncident'''F'''lux]] ^{[ [[User_talk:MMuzammils|TalkBack ]]|[[Special:Contributions/MMuzammils| Contributions]] ]} 17:18, 4 July 2009 (UTC)

== Mobile site redirecting ==

Any chance someone will try discussing these changes first? They say there's a community around here that usually likes to, at the very minimum, be warned about changes to the global JavaScript. (And it probably doesn't help that we redirected all traffic to the mobile site only to have it start serving [[502 error|502]]s. Pretty nasty thing to do.) --[[User:MZMcBride|MZMcBride]] ([[User talk:MZMcBride|talk]]) 03:51, 7 June 2009 (UTC)

: There better be. It is incredibly aggravating to be redirected to a less-functional website when my phone has a browser that is designed to view the web as you would normally. If I type "en.wikipedia.org" I want "en.wikipedia.org" not a crippled website that I didn't ask for. <span style='font-family:monospace,tahoma;font-size:90%;'>~ [[User:Ameliorate!|<span style='color:green;'>Ameliorate</span>]][[User talk:Ameliorate!|!]]</span> 06:23, 12 June 2009 (UTC)

:: Simply click the "View this page on regular Wikipedia" link and you will never be bothered by a mobile redirect again. These changes were discussed at length on IRC with most of Wikipedia's technical community in attendance. The mobile site is not meant for power users, as both of you obviously are, but you make up an extremely small segment of the community. Don't get me wrong, its an extremely *important* and *vital* part of the community and I'm not downplaying that. But when 99% of the users coming to this site prefer a simplified interface and have requested it roundly, we need to make sure those users are supported. If you have any suggestions on how to work with both types of users, I'd love to hear about it. Also, if you could suggest a place where you'd like to be notified of any future changes, let me know where you'd like me to report in the future. --[[User:Hcatlin|Hampton]] ([[User talk:Hcatlin|talk]]) 15:45, 26 June 2009 (UTC)

::: Also, I'll point you to this [[Wikipedia:Village_pump_(technical)#portable_devices|Village Pump Thread]] ... and you start to see why we started a redirect. --[[User:Hcatlin|Hampton]] ([[User talk:Hcatlin|talk]]) 15:45, 26 June 2009 (UTC)

::::At the very least, dropping a notice on the talkpage here with links to relevant discussions (or noting that such discussions took place on IRC) would be nice, since some of us who watch this page do not, in fact, watch VPT or the IRC channels (shock! =O ). <span style=white-space:nowrap>「[[User:Dinoguy1000|<span style=color:#00f>ダイノ<span style=color:#080>ガイ]][[Special:Contributions/Dinoguy1000|<span style=color:#F90>千？！]]」^{[[Help:JP|?]] · [[User talk:Dinoguy1000|<small style=font-weight:normal>Talk⇒Dinoguy1000]]}</span></span> 11:00, 27 June 2009 (UTC)

The Mobile Redirect code cannot go into an import because we need it to load before all of the other assets on the page. If you do an import, the page renders on the mobile device and THEN redirects which is angering a lot of users. Until the sysadmins get a chance to implement the redirect outside of Javascript, Brion and I have agreed this is best. --[[User:Hcatlin|Hampton]] ([[User talk:Hcatlin|talk]]) 21:19, 30 July 2009 (UTC)

:Thank you for leaving a note on the talk page. :-) --[[User:MZMcBride|MZMcBride]] ([[User talk:MZMcBride|talk]]) 22:23, 30 July 2009 (UTC)

:I echo MZMcBride's thanks, I greatly appreciate you taking the time to leave an explanation here (I can't speak for anyone else who watches this page, but I'm sure they do, too). =) <span style=white-space:nowrap>「[[User:Dinoguy1000|<span style=color:#00f>ダイノ<span style=color:#080>ガイ]][[Special:Contributions/Dinoguy1000|<span style=color:#F90>千？！]]」^{[[Help:IJP|?]] · [[User talk:Dinoguy1000#top|Talk⇒Dinoguy1000]]}</span></span> 22:29, 30 July 2009 (UTC)

== More functional breakdown ==

Following the 2008 discussion [[MediaWiki talk:Common.js/Archive 14#Functional breakdown by size|Functional breakdown by size]] when <tt>edits.js</tt> etc. were created, I'm wondering if it's possible to move some other code into separate modules. Particularly, ''"IPv6 AAAA connectivity testing"'' code which is used about 1 out of 100 page views, and ''"Mobile browser helper link"'' which is used, I would estimate, by less than 1% of visitors. — [[user:Alex Smotrov|AlexSm]] 15:46, 24 June 2009 (UTC)

:Yeah, I don't see why not. I personally think Common.js should simply be a list of imports, that can be enabled or disabled as required, but that could just be me. For the IPv6, I presume you are suggesting that the contents of the main conditional simply be moved to another page and replaced by the import? If no one objects here in the near future, I'll go ahead and move that to (following the existing naming scheme, which I like) [[MediaWiki:Common.js/IPv6.js]]. I'd possibly suggest talking to the maintainers of the mobile redirect, as I know they are actively developing that based on MediaWiki changes and changes to the mobile site. [[User:Ale_jrb|<font color="green">A</font><small><font color="green">le_Jrb</font>]]</small>^{[[User_talk:Ale_jrb|<font color="blue">talk</font>]]} 22:09, 24 June 2009 (UTC)

::I agree about the IPv6 code, and the mobile device code should also be moved to a subpage. Moving ''all'' the scripts to subpages is probably not a good idea--some scripts are simply needed too often to justify splitting them off. —[[User:Remember the dot|Remember the dot]] ^{([[User talk:Remember the dot|talk]])} 05:37, 26 June 2009 (UTC)

::I've moved the little-used mobile redirect code to [[MediaWiki:Common.js/mobile.js]]. Since actual redirection for mobile devices is currently disabled, now seemed like a particularly good time to make the switch. Question: does the IPv6 tester even work any more? The [http://ipv6and4.labs.wikimedia.org/stats.html page] it links to is totally blank. —[[User:Remember the dot|Remember the dot]] ^{([[User talk:Remember the dot|talk]])} 03:16, 30 June 2009 (UTC)

Subpaging makes duplicating the code on other projects more tedious, it makes watching changes more tedious, and it only works for recent versions of MediaWiki (1.14 or later, I believe). I'm not saying we shouldn't subpage, but there are certainly reasons not to.

I'll try to poke someone about the IPv6 thing. --[[User:MZMcBride|MZMcBride]] ([[User talk:MZMcBride|talk]]) 02:50, 6 July 2009 (UTC)

:To me, the problem is that we use way too much JavaScript. [[MediaWiki:Common.js/search.js|The Special:Search code]], the IPv6 test, and the main page fixes should be implemented in PHP and not in JavaScript at all. Also, JavaScript commonly used across many projects should be made part of MediaWiki's standard JavaScript features. While the Squid servers effectively prevent a PHP solution for the mobile devices code, if we eliminated all the other extraneous JavaScript then our site JavaScript as a whole wouldn't be so bad. —[[User:Remember the dot|Remember the dot]] ^{([[User talk:Remember the dot|talk]])} 02:04, 9 July 2009 (UTC)

::I moved the IPv6 code to another page, as there seemed to be no big issues with doing so. Common.js now stands at around 15Kb. [[User:Ale_jrb|<font color="green">A</font><small><font color="green">le_Jrb</font>]]</small>^{[[User_talk:Ale_jrb|<font color="blue">talk</font>]]} 09:44, 9 July 2009 (UTC)

:::The IPv6 code was broken for Vector and other skins not compatible with Monobook. I have [http://en.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.js%2FIPv6.js&diff=301855502&oldid=301160829 repaired this]. Mark is currently looking as to why the [http://ipv6and4.labs.wikimedia.org/ statistics pages] are not OK. Instant update, disk space on the server apparently ran out. I'll keep an eye out for when it gets fixed, and will try to leave a note here after it's repaired again. —[[User:TheDJ|Th<span style="color: green">e</span>DJ]] ([[User talk:TheDJ|talk]] • [[Special:Contributions/TheDJ|contribs]]) 13:34, 13 July 2009 (UTC)

::::http://ipv6and4.labs.wikimedia.org/stats.html appears to be working again. --[[User:MZMcBride|MZMcBride]] ([[User talk:MZMcBride|talk]]) 19:07, 15 July 2009 (UTC)