Module talk:Convert: Difference between revisions

Revision as of 15:48, 19 September 2013

Revision as of 15:49, 19 September 2013

Line 77:

* <nowiki>{{Convert/sandboxlua|5|km|mi|warnings=true}}</nowiki> &rarr; {{Convert/sandboxlua|5|km|mi|warnings=true}}

* <nowiki>{{Convert/sandboxlua|5|km|mi|warnings=false}}</nowiki> &rarr; {{Convert/sandboxlua|5|km|mi|warnings=false}}

* <nowiki>{{Convert/sandboxlua|5|km|mi|foo=true}}</nowiki> &rarr; {{Convert/sandboxlua|5|km|mi|foo=true}}

I find this code confusing, because the parameter name "warnings" is used (checked) twice for apparently opposing values:. The logic may be right, but clear it is not.

I find this code confusing, because the parameter name "warnings" is used (checked) twice for apparently opposing values:

<syntaxhighlight lang="lua">

local function add_warning(parms, mcode, text)

Line 88:

end

end

</syntaxhighlight>

-[[User:DePiep|DePiep]] ([[User talk:DePiep|talk]]) 15:49, 19 September 2013 (UTC)

-~~~~