Module talk:Convert: Difference between revisions

Content deleted Content added
Line 114:
The problem is that the parms table contains what the user entered, and because the convert contains "warnings=true", the module sets <code>parms.warnings = true</code>. That is then appended, and Lua helpfully converts the Boolean "true" to the string "true". I'll think about making that more robust. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 06:29, 20 September 2013 (UTC)
:Don't explain it, code should be self-explaining. Just don't use the same name twice. It is bad programming practice. -[[User:DePiep|DePiep]] ([[User talk:DePiep|talk]]) 14:07, 20 September 2013 (UTC)
==boolean==
The function boolean is wrong. It should return either "false" or "true", never nil. nil is not a boolean value. The input parameter called "text" can be a numerical value too, so is named wrong. No need to bend meanings. -[[User:DePiep|DePiep]] ([[User talk:DePiep|talk]]) 14:10, 20 September 2013 (UTC)
 
== Before going live ==