Module talk:Redirect: Difference between revisions

Content deleted Content added
Jackmcbarn (talk | contribs)
Line 68:
::{{ping|Mr. Stradivarius}} [https://en.wikipedia.org/w/index.php?title=Module:Redirect/sandbox&diff=608926039&oldid=608825255 This change] will re-break this if it goes live. See the last test in [[Module talk:Redirect/sandbox testcases]]. (Unrelated: Why does this module have a /testcases and a /sandbox testcases?) [[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 16:10, 17 May 2014 (UTC)
:::{{ping|Jackmcbarn}} I've moved the sandbox test cases to [[Module:Redirect/testcases]]. I've also switched to doing the canonicalisation purely with title objects. This makes things easier coding-wise, but it does mean that we have one more expensive function call for each call to the module. Is this likely to cause problems anywhere? — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr. Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪ talk ♪]]</sup> 04:55, 18 May 2014 (UTC)
::::{{ping|Mr. Stradivarius}} I don't think that will cause problems. [[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 17:30, 18 May 2014 (UTC)