Wikipedia talk:WikiProject Articles for creation/Helper script/Archive 2: Difference between revisions

Revision as of 10:10, 10 November 2015

Revision as of 06:10, 20 November 2015

Line 382:

Preface, I'm not a coder, so if this would even be remotely hard to do, I'd say it's not worth it. But in the same way that the date and month pops up when you put a year in for the biography field, it'd also be nice if you put in a certain year of birth and it automatically marks the one dropdown menu as Dead. I mean, we could play it safe. Say if you enter 1870 or earlier it automatically marks the dropdown menu as dead. Like I said, this would maybe save five seconds per instance, but if it's something that will only take a couple minutes to code, that'd be nice. [[User:Sulfurboy|Sulfurboy]] ([[User talk:Sulfurboy|talk]]) 04:33, 22 July 2015 (UTC)

:See [[Wikipedia_talk:WikiProject_Articles_for_creation/2015_2#Persondata_deprecated|this discussion]]. I think it's all gonna be useless anyway. [[User:FoCuSandLeArN|FoCuSandLeArN]] ([[User talk:FoCuSandLeArN|talk]]) 00:02, 24 July 2015 (UTC)

== Comments lost when changing reason dropdown ==

Hi there! I recently declined an article, but I initially clicked on the wrong reason in the dropdown. I didn't notice, and wrote up a fairly long paragraph for my decline comment. When I realized the dropdown was wrong, I changed it -- and my comment disappeared.

From a usability standpoint, there's no reason to clear an existing text area when changing the dropdown. From a technical standpoint, I haven't looked yet to see what the script does if you change dropdown reasons. If it re-creates the text area, that would be the problem. It should check first to see if the text area for the comment exists, and if it does, do not re-create or overwrite it. —[[User:Darkwind|Darkwind]] ([[User talk:Darkwind|talk]]) 07:23, 22 July 2015 (UTC)

:{{u|Darkwind}}, I just located [https://github.com/WPAFC/afch-rewrite/blob/master/src/modules/submissions.js#L1582 the offending function]. The script will [https://github.com/WPAFC/afch-rewrite/blob/master/src/modules/submissions.js#L1717 reset] the HTML of the decline form every time the dropdown is changed. I suspect the reason it does this is that some HTMl manipulations are done on the form every time, and it's easier to just start with a blank state and add elements. I suppose we could add some sort of confirmation dialog when the user changes the dropdown while they have entered text, but I'm not sure if that would interrupt the workflow too much. [[User:APerson|APerson]] ([[User talk:APerson|talk!]]) 00:05, 10 August 2015 (UTC)

::Given that most web forms don't clear when changing one element, I personally would rather have a pop-up "copy your text first" alert than sudden loss of something I may have spent several minutes typing. Alternatively, can the contents be assigned to a variable and then re-inserted into the box after the reset? –[[User:Darkwind|Darkwind]] ([[User talk:Darkwind|talk]]) 01:58, 10 August 2015 (UTC)

::{{Ping|APerson}} Forgot to ping. –[[User:Darkwind|Darkwind]] ([[User talk:Darkwind|talk]]) 01:59, 10 August 2015 (UTC)