MediaWiki talk:Common.js/Archive 21: Difference between revisions

Revision as of 00:52, 10 October 2015

Revision as of 01:01, 10 December 2015

Line 344:

:::::::Yeah, but what if the ''first'' <code>th</code> of the <code>table</code> is inside the ''second'' <code>tr</code>? In [https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&oldid=651403910&action=edit&preview=yes this example] the cells c,d,e and f can't be unhidden. [[User:He7d3r|Helder]] 23:41, 14 March 2015 (UTC)

::::::::I think that was an accidental change, at least I can't figure out anymore why I would have made it. —[[User:TheDJ|Th<span style="color: green">e</span>DJ]] ([[User talk:TheDJ|talk]] • [[Special:Contributions/TheDJ|contribs]]) 08:16, 15 March 2015 (UTC)

== Proposal to add global JavaScript ==

There is an ongoing discussion that watchers of this page may be interested in on [[WP:VP/PR#IRC help channel disclaimer|Proposal to add global JavaScript and add an extra step for new users to get live IRC help]]. — <code class="nowrap">&#123;&#123;U&#124;[[User:Technical 13|Technical 13]]&#125;&#125; ^{([[Special:EmailUser/Technical 13|e]] • [[User talk:Technical 13|t]] • [[Special:Contribs/Technical 13|c]])}</code> 19:33, 28 April 2015 (UTC)

== Remove [[MediaWiki:Common.js/file.js]] ==

{{tracked|T8834}}

Hi (ping [[User:TheDJ|TheDJ]]),

I'd like to know why this script exists? It seems MediaWiki (at least nowadays) provides very similar functionality already.

Here's a screenshot of what [[:File:Example.svg]] looks like. One line providing links by MediaWiki, and another one produced by [[MediaWiki:Common.js/file.js]]: http://i.imgur.com/sU56Czt.png.

If we don't like the labels (e.g. "480px" instead of "480 x 480 pixels") that's something we can work on.

Unless reason to otherwise, I'd like to remove this redundant script as soon as possible. Or at least work it into something that isn't loaded with <code>importScript</code> from [[MediaWiki:Common.js]]. [[User:Krinkle|Krinkle]] ([[User talk:Krinkle|talk]]) 20:11, 3 July 2015 (UTC)

:I agree, it is completely redundant. <code style="font-size:small;white-space:nowrap">-- [[[[User:Edokter|<span style="color:#006">User:Edokter</span>]]]] {&#123;[[User talk:Edokter|<span style="color:#060">talk</span>]]&#125;}</code> 20:44, 3 July 2015 (UTC)

:Removed. Probably just an oversight after the links were implemented in core. In light of this, I'd like to inversigate the possible removal of /edit.js and /watchlist.js as well (or at least move the conditionals to Common.js). <code style="font-size:small;white-space:nowrap">-- [[[[User:Edokter|<span style="color:#006">User:Edokter</span>]]]] {&#123;[[User talk:Edokter|<span style="color:#060">talk</span>]]&#125;}</code> 08:55, 4 July 2015 (UTC)

:btw, this is related to [[phab:T104486]]. Thanks Edokter. <span style="font-variant:small-caps">[[User:John Vandenberg|John Vandenberg]] ^{'''([[User talk:John Vandenberg|chat]])'''}</span> 11:00, 4 July 2015 (UTC)

: I would've preferred to wait to hear from TheDJ, but removing this script seems fine to me. I also agree with re-evaluating all of the other custom JavaScript we have. The less, the better. --[[User:MZMcBride|MZMcBride]] ([[User talk:MZMcBride|talk]]) 13:49, 4 July 2015 (UTC)

::Yup, we simply never got around to removing it after this was implemented in core. —[[User:TheDJ|Th<span style="color: green">e</span>DJ]] ([[User talk:TheDJ|talk]] • [[Special:Contributions/TheDJ|contribs]]) 12:03, 5 July 2015 (UTC)

:::For future reference: this was implemented in [[gerrit:134855]], to fix [[phab:T8834]]. [[User:He7d3r|Helder]] 18:14, 5 July 2015 (UTC)