Wikipedia talk:WikiProject Articles for creation/Helper script/Archive 2: Difference between revisions

Revision as of 14:46, 20 December 2015

Revision as of 17:00, 5 January 2016

Line 424:

See [[Draft:Maria Dakake]], a draft I moved to the draftspace on behalf of the author. When this happens, we add the author username in the {{para|u}} parameter of the {{tl|AFC submission}} template. When using AFCH to mark for G13 speedy, it should first look for that parameter and notify that user and not the page creator (which in this case was me). Cheers <span style="font-family:sans-serif">&mdash; <span style="font-weight:bold">[[User:MusikAnimal|<span style="color:black; font-style:italic">MusikAnimal</span>]] ^{[[User talk:MusikAnimal|<span style="color:green">talk</span>]]}</span></span> 17:13, 19 November 2015 (UTC)

== Script hangs declining or commenting on [[Draft:Daniel Clitnovici]] ==

The AFCH script appears to hang when a reviewer tries to decline [[Draft:Daniel Clitnovici]] or to comment. The subject appears not to meet [[WP:NFOOTY|association football notability guidelines]]. He has not played in a fully professional league. He is an assistant coach, not a manager (head coach), in a fully professional league. If I attempt to decline the draft with that rationale, the decline process hangs. This happens using either Google Chrome or Internet Explorer. (I haven't tried Firefox.) This has happened at least three times with Chrome and once with IE. I also tried Commenting, and the same thing happens. Is there something wrong with the history of the page? I have also posted about this problem at [[WP:VPT|Village pump (technical)]], but then it occurred to me that this is the page for help with the script, and it appears that the script is having a problem with this page. [[User:Robert McClenon|Robert McClenon]] ([[User talk:Robert McClenon|talk]]) 17:59, 3 December 2015 (UTC)

:{{reply to|Robert McClenon}} Looks like there was a missing end brace (<nowiki>}</nowiki>) on an earlier AfC comment at [[Draft:Daniel Clitnovici]]. I've added the missing end brace and successfully added a test comment. [[User:Wikiisawesome|<span style="color:#600">/wia</span>]]&nbsp;[[User talk:Wikiisawesome|<span style="color:#600"><small>/tlk</small></span>]] 18:02, 3 December 2015 (UTC)

::I declined the draft. Is a script coder following this page who can address the bug, in particular, that a missing end brace causes the script to hang? (Also, was the missing end brace due to a bug, or due to reviewer entry error?) [[User:Robert McClenon|Robert McClenon]] ([[User talk:Robert McClenon|talk]]) 18:08, 3 December 2015 (UTC)

:::It looks like the end brace was accidentally removed by the author in [https://en.wikipedia.org/w/index.php?title=Draft%3ADaniel_Clitnovici&type=revision&diff=691923197&oldid=691922062 this edit], when they moved their own comments above the existing AfC comments. So if I'm looking at it correctly, the initial error was '''not''' caused by the AfC script. Of course, there is still the problematic consequence that removing an end brace causes the AfC script to malfunction. [[User:Wikiisawesome|<span style="color:#600">/wia</span>]]&nbsp;[[User talk:Wikiisawesome|<span style="color:#600"><small>/tlk</small></span>]] 18:21, 3 December 2015 (UTC)

::::We are in agreement, then. The malformation was due to good-faith user error, but the script hanging on a malformation is a bug. If the script becomes so confused that it can't figure out what to do, at least it should crash with an error message, so that the reviewers would know that they need to request help or maybe that they need to try to fix the notes. [[User:Robert McClenon|Robert McClenon]] ([[User talk:Robert McClenon|talk]]) 18:50, 3 December 2015 (UTC)

::::When I referred to good-faith user error, I was distinguishing it from bad-faith user error, which we do occasionally see, such as the removal of a record of declines. [[User:Robert McClenon|Robert McClenon]] ([[User talk:Robert McClenon|talk]]) 18:50, 3 December 2015 (UTC)

:::::Who are the coders for the script? How do I write up a ticket about the script? [[User:Robert McClenon|Robert McClenon]] ([[User talk:Robert McClenon|talk]]) 02:27, 4 December 2015 (UTC)

::::::{{u|Robert McClenon}}, you can find the form for submitting a bug [https://github.com/WPAFC/afch-rewrite/issues/new here]. [[User:APerson|APerson]]&nbsp;([[User talk:APerson|talk!]]) 04:37, 4 December 2015 (UTC)

:::::::Where are the instructions for using github? Do I have to create an account? Do I sign in with my Wikipedia login and password? [[User:Robert McClenon|Robert McClenon]] ([[User talk:Robert McClenon|talk]]) 06:13, 4 December 2015 (UTC)

::::::::You have to make a GitHub account to open issues there. (If we had the project on Phabricator, you could use your Wikipedia login.) [[User:APerson|APerson]]&nbsp;([[User talk:APerson|talk!]]) 13:54, 4 December 2015 (UTC)