Module talk:Time: Difference between revisions

Revision as of 23:09, 10 August 2018

Revision as of 12:02, 11 August 2018

Line 432:

::::*{{time/sandbox|MST|df=dmy12}}

::::— [[User:BrandonXLF|<span style="outline: 3px double blue;color:lightcyan;background-color:black;'>&nbsp;'''''BrandonXLF'''''&nbsp;</span>]]&nbsp;&nbsp;[[User talk:BrandonXLF|^(t@lk)]]&nbsp;<span style="color:black">^{([[Template:Ping|ping back]])}</span> 22:59, 10 August 2018 (UTC)

{{od}}

Parameter names and the internal variables that they feed should make sense when read and should indicate the action that will occur. {{para|refresh|no}} was a poor choice because the word 'refresh' is a verb indicating action. As I used the variable <code>refresh</code> in the /sandbox, when <code>true == refresh</code> then render a refresh link. You reversed that to mean when <code>false == refresh</code> then render a refresh link. That's just confusing. I have renamed {{para|refresh}} to {{para|hide-refresh}}:

*{{time/sandbox|MST|hide-refresh=yes|df=dmy12}} hide-refresh=yes

*{{time/sandbox|MST|hide-refresh=no|df=dmy12}} hide-refresh=no

*{{time/sandbox|MST|df=dmy12}}

Similarly, I renamed {{para|show_tz}} to {{para|hide-tz}}:

*{{time/sandbox|MST|hide-tz=yes|df=dmy12}} hide-tz=yes

*{{time/sandbox|MST|hide-tz=no|df=dmy12}} hide-tz=no

*{{time/sandbox|MST|df=dmy12}}

and while at it, created {{para|unlink-tz}}:

*{{time/sandbox|MST|unlink-tz=yes|df=dmy12}} unlink-tz=yes

*{{time/sandbox|MST|unlink-tz=no|df=dmy12}} unlink-tz=no

*{{time/sandbox|MST|df=dmy12}}

—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 12:01, 11 August 2018 (UTC)