Content deleted Content added
→Code to insert bold tags: fixed |
|||
Line 269:
|{{ping|Johnuniq}} Thanks for working on RoundN! I think this was my 3rd Lua module and I am pretty sure I didn't even know that making function local was a thing at the time (FYI, I hadn't even heard of Lua just 6 weeks prior to when I stopped working on RoundN in Jan 2015). I agree that making those functions local sounds like a good idea.
As for your changes around the line {{code|lang=lua|local hasBold, b {{=}} ...}}, the changes miss the purpose of original, which was to bold text when users enter something like <code><nowiki>'''text</nowiki></code> (as opposed to properly closing it with <code><nowiki>'''text'''</nowiki></code>). Unclosed bold is works fine in MediaWiki-based templates but doesn't work in Lua-based templates, so those lines were an attempt maintain backwards compatibility. Your edit only affected paired/closed wiki-bold mark-up, which left, for example, left all of the score numbers (33, 40, etc.) unbolded in [[2015–16 Magyar Kupa (men's handball)#Final four]].
That said, non-working bolding is better than the error that was there before, so good job restoring partial functionality while I was MIA :) It's fixed now. —[[User:Codehydro|<font color="#aaaaaa" face="Unicode" style="font-size:12pt;">'''Code'''</font>]][[User talk:Codehydro|<font color="#5577aa">'''Hydro'''</font>]] 23:32, 8 September 2018 (UTC)
| |||