Module talk:Sports table/Archive 1: Difference between revisions

Revision as of 05:13, 19 December 2018

Revision as of 05:22, 26 December 2018

Line 2,173:

It seems that it's not working. See [[Template:2019 FIBA Basketball World Cup qualification (Americas) – Group F table]]. [[User:Howard the Duck|Howard the Duck]] ([[User talk:Howard the Duck|talk]]) 08:38, 19 September 2018 (UTC)</s>

:LOL it's working I'm just bad at math. [[User:Howard the Duck|Howard the Duck]] ([[User talk:Howard the Duck|talk]]) 08:43, 19 September 2018 (UTC)

== Template-protected edit request on 27 June 2018 ==

{{edit template-protected|Module:Sports table/WDL|answered=yes}}

Change:

local status_letters = 'ACSDEGHOPQRTXYZ'

to:

local status_letters = 'ACDEGHOPQRSTXYZ'

To maintain an alphabetical order below the table. <span style="border:1px solid maroon; padding:0 2px">[[User:CRwikiCA|<span style="font-family:'Courier';color:maroon">CRwikiCA</span>]]&nbsp;[[User talk:CRwikiCA|<i style="color:navy">talk</i>]]</span> 01:57, 27 June 2018 (UTC)

: {{U|CRwikiCA}}, "S" is only used in Swedish football articles, where it is an abbreviation for "Swedish Champion". putting it after R would look strange. see [[1989 Allsvenskan]]. [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 14:11, 27 June 2018 (UTC)

::{{U|Frietjes}}, it is only used on those articles at the moment. This Module has been a raging success and has been adopted widely, it is reasonable to expect someone to want to use it for some other purpose. In general it will be easiest to find letters back when ordered alphabetically, to change that default for a particular article (ignoring other possible use cases) makes it less of a general purpose Module. To keep this the most general (and in light of the use case of custom order) I would suggest:

::* Allow all letters as status letters (A-Z)

::* Have default order ABC...Z

::* Let the user customize this order (if desired)

::* Ensure no letters are missing from the user input

::That would make defaults reasonable while giving users maximum flexibility. <span style="border:1px solid maroon; padding:0 2px">[[User:CRwikiCA|<span style="font-family:'Courier';color:maroon">CRwikiCA</span>]]&nbsp;[[User talk:CRwikiCA|<i style="color:navy">talk</i>]]</span> 01:43, 28 June 2018 (UTC)

:::{{U|CRwikiCA}}, okay, now changed so [//en.wikipedia.org/w/index.php?title=1989_Allsvenskan&type=revision&diff=847888742&oldid=847739727 this works]. this also enables letters not in the default list (any non-default letters must be listed or they will not appear). [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 13:39, 28 June 2018 (UTC)

:::more changes so if you forget to put a letter in the list, it will still show, but will be listed after the ones that you list. and, now all letters will show, but with a '?' if the text is not defined (or one of the presets). [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 14:25, 28 June 2018 (UTC)

::::{{U|Frietjes}} Great work! It's always best to incorporate stuff while the changes and code are still fresh in your mind. <span style="border:1px solid maroon; padding:0 2px">[[User:CRwikiCA|<span style="font-family:'Courier';color:maroon">CRwikiCA</span>]]&nbsp;[[User talk:CRwikiCA|<i style="color:navy">talk</i>]]</span> 02:14, 1 July 2018 (UTC)

Can a custom status letter be also added for "W"? [[User:Howard the Duck|Howard the Duck]] ([[User talk:Howard the Duck|talk]]) 08:49, 3 September 2018 (UTC)

:{{u|Howard the Duck}} Was already implemented (see below). <span style="border:1px solid maroon; padding:0 2px">[[User:CRwikiCA|<span style="font-family:'Courier';color:maroon">CRwikiCA</span>]]&nbsp;[[User talk:CRwikiCA|<i style="color:navy">talk</i>]]</span> 02:21, 5 September 2018 (UTC)

{{#invoke:Sports table|main|style=WDL

|status_pos=after

|team1=AAA

|result1=RRR

|status_AAA=W

|name_AAA=Team A

|res_col_header=PQR

|col_RRR= |text_RRR=Plain text

|status_text_W=Whatever

}}

::Many thanks! I'd suggest to allow every letter in the alphabet to be added as a status letter though, if that's possible, so that no one bugs you about this again... [[User:Howard the Duck|Howard the Duck]] ([[User talk:Howard the Duck|talk]]) 07:24, 5 September 2018 (UTC)

:::That was the request above, which Frietjes implemented. I did not test it, but if anything is missing let us know. :) <span style="border:1px solid maroon; padding:0 2px">[[User:CRwikiCA|<span style="font-family:'Courier';color:maroon">CRwikiCA</span>]]&nbsp;[[User talk:CRwikiCA|<i style="color:navy">talk</i>]]</span> 02:43, 6 September 2018 (UTC)

::::I tried using all letters but some didn't show up, like "W". Maybe I didn't save it that's why I didn't see it. [[User:Howard the Duck|Howard the Duck]] ([[User talk:Howard the Duck|talk]]) 08:57, 8 September 2018 (UTC)

:::::I think it's not showing up for the WL style? Can somebody check it out? [[User:Howard the Duck|Howard the Duck]] ([[User talk:Howard the Duck|talk]]) 10:16, 25 September 2018 (UTC)

:::::: [[User:Howard the Duck|Howard the Duck]], should work now. it was never added to the WL module. we should really consider merging some of these modules, lots of code duplication. [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 13:41, 25 September 2018 (UTC)

::::::: Thanks! Yes that's something you guys should look in to. WL can be easily merged with WDL (I think.) [[User:Howard the Duck|Howard the Duck]] ([[User talk:Howard the Duck|talk]]) 10:12, 26 September 2018 (UTC)