Content deleted Content added
→Bug - does not ignore wd coordinates (P625) for type=line: fixed in the sandbox |
|||
Line 40:
{{ping|Evad37}} I think I identified a bug - the module does not ignore wikidata's "coordinate ___location" property (P625) for type=line which results in broken both the thumbnail map and the big map. I opened a ticket on Phabricator: T227402. My findings are simply when there is no P625 on wikidata the thumbnails/map/zooming etc. works ok. But when there is P625 these are broken, but I only tested type=line which is the only type that interests me. Can you fix it please? Thanks! --[[User:Kozuch|Kozuch]] ([[User talk:Kozuch|talk]]) 10:03, 27 July 2019 (UTC)
:{{ping|Kozuch}} I've fixed it in the sandbox: {{Maplink/sandbox|frame=yes|id=Q515443|type=line}}<pre>{{Maplink/sandbox|frame=yes|id=Q515443|type=line}}</pre> Can you check if the sandbox version works with some of the other maps you've been working on? - <u>'''[[User:Evad37|Evad]]''37'''''</u> <span style="font-size:95%;">[[[d:w:User talk:Evad37|talk]]]</span> 07:38, 3 August 2019 (UTC)
::{{ping|Evad37}} I set up a testing page at [https://en.wikipedia.org/w/index.php?title=User:Kozuch/Sandbox6&oldid=909139452 this link]. The problem on simple line objects like [[D52 motorway (Czech Republic)]] or interstates sections within states is fixed. For type=shape this seems also fixed (Pinelands National Reserve, Wharton State Forest). I recently discovered that type=line also works for type=shape (on some pages) as I do not want the infill on type=shape as the map inside is darker and can not be seen both in thumbnail and full screen map. Interestingly the fix works for Austria when type=line is used but it does not for Pinelands National Reserve and Wharton State Forest with type=line - do you know what is the issue? Also a long Interstate 5 does now work - I think this is because the master relation on OSM (https://www.openstreetmap.org/relation/2329642) has sub-relations and that simply does not work with Mapframe/Kartographer (but WIWOSM can show master relation! - I would appreciate that to work here too). I think you can push the Module from sandbox to production if you want. The "new" issues I raised (I will update the bug) are kind of additional in the context of the original bug. If you move it to production I can at least use what is working now and not need to use my module clone. --[[User:Kozuch|Kozuch]] ([[User talk:Kozuch|talk]]) 11:29, 3 August 2019 (UTC)
| |||