Content deleted Content added
m Archiving 1 discussion(s) from Template talk:WPBannerMeta) (bot |
m Archiving 1 discussion(s) from Template talk:WPBannerMeta) (bot |
||
Line 372:
::You're right, but now I remember why the NAME parameter is mandatory - it is used by [[meta:Community Tech/PageAssessments|PageAssessments]] — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 10:53, 18 September 2019 (UTC)
:::The collapsed banner displays {{para|TF_''n''_NESTED}} whether tf hooks are used or not. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] 🌹 ([[User talk:Redrose64|talk]]) 14:41, 18 September 2019 (UTC)
== Auto assess icon ==
{{edit protected|Template:WPBannerMeta/core|answered=yes}}
Could someone please change the following in {{tl|WPBannerMeta/core}}:
|{{WPBannerMeta/note
|IMAGE=Robot icôn.svg
|SIZE=30px
to:
|{{WPBannerMeta/note
|IMAGE=Robot icôn.svg
|SIZE=<nowiki>{{{NOTE_SIZE|}}}</nowiki>
I don't see any reason why the auto assess icon should be handled differently to any other note icon, especially when the rest default to a diferent size. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 01:00, 18 September 2019 (UTC)
:Yes, that makes sense to me too — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 06:23, 18 September 2019 (UTC)
::{{Re|PC78}} please update in sandbox and validate testcases. If there is a missing test case for this condition, please make one and validate. — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 13:49, 18 September 2019 (UTC)
:::{{ping|MSGJ}} A little help? :) I've made changes to {{tl|WPBannerMeta/core/sandbox}} and {{tl|WPBannerMeta/sandbox}} and switched {{tl|WikiProject Biography/sandbox}} over to the sandboxed meta... What am I missing? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 15:37, 18 September 2019 (UTC)
::::If you tell us where your testcases are, we can look at what is happening. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] 🌹 ([[User talk:Redrose64|talk]]) 18:08, 18 September 2019 (UTC)
:::::Ah... looks like it ''is'' working with the testcase at [[User talk:PC78/test banner]]; what's throwing me is why the change isn't visible at [[Template:WikiProject Biography/sandbox]]. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 18:12, 18 September 2019 (UTC)
::::::Testcases shouldn't be in a sandbox or in user space, they should be in Template: space - but for templates that are only used in a talk space, such as a WikiProject banner, they need to be in Template talk: space. Also, shey should be in a subpage whose name ends /testcases.
::::::If your primary change is going to be made to [[Template:WikiProject Biography]], the testcases should be at [[Template talk:WikiProject Biography/testcases]]; and if your primary change is going to be made to [[Template:WPBannerMeta]] or [[Template:WPBannerMeta/core]], the testcases should be at [[Template talk:WPBannerMeta/testcases]]. More at [[WP:TESTCASES]]. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] 🌹 ([[User talk:Redrose64|talk]]) 18:57, 18 September 2019 (UTC)
:::::::None of that should make the slightest bit of difference... however, see test banner at {{tl|WPBannerMeta/testcases}} and transclusion of test banner at [[Template talk:WPBannerMeta/testcases]]. Perhaps I'm being obtuse, but I don't see any other way of testing the code. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 20:01, 18 September 2019 (UTC)
:::::::Tests at [[Template:WikiProject Biography/testcases]] check out fine — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 20:25, 18 September 2019 (UTC)
::::::::{{replyto|MSGJ}} Why does one from the sandbox have the auto row in a collapsed "More information:" section, whilst the live one has it exposed? Aside from that, does the robot head need to be that big? I thought we usually set the heights of note icons to be consistent. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] 🌹 ([[User talk:Redrose64|talk]]) 21:19, 18 September 2019 (UTC)
:::::::::Cheers Martin, I'd just got there on my own but I see you beat me to it – that's what I get for trying to rush things at work when I should have done it properly at home! {{ping|Redrose64}} That's exactly what this change will fix, the auto symbol will be handled like all other note icons. As for being collapsed, that depends entirely on the number of notes in the banner and the {{para|COLLAPSED}} setting. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 22:36, 18 September 2019 (UTC)
::::::::::The testcase at [[Template:WikiProject Biography/testcases#Auto assess]] uses exactly the same parameters for live and sandbox, therefore it should have exactly the same number of notes, therefore either both should collapse, or neither should. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] 🌹 ([[User talk:Redrose64|talk]]) 22:48, 18 September 2019 (UTC)
:::::::::::The sandboxed version of {{tl|WikiProject Biography}} is not the same as the live version. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 22:50, 18 September 2019 (UTC)
::::::::::::[[Template:WPBannerMeta/testcases|Yes! We Have No Bananas]] – Hopefully this constitutes a sufficient test? {{ping|Xaosflux}} Can you please make [[Special:Diff/916370189|this change]] to {{tl|WPBannerMeta/core}}, assuming there are no further concerns? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 00:37, 19 September 2019 (UTC)
{{ping|Xaosflux}} (or someone else) I think we're good to implement this change now. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 20:18, 23 September 2019 (UTC)
:Haven't had time to review this yet - of course anyone else may. I will get to it eventually (always working the PERT queues). — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 00:33, 24 September 2019 (UTC)
::{{done}} {{ping|PC78}} this has been done. Anyone should revert without consulting with me if this causes an immediate problem. — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 13:01, 24 September 2019 (UTC)
| |||