Content deleted Content added
m Archiving 1 discussion(s) from Module talk:Sports table) (bot |
m Archiving 1 discussion(s) from Module talk:Sports table) (bot |
||
Line 84:
|}
note that <code>win3s</code> means win in 3 sets, which is the same as <code>w3_0</code> in the old vb templates. any win by more than one set is a "big win", and any loss by more than one set is a "big loss". the point values for big wins and big losses are the same as before and can be changed the same as before. let me know if you see any problems. [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 21:14, 6 February 2020 (UTC)
== Legs parameter from [[Module:Sports results]] ==
When the matches are defined in the template, would it be possible to support additional legs (for 3+ meetings in a season) as is done in [[Module:Sports results]]? For example [[2014–15 Belgian Pro League#Relegation Playoff|here]], so the results table doesn't have to be separate. [[User:S.A. Julio|S.A. Julio]] ([[User talk:S.A. Julio#top|talk]]) 23:15, 24 January 2020 (UTC)
:Can't you use {{tl|ThreeLegStart}}? It has an option to extend it to five legs. [[User:Howard the Duck|Howard the Duck]] ([[User talk:Howard the Duck|talk]]) 13:48, 25 January 2020 (UTC)
::Doesn't really fit, as this isn't based on aggregate score or winning more matches than the other, but finishing first in a table based on points and goal difference. [[User:S.A. Julio|S.A. Julio]] ([[User talk:S.A. Julio#top|talk]]) 14:06, 25 January 2020 (UTC)
:::[[User:S.A. Julio|S.A. Julio]], probably works now, but let me know if I didn't implement it correctly. [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 19:27, 26 January 2020 (UTC)
::::{{u|Frietjes}}, great thanks! Only difference I noticed is the null value doesn't work for leg 3 (just displays a normal blank cell). [[User:S.A. Julio|S.A. Julio]] ([[User talk:S.A. Julio#top|talk]]) 03:11, 27 January 2020 (UTC)
{{od}} [[User:S.A. Julio|S.A. Julio]], I think you are talking about the difference in the match3_BBB_AAA cell (which is omitted and not set to null) seen here
{{#invoke:sports table|main|style=WDL
|res_col_header=QR
|team1=AAA|name_AAA=Team A
|team2=BBB|name_BBB=Team B
|win_AAA=3|draw_AAA=0|loss_AAA=1|gf_AAA=8|ga_AAA=4|adjust_points_AAA=0
|win_BBB=1|draw_BBB=0|loss_BBB=3|gf_BBB=4|ga_BBB=8|adjust_points_BBB=3
|class_rules=1) points; 2) head-to-head points; 3) head-to-head goal difference; 4) head-to-head goals scored; 5) goal difference; 6) number of goals scored.
|update=complete
|source=the source
|show_matches=y
|matches_style=FBR|solid_cell=grey
|legs=3
|match1_BBB_AAA=2–3
|match1_AAA_BBB=0–1
|match2_BBB_AAA=0–2
|match2_AAA_BBB=3–1
|match3_BBB_AAA_note=Match not played
|match3_AAA_BBB=null
}}
{{#invoke:sports results|main
|team1=AAA|name_AAA=Team A
|team2=BBB|name_BBB=Team B
|matches_style=FBR|solid_cell=grey
|legs=3
|match1_BBB_AAA=2–3
|match1_AAA_BBB=0–1
|match2_BBB_AAA=0–2
|match2_AAA_BBB=3–1
|match3_BBB_AAA_note=Match not played
|match3_AAA_BBB=null
}}
the interesting thing about this is that if you check the standard 1 leg case you see the same thing. the source of this difference can be found by checking the code for [[Module:Sports results]] line 184 which has <code><nowiki>Args[m..team_code_ii..'_'..team_code_jj] = (Args[m..team_code_ii..'_'..team_code_jj] or '–')..note_string</nowiki></code> which is default dash and [[Module:Sports table]] line 472 which has <code><nowiki>Args[m..team_code_ii..'_'..team_code_jj] = (Args[m..team_code_ii..'_'..team_code_jj] or '')..note_string</nowiki></code> which has default blank. another interesting feature is that if you were try to put a null in that cell you don't get what you would expect:
{{#invoke:sports table|main|style=WDL
|res_col_header=QR
|team1=AAA|name_AAA=Team A
|team2=BBB|name_BBB=Team B
|win_AAA=3|draw_AAA=0|loss_AAA=1|gf_AAA=8|ga_AAA=4|adjust_points_AAA=0
|win_BBB=1|draw_BBB=0|loss_BBB=3|gf_BBB=4|ga_BBB=8|adjust_points_BBB=3
|class_rules=1) points; 2) head-to-head points; 3) head-to-head goal difference; 4) head-to-head goals scored; 5) goal difference; 6) number of goals scored.
|update=complete
|source=the source
|show_matches=y
|matches_style=FBR|solid_cell=grey
|legs=3
|match1_BBB_AAA=2–3
|match1_AAA_BBB=0–1
|match2_BBB_AAA=0–2
|match2_AAA_BBB=3–1
|match3_BBB_AAA=null
|match3_BBB_AAA_note=Match not played
|match3_AAA_BBB=null
}}
{{#invoke:sports results|main
|team1=AAA|name_AAA=Team A
|team2=BBB|name_BBB=Team B
|matches_style=FBR|solid_cell=grey
|legs=3
|match1_BBB_AAA=2–3
|match1_AAA_BBB=0–1
|match2_BBB_AAA=0–2
|match2_AAA_BBB=3–1
|match3_BBB_AAA=null
|match3_BBB_AAA_note=Match not played
|match3_AAA_BBB=null
}}
unless you remove the note from the result. editors have probably figured this out by now. as far as the inconsistency goes, I am all for making them consistent. if possible, I would like to merge more of the redundant code which would force them to be consistent. the main question is: should the default be dash or should the default be blank? I really don't care either way. [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 16:16, 27 January 2020 (UTC)
:{{u|Frietjes}}, thanks a lot for adding the legs functionality to this module. I have tried to add it to the [[nl:Module:Sports table|Dutch version]] as well but weirdly it doesn't work there. [[nl:Sjabloon:Stand Play-off 3 (voetbal België)]] is one of the instance where its use is desired there. Could you take a look?[[User:Tvx1|T]][[User Talk:Tvx1|v]][[Special:Contributions/Tvx1|x]]1 21:18, 22 February 2020 (UTC)
::{{u|Tvx1}}, okay, I think I fixed it. there is a lot there, but you had missed making changes to the header and row subfunctions in [[:nl:Module:Sports results]]. now that I have implemented the changes there, it should be working (although I may have missed something). [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 14:45, 23 February 2020 (UTC)
I've been thinking about this a bit more and I'm starting to wonder why these legs are always generated in pairs (e.g. 2/4/6). In the above example, for instance, I'd think that the sixth column of matches doesn't really need to be there.[[User:Tvx1|T]][[User Talk:Tvx1|v]][[Special:Contributions/Tvx1|x]]1 22:39, 29 February 2020 (UTC)
| |||