Module talk:Sports table/Archive 2: Difference between revisions

Revision as of 06:03, 1 August 2020

Revision as of 06:17, 26 August 2020

Line 848:

::::: Thanks, that's even better for the reason you explained. [[User:Mohsen1248|Mohsen1248]] ([[User talk:Mohsen1248|talk]]) 20:20, 2 May 2020 (UTC)

:::::{{ping|NHammen}} I made necessary adjustments in all articles using this module, so if you want to make any change or even remove that previous option, that won't make any harm. anyway I highly doubt there will be a table with more than column in bold. [[User:Mohsen1248|Mohsen1248]] ([[User talk:Mohsen1248|talk]]) 20:37, 2 May 2020 (UTC)

== In the WDL style, highest_pos and show_gb interact badly ==

If you use {{para|show_gb|yes}} but do not define {{para|GB_team}} then {{para|GB_team}} defaults to 1. On line 329 of the WDL style, the following concatenation is used: <code>'win_'..team_list[GB_team_no]</code>. However, the team list that is passed to the row function in the style only includes teams between {{para|highest_pos}} and {{para|lowest_pos}}. Therefore, if {{para|highest_pos}} is greater than 1, then <code>team_list[GB_team_no]</code> is nil, and a Lua error is thrown indicating that a concatenation with a nil value was attempted. Either <code>GB_team_no</code> needs a different default value (maybe equal to highest_pos), or some sort of error checking is needed to prevent concatenation with a nil. [[User:NHammen|NHammen]] ([[User talk:NHammen|talk]]) 16:39, 27 May 2020 (UTC)

== Screws up if rank doesn't start at #1 ==

Is there a way for this to start on any other ranking save for #1? There are some tournaments were lower seeded teams compete separately from higher seeded teams. Or maybe I'm doing it wrong? <!-- Template:Unsigned --><small class="autosigned">—&nbsp;Preceding [[Wikipedia:Signatures|unsigned]] comment added by [[User:Howard the Duck|Howard the Duck]] ([[User talk:Howard the Duck#top|talk]] • [[Special:Contributions/Howard the Duck|contribs]]) 12:16, 23 May 2020 (UTC)</small><!-- Template:Xsign -->

:{{Ping|Howard the Duck}} There are a couple of ways of handling this.

:Option 1: define all teams but use {{para|highest_pos}}:

{{#tag:pre|<nowiki>{{#invoke:Sports table|main|</nowiki>style=WDL

<nowiki>|team1=AAA |team2=BBB |team3=CCC |team4=DDD |team5=EEE</nowiki>

<nowiki>|name_AAA=Team A</nowiki>

<nowiki>|name_BBB=Team B</nowiki>

<nowiki>|name_CCC=Team C</nowiki>

<nowiki>|name_DDD=Team D</nowiki>

<nowiki>|name_EEE=Team E</nowiki>

<nowiki>|highest_pos=3</nowiki>

<nowiki>}}</nowiki>}}

{{#invoke:Sports table|main|style=WDL

|team1=AAA |team2=BBB |team3=CCC |team4=DDD |team5=EEE

|name_AAA=Team A

|name_BBB=Team B

|name_CCC=Team C

|name_DDD=Team D

|name_EEE=Team E

|highest_pos=3

}}

:Option 2: define only the needed teams and use {{para|pos_XXX}}:

{{#tag:pre|<nowiki>{{#invoke:Sports table|main|</nowiki>style=WDL

<nowiki>|team1=CCC |team2=DDD |team3=EEE</nowiki>

<nowiki>|pos_CCC=3 |pos_DDD=4 |pos_EEE=5</nowiki>

<nowiki>|name_CCC=Team C</nowiki>

<nowiki>|name_DDD=Team D</nowiki>

<nowiki>|name_EEE=Team E</nowiki>

<nowiki>}}</nowiki>}}

{{#invoke:Sports table|main|style=WDL

|team1=CCC |team2=DDD |team3=EEE

|pos_CCC=3 |pos_DDD=4 |pos_EEE=5

|name_CCC=Team C

|name_DDD=Team D

|name_EEE=Team E

}}

:Note that if you do both, bad things will happen. [[User:NHammen|NHammen]] ([[User talk:NHammen|talk]]) 16:24, 27 May 2020 (UTC)

::Copy that. Thanks! [[User:Howard the Duck|Howard the Duck]] ([[User talk:Howard the Duck|talk]]) 17:05, 27 May 2020 (UTC)

== Requested move 17 May 2020 ==

<div class="boilerplate" style="background-color: #efe; margin: 0; padding: 0 10px 0 10px; border: 1px dotted #aaa;"><!-- Template:RM top -->

:''The following is a closed discussion of a [[Wikipedia:Requested moves|requested move]]. <span style="color:red">'''Please do not modify it.'''</span> Subsequent comments should be made in a new section on the talk page. Editors desiring to contest the closing decision should consider a [[Wikipedia:move review|move review]] after discussing it on the closer's talk page. No further edits should be made to this discussion. ''

The result of the move request was: '''Moved''' to [[Module:Sports table/styledoc]] as suggested &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 21:19, 27 May 2020 (UTC)

----

* [[:Module:Sports table/doc/doc]] → ?

– The current title of this page makes absolutely zero sense; docuementation pages don't themselves need documentation [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 17:36, 17 May 2020 (UTC)

* I would move it to [[:Module:Sports table/styledoc]] or something that indicates that it is used by the various style pages. the key is to make sure it's not parsed as lua code. [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 21:03, 17 May 2020 (UTC)

*: {{ping|Frietjes}} Having wikitext pages in the Module namespace without the <code>/doc</code> subpage has been supported for years (although attempting to execute this move will trigger a warn-only edit filter, since the behavior could easily be surprising if you don't understand it). [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 17:47, 24 May 2020 (UTC)

----

: ''The discussion above is closed. <b style="color: #FF0000;">Please do not modify it.</b> Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.''<!-- from [[Template:Archive bottom]] -->

</div><div style="clear:both;"></div>