Module talk:Random slideshow: Difference between revisions

Content deleted Content added
link fix
Line 91:
I think that choosing 50 at random is as simple as adding the <code>, 1, 50</code> in <code>local galleryContent = table.concat(sortedLines, '\n', 1, 50)</code>, though pruning the selection earlier might be more efficient and we may want to accept a parameter to override the value of 50 that I plucked from thin air. Any thoughts? [[User:Certes|Certes]] ([[User talk:Certes|talk]]) 12:47, 30 September 2020 (UTC)
*I noticed that {{u|Pakieditor}} significantly expanded the General images section on 20 September 2020 ([https://en.wikipedia.org/w/index.php?title=Portal:Pakistan&diff=979444187&oldid=972187558 diff]), which is very likely contributing to the Lua timeout errors. An immediate fix would be to prune some of the entries from the General images section. From past experience, this tends to stop the timeouts. <span class="smallcaps" style="font-variant:small-caps;">[[User:Northamerica1000|North America]]<sup>[[User talk:Northamerica1000|<span style="font-size: x-small;">1000</span>]]</sup></span> 13:20, 30 September 2020 (UTC)
:{{re|Certes}} That's rather late in the piece to be limiting the number of images. The expensive (time-consuming) work is likely to be in the {{tt|extractRegularFiles}} function, which does a bunch of string manipluation and (potentially) preprocessing of templates in a loop. - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 13:29, 30 September 2020 (UTC)