Content deleted Content added
→Portals with many images: comment |
files=1-50 and prune article lists? |
||
Line 92:
*I noticed that {{u|Pakieditor}} significantly expanded the General images section on 20 September 2020 ([https://en.wikipedia.org/w/index.php?title=Portal:Pakistan&diff=979444187&oldid=972187558 diff]), which is very likely contributing to the Lua timeout errors. An immediate fix would be to prune some of the entries from the General images section. From past experience, this tends to stop the timeouts. <span class="smallcaps" style="font-variant:small-caps;">[[User:Northamerica1000|North America]]<sup>[[User talk:Northamerica1000|<span style="font-size: x-small;">1000</span>]]</sup></span> 13:20, 30 September 2020 (UTC)
:{{re|Certes}} That's rather late in the piece to be limiting the number of images. The expensive (time-consuming) work is likely to be in the {{tt|extractRegularFiles}} function, which does a bunch of string manipluation and (potentially) preprocessing of templates in a loop. - <u>'''[[User:Evad37|Evad]]''37'''''</u> <span style="font-size:95%;">[[[d:w:User talk:Evad37|talk]]]</span> 13:29, 30 September 2020 (UTC)
::You're right; it's too late. extractRegularFiles is efficient: gsub takes 0.32 seconds, some of which lies elsewhere. I suspect the time goes even earlier, in the parse function of Module:Excerpt/portals (which is mainly my fault, though the attribution has become separated). The killer there is retrieving up to 100 file description pages to check for non-free licences. We should probably set files=1-50 rather than 100 in this module but also remove some articles from the list in Portal:Pakistan and similar cases. [[User:Certes|Certes]] ([[User talk:Certes|talk]]) 13:59, 30 September 2020 (UTC)
| |||