Content deleted Content added
m Archiving 1 discussion(s) from Template talk:WPBannerMeta) (bot |
m Archiving 1 discussion(s) from Template talk:WPBannerMeta) (bot |
||
Line 41:
:Yes, there's a misplaced pipe in one line. Instead of this: <syntaxhighlight lang=moin> {{#ifexist: Portal:{{{PORTAL|}}}|</syntaxhighlight> it should have been this: <syntaxhighlight lang=moin> |{{#ifexist: Portal:{{{PORTAL|}}}</syntaxhighlight> The purpose, IIRC, was to suppress the display of a redlinked portal at a time when a large number of portals were being deleted without all incoming links being removed. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] 🌹 ([[User talk:Redrose64|talk]]) 14:49, 6 October 2020 (UTC)
::Never mind I see it was undone a few days later — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 18:25, 6 October 2020 (UTC)
== Inactive project layout ==
The following is extremely jarring when encountered
{{WikiProjectBannerShell|1=
{{WikiProject Skepticism|class=NA|category=no}}
{{WikiProject Homeopathy |class=NA|category=no}}
{{WikiProject Alternative medicine |class=NA|category=no}}
{{WikiProject Alternative Views |class=NA|category=no}}
{{WikiProject Citizendium Porting}}
{{WikiProject Citizendium Porting/sandbox}}
}}
The inactive project should be center-aligned just like the active ones. And the '''([[Wikipedia:WikiProject_Council/Guide#Dealing_with_inactive_WikiProjects|Inactive]])''' links should be at the same place as the '''(Raged X-class)'''.  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 16:06, 1 October 2020 (UTC)
:Okay, looks good to me. Can you code it in the sandbox? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 16:33, 1 October 2020 (UTC)
::It's something to do with [[Template:Inactive WikiProject banner]] I think. I figured someone here would know where the code was hosted and have a quick fix, but I suppose I can dig deeper. It will likely take me some time, as I don't know how this template is structured, or how it interacts with {{tl|WPBS}}.  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 17:59, 1 October 2020 (UTC)
:::So far, this is looking beyond my skills.  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 18:10, 1 October 2020 (UTC)
::::How's that looking on your browser? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 19:34, 1 October 2020 (UTC)
:::::{{Re|MSGJ}} looks tip top on every browser I have tried (Chrome, Firefox). Nothing displays on mobile though, but I believe that's normal behaviour.  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 19:35, 1 October 2020 (UTC)
Okay I think I'll wait for someone (is {{ul|WOSlinker}} still around??) to check my changes to these templates:
*[[Template:WPBannerMeta/sandbox]]
*[[Template:WPBannerMeta/core/sandbox]]
*[[Template:Inactive WikiProject banner/sandbox]]
— Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 19:52, 1 October 2020 (UTC)
:(If I was clever I would add the diff links, but I'm not) — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 19:53, 1 October 2020 (UTC)
::{{Re|MSGJ}}, the code you moved from the core to the main template needs to stay in core as the class and importance param values are normalised before being passed to the core template. See example below. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 20:04, 1 October 2020 (UTC)
{{WikiProjectBannerShell|1=
{{WikiProject British Museum|class=xxx|importance=zzz|category=no}}
{{WikiProject British Museum/sandbox|class=xxx|importance=zzz|category=no}}
{{WikiProject Resource Exchange|category=no}}
{{WikiProject Resource Exchange/sandbox|category=no}}
}}
:::Ah yes, good catch. I was trying to simplify the logic in /core so I wouldn't need to work out the same thing three times! — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 20:58, 1 October 2020 (UTC)
:::Reverted to my previous version. Hopefully looking better now. Good to see you by the way. This is like the old days ... — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 21:00, 1 October 2020 (UTC)
::::Looking good now. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 22:32, 1 October 2020 (UTC)
:::::I added further testcases. Feel free to check {{tl|WikiProject Resource Exchange}} / {{tl|WikiProject Resource Exchange/sandbox}}.  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 02:57, 2 October 2020 (UTC)
::::::That's the normal expected behaviour because that template doesn't do any assessments — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:12, 2 October 2020 (UTC)
::::::Unless you're suggesting that every project should be right-aligned at the middle? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:13, 2 October 2020 (UTC)
:::::::That is actually much easier to implement that way. How are we looking now? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:23, 2 October 2020 (UTC)
::::::::Yes, Wikiproject names should always be centered in the usual style. Looks great here.  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 13:26, 2 October 2020 (UTC)
{{done|Deployed}}, now just sit back and wait for the error reports to come in! — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 21:22, 2 October 2020 (UTC)
:Woohoo, party time.  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 21:46, 2 October 2020 (UTC)
===Couple more===
There is one that still stands out, [[Template:MILHIST]]
{{WikiProjectBannerShell|1=
{{WikiProject British Museum|class=xxx|importance=zzz|category=no}}
{{WikiProject British Museum/sandbox|class=xxx|importance=zzz|category=no}}
{{WikiProject Military history|class=NA|category=no}}
{{WikiProject Military history/sandbox|class=NA|category=no}}
{{WikiProject Resource Exchange|class=NA|category=no}}
{{WikiProject Physics|class=NA|category=no}}
{{WikiProject U.S. Roads|class=NA|category=no}}
{{Maths rating|class=NA|category=no}}
{{WikiProject Citizendium Porting|category=no}}
{{WikiProject Citizendium Porting/sandbox|category=no}}
}}
 <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 14:35, 4 October 2020 (UTC)
:Milhist doesn't use this template, so can't do anything about that! — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 15:19, 4 October 2020 (UTC)
::Well, it could be converted, or its html adjusted, or whatever.  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 15:23, 4 October 2020 (UTC)
:::Some changes in the [[Template:WikiProject Military history/sandbox|sandbox]] should anyone wish to review. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 16:32, 4 October 2020 (UTC)
::::Milhist is just one of three remaining WikiProject banners that do not use {{tlx|WPBannerMeta}}, the others being, so far as I know, {{tlx|Maths rating}} and {{tlx|WikiProject U.S. Roads}} - see [[Template:WPBannerMeta/Conversion]]. These held out against the general conversion that occurred 10+ years ago, and even though some considerable time has elapsed, these individual WikiProjects should each be asked to show their consensus before the banner is converted to WPBannerMeta (particularly so in the case of milhist which is both one of the oldest WikiProjects and one of those with the greatest activity). In all that time, the only conversions that I am aware of are {{tlx|WikiProject Tropical cyclones}} in July 2011, {{tlx|WikiProject Ships}} in August 2012, {{tlx|WikiProject Systems}} in September 2012, and {{tlx|WikiProject Anime and manga}} in August 2020 - almost eight years since the last one. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] 🌹 ([[User talk:Redrose64|talk]]) 19:21, 4 October 2020 (UTC)
:::::WOSlinker's changes are a tweak to the spacing in the template, that's all — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 19:39, 4 October 2020 (UTC)
::::::Yes, looks as though '''WikiProject U.S. Roads''' and '''Maths rating''' would need tweaking as well. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 20:01, 4 October 2020 (UTC)
:::::{{ping|Redrose64}} You may want to poke in on MATHS; they're discussing that topic right now. [[WT:WPMATH#Proposed change to Template:Maths rating from 2018]]. --[[User:Izno|Izno]] ([[User talk:Izno|talk]]) 20:45, 4 October 2020 (UTC)
::::Code looks good {{ul|WOSlinker}}. Question: because we have homogenised the display of these banners when nested, is it still necessary to use 3 columns with one empty cell? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 20:06, 4 October 2020 (UTC)
:::::{{Re|MSGJ}} I've just removed the 3rd column in core/sandbox and it still looks ok, although the center line has moved a little. Does the hidden metadata need to be in the header or would that be better in the main description area? -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 20:27, 4 October 2020 (UTC)
::::::Can't quite remember. I think it was something to fix a bug in Internet Explorer. Some related discussion at the bottom of [[Template talk:WPBannerMeta/Archive 6#Template:WikiProjectBoxing]]. I notice at the moment the second museum banner above is the best because it doesn't move sideways when uncollapsed. So you've done something right! — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:11, 5 October 2020 (UTC)
::::::::It still moves, just not a whole lot.  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 12:24, 5 October 2020 (UTC)
:::::::The current sandbox version with only the 2 table cells in the header seems to work ok in IE11. Also means that there's no need to update those 3 non-WPBannerMeta project banner templates. I'll wait until tommorrow incase there are any other comments and then copy into live. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 07:27, 5 October 2020 (UTC)
::::::::Looks good from my perpective — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 11:56, 5 October 2020 (UTC)
{{unindent}} Seems only US Roads and Maths need a bit of tweaking now. {{tl|Maths rating}}/{{tl|maths banner}} can be merged and converted to a proper {{tl|WikiProject Mathematics}} with the current metabanner though ([[Wikipedia_talk:WikiProject_Mathematics#Proposed_change_to_Template:Maths_rating_from_2018|discussion]]).  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 14:31, 6 October 2020 (UTC)
:I have coded a version in [[Template:Maths rating/sandbox]] sandbox and commented over there — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:31, 8 October 2020 (UTC)
| |||