- @Mr Stradivarius and Jackmcbarn: - Would you guys please take a look at this? As this is my third module, the module could probably benefit from your experienced eyes to spot potential bugs and ideas for improving the new features. The rendering of {{Round16}} and {{Round8}} are nearly identical, I think; I have not attempted to emulate the spacing of {{Round2}} and {{Round4}} but I don't see a good reason to display them exactly as long as the information conveyed is the same... perhaps those templates would benefit from standardization/a more compact form? What do you think? —CodeHydro 02:26, 2 January 2015 (UTC)
Byes
Two byes to a match leave a black line to the next round, see
| Quarter-finals | Semi-finals | Final | ||||||||
| Day 2 | ||||||||||
| C | ||||||||||
| D | ||||||||||
| tdb | ||||||||||
| A | ||||||||||
| tdb | ||||||||||
| A | ||||||||||
| tdb | ||||||||||
| A | ||||||||||
| Day 1 | ||||||||||
| A | 7 | |||||||||
| B | 5 | |||||||||
-Koppapa (talk) 11:25, 6 January 2015 (UTC)
Done @Koppapa: Ha, I had actual set up my code to detect when both matches are skipped so I could remove the line. Silly me forgot to implement it! Good catch! Anyhow, while I was at it, I came up with a neat shorthand for skipmatch and also extended it beyond the first round. See Module talk:RoundN/testcases/3. Thanks again! —CodeHydro 03:44, 8 January 2015 (UTC)
Comments
@Codehydro: It looks quite good to me. I haven't seen, that somebody would use colors, but ok - as a feature it is ok. You could get some input from WT:FOOTIE, as those templates are usually used by them. --Edgars2007 (talk/contribs) 09:15, 3 January 2015 (UTC)
Please read before asking for seeds
RoundN is intended to replace templates like Template:Round16 which never used seeds. For seeds, use Module:TeamBracket. While it's hardly a challenge to add them, my thinking is that adding a check for seeds is more of a performance drag than helpful since there is already a module that supports them. As much as I want to make accommodate every possible need, the fact is too many features will slow down the module. Slow module = more servers resources used = more ad campaigns for donations = less pleasant wiki and slower page loads. Yes, this module does fancy things that Team bracket currently can't, like auto-bolding and score-summing, but these features save server resources because the mediawiki engine no longer has to parse wikibold markup in each parameter and Lua is more efficient at string processing. (If you want these features with seeds, let TeamBracket's programmers know that they may use RoundN's score cleaning/processing functions by adding require('Module:RoundN').scoreWasher to their code.) —CodeHydro 17:08, 27 January 2015 (UTC)
More compact
Could it be possible to reduce a line the distance between the title of the rounds and the first match box? There is too much space between both. Asturkian (talk) 08:00, 29 January 2015 (UTC)
BTW, you should add in the documentation, the information about |score-boxes= and the possibility of 2+sum. Asturkian (talk) 09:09, 29 January 2015 (UTC)
- @Asturkian: Sorry for the delayed respond. I didn't see the question until just now. I'm assuming you've left the date/place box blank, which would make it appear as though there were a big gap between the title and the first match. A simple work around could be to put an empty span tag
<span />as the first date parameter, which would minimize the size of the first date row. As for documenting the+sumswitch, that is a beta feature which is not officially released. The documentation will be updated when Beta goes live. —CodeHydro 12:49, 24 March 2015 (UTC)
- @Asturkian: Sorry for the delayed respond. I didn't see the question until just now. I'm assuming you've left the date/place box blank, which would make it appear as though there were a big gap between the title and the first match. A simple work around could be to put an empty span tag
- @Codehydro: How does the score-boxes parameter work? QED237 (talk) 16:20, 23 March 2015 (UTC)
- @Qed237: Though I hate to do this, I must hold off on explaining it until the official release of Beta. Been working on a higher priority project so I haven't even touched RoundN since January (RoundN is expected to be used on a few thousand pages at most; the higher priority module is used on 2 million pages). Sorry, but, for now, you'll have to make do by studying Module talk:RoundN/testcases/4, Module talk:RoundN/testcases/5, and Module talk:RoundN/testcases/6 on your own. Very overwhelmed with work lately... and though I'm pretty fast at writing code, I'm awful slow when it comes to explaining it. (In fact, Beta has been 95% ready, but just updating the doc page would probably take me a couple of weeks... and it's probably going to be a while before I even get back to RoundN). —CodeHydro 12:49, 24 March 2015 (UTC)
- @Codehydro: Okay, no problem. I just wanted to check it had not been forgotten. Take your time. QED237 (talk) 14:38, 24 March 2015 (UTC)
Chess
Used it here. It bolds ½ over 1½. Is there a way to change that automatically? Or is manually bolding the way to go? If non-numbers are removes, shouldn't be 1 be bold over nothing? -Koppapa (talk) 17:07, 17 March 2015 (UTC)
- @Koppapa: I see you came up with a workaround on your own. I may have suggested something like {{sort}}, but your way seems to work just fine. The release of beta will have way to customize how scores are "cleaned" but alas Module:RoundN has been on hold because I have other priorities right now —CodeHydro 13:32, 24 March 2015 (UTC)
Error with third place
Hello again. I was trying to export this module to the 2014–15 LKL season article (for making a 5-5-7 playoffs) and I found the third place series are not well displayed. Is there any way to fix it? Asturkian (talk) 21:17, 19 April 2015 (UTC)
Display one team in node
@Codehydro: Hi, I know you are probably busy but is there a way to display only one team in a node at the same time you have scoreboxes? It does not seem to work when testing in User:Qed237/sandbox5. On WT:FOOTY It was requested a bracket that involves teams that can play after being eliminated. Qed237 (talk) 13:53, 6 July 2015 (UTC)
- Hmm, well there is a way.. .but why would you need score boxes for team by itself? Why not use something like Module_talk:RoundN/testcases/6--i.e., the losing teams are in a separate branch? I don't see a situation how a team by itself with no other team can score anything. —CodeHydro 01:43, 10 July 2015 (UTC)
- @Codehydro: Just look at my sandbox and you see the reason, the best ranked eliminated team immediately joins the other teams (and no separate branch). Qed237 (talk) 23:38, 17 July 2015 (UTC)
- @Qed237:I edited your sandbox... something like that? not the prettiest solution, but doesn't require changing Module:RoundN. You may be able to get a better result with node_function{canvas} instead of {line}, but it would require some good HTML/CSS hacking to make it look good. —CodeHydro 03:13, 18 July 2015 (UTC)
- @Codehydro: Looks fine, but I need the extra scorebox as the third round is played with two matches. Qed237 (talk) 11:45, 18 July 2015 (UTC)
- @Qed237:I edited your sandbox... something like that? not the prettiest solution, but doesn't require changing Module:RoundN. You may be able to get a better result with node_function{canvas} instead of {line}, but it would require some good HTML/CSS hacking to make it look good. —CodeHydro 03:13, 18 July 2015 (UTC)
- @Codehydro: Just look at my sandbox and you see the reason, the best ranked eliminated team immediately joins the other teams (and no separate branch). Qed237 (talk) 23:38, 17 July 2015 (UTC)
Two-legged matches
Are there any plans to add support for two-legged knock out rounds? TheBigJagielka (talk) 12:49, 30 October 2015 (UTC)
- I think that already exists. TheBigJagielka are you thinking about something like
| Quarter-finals | Semi-finals | Final | ||||||||||||||
| Day 1 | ||||||||||||||||
| Team A | 7 | 2 | 9 | |||||||||||||
| Day 5 | ||||||||||||||||
| Team B | 5 | 3 | 8 | |||||||||||||
| Team A | 3 | 2 | 5 | |||||||||||||
| Day 2 | ||||||||||||||||
| Team C | 0 | 2 | 2 | |||||||||||||
| Team C | 4 | 1 | 5 | |||||||||||||
| Day 7 | ||||||||||||||||
| Team D | 0 | 0 | 0 | |||||||||||||
| Team A | 2 | |||||||||||||||
| Day 3 | ||||||||||||||||
| Team G | 5 | |||||||||||||||
| Team E | 0 | 2 | 2 | |||||||||||||
| Day 6 | ||||||||||||||||
| Team F | 5 | 3 | 8 | |||||||||||||
| Team F | 1 | 1 | 2 | |||||||||||||
| Day 4 | ||||||||||||||||
| Team G | 2 | 1 | 3 | |||||||||||||
| Team G | 2 | 1 | 3 | |||||||||||||
| Team H | 1 | 1 | 2 | |||||||||||||
Just use |score-boxes=2+sum. Was that what you had in mind? Qed237 (talk) 13:29, 30 October 2015 (UTC)
- It is. Thanks, I didn't know that that feature existed. TheBigJagielka (talk) 13:33, 30 October 2015 (UTC)
- Not easy to know as it has not been included in documentation for some reason. I just noticed it somehow I while back. Qed237 (talk) 13:50, 30 October 2015 (UTC)
- See now it has been mentioned on this talkpage before. 13:50, 30 October 2015 (UTC)Qed237 (talk)
I was looking to update the bracket on the 2015 Canadian Championship, merging two templates into one.
From this:
| Semifinals | Final | ||||||||||||
| 1 | Vancouver Whitecaps FC | 1 | 2 | 3 | |||||||||
| 4 | FC Edmonton | 1 | 1 | 2 | |||||||||
| 1 | Vancouver Whitecaps FC | 2 | 2 | 4 | |||||||||
| 3 | Montreal Impact | 2 | 0 | 2 | |||||||||
| 2 | Toronto FC | 0 | 3 | 3 | |||||||||
| 3 | Montreal Impact | 1 | 2 | 3 | |||||||||
To this:
| Preliminary Round | Semifinals | Final | ||||||||||||||
1 Vancouver Whitecaps FC | 1 | 2 | 3 | |||||||||||||
4 FC Edmonton | 1 | 1 | 2 | |||||||||||||
| FC Edmonton | 3 | 3 | 6 | |||||||||||||
| Ottawa Fury FC | 1 | 1 | 2 | |||||||||||||
1 Vancouver Whitecaps FC | 2 | 2 | 4 | |||||||||||||
3 Montreal Impact | 2 | 0 | 2 | |||||||||||||
2 Toronto FC | 0 | 3 | 3 | |||||||||||||
3 Montreal Impact (a) | 1 | 2 | 3 | |||||||||||||
There are two issues; I don't know how to make the league position (the left hand box) appear or know how to embolden the 'sum' for the semi-final winner on away goals. TheBigJagielka (talk) 14:05, 30 October 2015 (UTC)
- @Codehydro: Do you know why the RDseed in first semifinal match (Vancouver v Edmonton) is not "perfect" (a thicker bolded line). Qed237 (talk) 15:05, 4 May 2016 (UTC)
- @Qed237: It's an interaction with the skipmatch parameter. Basically the skipmatch attempts preserve shape of the table with invisible non-breaking space characters by default, but when nodes are skipped unevenly, the skipped characters cause the rows to become uneven in height. RDSeed is a CSS hack that depends on even row heights. I fixed it using the flex_tree parameter. The branch lines between matches won't be perfectly symmetrical, but the nature of the HTML forces one to choose between even looking seeds or even looking branches--i.e. the row height needed to make one thing look even will make the other to look uneven... —CodeHydro