User talk:Mxn/CommentsInLocalTime.js

Interface-protected edit request on 18 November 2022

Latest comment: 2 years ago2 comments1 person in discussion

It is requested that an edit be made to the interface-protected user page at User:Mxn/CommentsInLocalTime.js. (edit · history · last · links · protection log) This template must be followed by a complete and specific description of the request, that is, specify what text should be removed and a verbatim copy of the text that should replace it. "Please change X" is not acceptable and will be rejected; the request must be of the form "please change X to Y". The edit may be made by any interface administrator. Remember to change the |answered=no parameter to "yes" when the request has been accepted, rejected or on hold awaiting user input. This is so that inactive or completed requests don't needlessly fill up the edit requests category. You may also wish to use the {{EIp}} template in the response. To request that a page be protected or unprotected, make a protection request. When the request has been completed or denied, please add the |answered=yes parameter to deactivate the template.

This script has a bug causing the browser window to hang unresponsively when encountering certain invalid dates. I will not include triggering examples in this edit request for obvious reasons, but User_talk:Thparkth/CommentsInLocalTime.js contains two examples (the zeroth of August and the 32nd of August). I found the issue trying to read Wikipedia:Dispute_resolution_noticeboard/Volunteering which contains the "zeroth of August" string.

My proposed edit modifies the date-matching regexp so that this particular bug will not be triggered. It also adds a "break glass" escape counter from the main while() loop to handle any other parsing misadventures that we don't currently know about. If there are other issues like this out there, the page will hang for around a second instead of forever.

The edit request is this diff: [1] Thparkth (talk) 22:00, 18 November 2022 (UTC)Reply

Note the "break glass" fix triggers on WP:GAN, reported by @Olivaw-Daneel here. I can't look into the actual underlying parsing error immediately but this edit request would be a good band-aid. Thparkth (talk) 22:06, 18 November 2022 (UTC)Reply