Module talk:Citation/CS1

This is an old revision of this page, as edited by David Eppstein (talk | contribs) at 00:36, 21 February 2013 (Issues in cite conference and corresponding citation: new section). The present address (URL) is a permanent link to this revision, which may differ significantly from the current revision.

Latest comment: 12 years ago by David Eppstein in topic Issues in cite conference and corresponding citation

Minor bug in position of period

Note the position of the "." after "(PDF)" in {{cite web}} but before it in {{cite web/lua}}:

  • "The History of New York's Chinatown" (PDF). Mediabridge Infosystems, Inc. 2013. Retrieved 2011-03-05.
  • "The History of New York's Chinatown" (PDF). Mediabridge Infosystems, Inc. 2013. Retrieved 2011-03-05.

(Also note that the publisher is being duplicated as of this diff I think) —[AlanM1(talk)]— 19:19, 19 February 2013 (UTC)Reply

Discrepancy in position of page number

Page parameter has moved:

—[AlanM1(talk)]— 19:29, 19 February 2013 (UTC)Reply

Missing period after work parameter

This demonstrates a missing period after the work parameter:

  • "Statue of Liberty". World Heritage. © UNESCO World Heritage Centre 1992–2011. Retrieved 2011-10-23.
  • "Statue of Liberty". World Heritage. © UNESCO World Heritage Centre 1992–2011. Retrieved 2011-10-23.

(publisher is wrapped in parens and dup'd, too, but this may be a temporary thing) —[AlanM1(talk)]— 19:37, 19 February 2013 (UTC)Reply

  • Parentheses are for journal format: The {cite_web/lua} adds parentheses around "(publisher)" when it thinks the cite is for a journal (as variable "Periodical"), so that has caused the confusion. -Wikid77 (talk) 21:01, 19 February 2013 (UTC)Reply

Extra . before publisher

  • {{cite web |url=http://www.example.org/ |title=My Favorite Things, Part II |publisher=Example publisher |accessdate=6 July 2005 }}
"My Favorite Things, Part II". Example publisher. Retrieved 6 July 2005.
"My Favorite Things, Part II". Example publisher. Retrieved 6 July 2005.

-- WOSlinker (talk) 22:34, 19 February 2013 (UTC)Reply

Square brackets not quite in right places

  • {{cite web |url=http://www.example.org/ |title=Honi soit qui mal y pense |last=Joliet |first=François |date=30 April 2005 |accessdate=6 July 2005 |language=French |trans_title=Shame on those who think evil }}
Joliet, François (30 April 2005). "Honi soit qui mal y pense" (in French). Retrieved 6 July 2005. {{cite web}}: Unknown parameter |trans_title= ignored (|trans-title= suggested) (help)
Joliet, François (30 April 2005). "Honi soit qui mal y pense" (in French). Retrieved 6 July 2005. {{cite web}}: Unknown parameter |trans_title= ignored (|trans-title= suggested) (help)

-- WOSlinker (talk) 22:34, 19 February 2013 (UTC)Reply

Format and language transposed

  • {{cite web |url=http://www.incb.org/pdf/e/list/green.pdf |title=List of psychotropic substances under international control |date=30 April 2005 |format=PDF |accessdate=6 July 2005 |language=Greek }}
"List of psychotropic substances under international control" (PDF) (in Greek). 30 April 2005. Retrieved 6 July 2005.
"List of psychotropic substances under international control" (PDF) (in Greek). 30 April 2005. Retrieved 6 July 2005.

-- WOSlinker (talk) 22:34, 19 February 2013 (UTC)Reply

  • {{Cite web |url=http://www.wunderground.com/global/stations/03772.html |title=London, United Kingdom Forecast : Weather Underground (weather and elevation at Heathrow Airport) |publisher=The Weather Underground, Inc. |ref=harv | archiveurl=http://www.webcitation.org/5yo0HaAk7 |archivedate=19 May 2011| deadurl=no }}
"London, United Kingdom Forecast : Weather Underground (weather and elevation at Heathrow Airport)". The Weather Underground, Inc. Archived from the original on 19 May 2011. {{cite web}}: Invalid |ref=harv (help); Unknown parameter |deadurl= ignored (|url-status= suggested) (help)
"London, United Kingdom Forecast : Weather Underground (weather and elevation at Heathrow Airport)". The Weather Underground, Inc. Archived from the original on 19 May 2011. {{cite web}}: Invalid |ref=harv (help); Unknown parameter |deadurl= ignored (|url-status= suggested) (help)

-- WOSlinker (talk) 22:34, 19 February 2013 (UTC)Reply

No warning if archiveurl specified and archivedate is not

  • {{Cite web |url=http://www.wunderground.com/global/stations/03772.html |title=London, United Kingdom Forecast : Weather Underground (weather and elevation at Heathrow Airport) |publisher=The Weather Underground, Inc. |ref=harv | archiveurl=http://www.webcitation.org/5yo0HaAk7 |deadurl=no }}
"London, United Kingdom Forecast : Weather Underground (weather and elevation at Heathrow Airport)". The Weather Underground, Inc. {{cite web}}: |archive-url= requires |archive-date= (help); Invalid |ref=harv (help); Unknown parameter |deadurl= ignored (|url-status= suggested) (help)
"London, United Kingdom Forecast : Weather Underground (weather and elevation at Heathrow Airport)". The Weather Underground, Inc. {{cite web}}: |archive-url= requires |archive-date= (help); Invalid |ref=harv (help); Unknown parameter |deadurl= ignored (|url-status= suggested) (help)

-- WOSlinker (talk) 22:34, 19 February 2013 (UTC)Reply

Anchors

{{Citation}} creates an anchor by default, where Citation Style 1 template create them only when |ref= is set. {{Citation/lua}} does not create the anchor by default. None of the Lua templates create the |ref=harv anchor properly: the year is missing. --— Gadget850 (Ed) talk 20:00, 20 February 2013 (UTC)Reply

No printonly URL

First difference I've spotted is {{Cite web}} has a <span class="printonly"> tag for urls but this is not included in {{Cite web/lua}}. (Copied from Template talk:Citation/core)

Compare

no normal visible difference but the html sources are considerable different

<span class="citation web"><a rel="nofollow" class="external text" href="http://mha.nic.in/docs/BM_Intro(E).doc">"Ministry of Home Affairs (Department of Border Management)"</a> (DOC)<span class="printonly">. <a rel="nofollow" class="external free" href="http://mha.nic.in/docs/BM_Intro(E).doc">http://mha.nic.in/docs/BM_Intro(E).doc</a></span><span class="reference-accessdate">. Retrieved 1 September 2008</span>.</span>.

<span class="citation web"><a rel="nofollow" class="external text" href="http://mha.nic.in/docs/BM_Intro(E).doc">"Ministry of Home Affairs (Department of Border Management)"</a> (DOC). Retrieved 1 September 2008.</span><span class="Z3988" title="ctx_ver=Z39.88-2004&rft_id=http%3A%2F%2Fmha.nic.in%2Fdocs%2FBM_Intro%28E%29.doc&rft_val_fmt=info%3Aofi%2Ffmt%3Akev%3Amtx%3A&rft.genre=book&rft.btitle=Ministry+of+Home+Affairs+%28Department+of+Border+Management%29&rfr_id=info:sid/en.wikipedia.org:User:Salix alba/sandbox" style="display: none;"> </span>. The latter has the CoiNS but no printonly.--Salix (talk): 20:07, 20 February 2013 (UTC)Reply

Is that really needed? When I try a print preview in both Firefox & IE, the current cite web version shows the URL twice. With the lua version, it only shows the URL once. Does it need to be shown twice for the printed version? -- WOSlinker (talk) 20:19, 20 February 2013 (UTC)Reply
It seems that it might not be, there is a css rule for the a.external.text class which inserts the url and the printonly span duplicates this behaviour commonPrint.css.
@media print
    #content a.external.text:after,
    #content a.external.autonumber:after {
        /* Expand URLs for printing */
	        content: " (" attr(href) ") ";
    }

Looks like this is a bug in {{Citation/core}}. However it does require the user agent can work with the :after css tag. --Salix (talk): 22:33, 20 February 2013 (UTC)Reply

reference-accessdate class

The access date should be wrapped in <span class="reference-accessdate">...</span> allowing readers to hide the access date as desired.


Markup Renders as
{{cite web|title=Ministry of Home Affairs (Department of Border Management)|url=http://mha.nic.in/docs/BM_Intro(E).doc|format=DOC|accessdate=1 September 2008}}

"Ministry of Home Affairs (Department of Border Management)" (DOC). Retrieved 1 September 2008.

'"`UNIQ--templatestyles-00000021-QINU`"'<cite class="citation web cs1">[http://mha.nic.in/docs/BM_Intro(E).doc "Ministry of Home Affairs (Department of Border Management)"] <span class="cs1-format">(DOC)</span><span class="reference-accessdate">. Retrieved <span class="nowrap">1 September</span> 2008</span>.</cite><span title="ctx_ver=Z39.88-2004&rft_val_fmt=info%3Aofi%2Ffmt%3Akev%3Amtx%3Abook&rft.genre=unknown&rft.btitle=Ministry+of+Home+Affairs+%28Department+of+Border+Management%29&rft_id=http%3A%2F%2Fmha.nic.in%2Fdocs%2FBM_Intro%28E%29.doc&rfr_id=info%3Asid%2Fen.wikipedia.org%3AModule+talk%3ACitation%2FCS1" class="Z3988"></span>

{{cite web/lua|title=Ministry of Home Affairs (Department of Border Management)|url=http://mha.nic.in/docs/BM_Intro(E).doc|format=DOC|accessdate=1 September 2008}}

"Ministry of Home Affairs (Department of Border Management)" (DOC). Retrieved 1 September 2008.

'"`UNIQ--templatestyles-00000025-QINU`"'<cite class="citation web cs1">[http://mha.nic.in/docs/BM_Intro(E).doc "Ministry of Home Affairs (Department of Border Management)"] <span class="cs1-format">(DOC)</span><span class="reference-accessdate">. Retrieved <span class="nowrap">1 September</span> 2008</span>.</cite><span title="ctx_ver=Z39.88-2004&rft_val_fmt=info%3Aofi%2Ffmt%3Akev%3Amtx%3Abook&rft.genre=unknown&rft.btitle=Ministry+of+Home+Affairs+%28Department+of+Border+Management%29&rft_id=http%3A%2F%2Fmha.nic.in%2Fdocs%2FBM_Intro%28E%29.doc&rfr_id=info%3Asid%2Fen.wikipedia.org%3AModule+talk%3ACitation%2FCS1" class="Z3988"></span>

--— Gadget850 (Ed) talk 20:26, 20 February 2013 (UTC)Reply

Separators

The biggest visible difference between {{citation}} and the CS1 templates is that citation uses a comma as a separator by default, while the CS1 ones use a period; this can be changed by the |separator= parameter. However, {{citation/lua}} always uses a period, and ignores the separator parameter. This should be fixed to match the existing templates. Another closely related problem is that {{citation/lua}} currently adds a spurious period after the issue number of a journal paper; e.g.

{{citation/lua | last1 = Benjamin | first1 = Arthur T. | author1-link = Arthur T. Benjamin | last2 = Orrison | first2 = M. E. | title = Two quick combinatorial proofs of <math>\scriptstyle \sum k^3 = {n+1\choose 2}^2</math> | journal = [[College Mathematics Journal]] | year = 2002 | volume = 33 | issue = 5 | pages = 406–408 | url = http://www.math.hmc.edu/~orrison/research/papers/two_quick.pdf}}.
Benjamin, Arthur T.; Orrison, M. E. (2002), "Two quick combinatorial proofs of  " (PDF), College Mathematics Journal, 33 (5): 406–408

renders as "College Mathematics Journal 33 (5).: 406–408". It should not have the period between the "(5)" and the following colon, and the periods after the publication year and the article title should both be commas. —David Eppstein (talk) 21:13, 20 February 2013 (UTC)Reply

  • Reworking to handle separator: It will take a few days to fix all dots, but I will change each dot "." to allow comma when {citation} or separator=c as Lua variable "sepc". The parameters for AuthorSep and AuthorNameSep are already used. -Wikid77 22:46, 20 February 2013 (UTC)Reply

OCLC

The OCLC identifier link needs be updated from Online Computer Library Center to OCLC to reflect their name change. --— Gadget850 (Ed) talk 21:21, 20 February 2013 (UTC)Reply

Empty url parameter

that is leaves a trailing [ ]. The authorlink suggests that link and url parameters that are empty are still being actioned, rather than ignored. RDBrown (talk) 21:51, 20 February 2013 (UTC)Reply

  • Fix in progress. I think I found the Lua code to fix, for person.link ~= "" to bypass any empty authorlink or editorlink. We also need to ignore any empty "author=" to use "last=xx" instead. -Wikid77 22:46, 20 February 2013 (UTC)Reply

Some tests

Here's a test for various other empty params -- WOSlinker (talk) 23:05, 20 February 2013 (UTC)Reply

  • cite web: "title". {{cite web}}: Cite has empty unknown parameters: |booktitle=, |args.conferenceurl=, |chapterlink=, |deadurl=, |laydate=, |subscription=, |titlelink=, |trans_title=, |ASIN-TLD=, |transcript=, |editorformat=, |laysource=, |laysummary=, |publicationdate=, |coauthor=, |conference=, |editors=, |transcripturl=, |editormask=, |doi_inactivedate=, |trans_chapter=, and |chapterurl= (help); Missing or empty |url= (help)
  • cite web/lua: "title". {{cite web}}: Cite has empty unknown parameters: |booktitle=, |args.conferenceurl=, |chapterlink=, |deadurl=, |laydate=, |subscription=, |titlelink=, |trans_title=, |ASIN-TLD=, |transcript=, |editorformat=, |laysource=, |laysummary=, |publicationdate=, |coauthor=, |conference=, |editors=, |transcripturl=, |editormask=, |doi_inactivedate=, |trans_chapter=, and |chapterurl= (help); Missing or empty |url= (help)


Here's a test for output checking. Doesn't need to be exactly the same but should be similar. -- WOSlinker (talk) 23:10, 20 February 2013 (UTC)Reply

  • cite web: [20 "title"]. 14. 24 (19). 25 (in 41). 2 (32 ed.). 33: 34 (published 7). 39. 9 [8]. p. 28. arXiv:44. ASIN 45. Bibcode:47. doi:48. ISBN 51. ISSN 52. JFM 53. JSTOR 54. LCCN 55. MR 0000056. OCLC 57. OL 58. OSTI 59. PMC 60. PMID 61. RFC 62. SSRN 63. Zbl 64. 50. Archived from [21 the original] (42) on 38. Retrieved 37 – via 36. 65 {{cite web}}: |chapter= ignored (help); Check |archiveurl= value (help); Check |arxiv= value (help); Check |asin= value (help); Check |bibcode= length (help); Check |doi= value (help); Check |isbn= value: length (help); Check |issn= value (help); Check |jfm= value (help); Check |lccn= value (help); Check |ol= value (help); Check |osti= value (help); Check |ssrn= value (help); Check |url= value (help); Check |zbl= value (help); Check date values in: |year=, |accessdate=, |date=, |publicationdate=, |archivedate=, and |year= / |date= mismatch (help); More than one of |pp= and |pages= specified (help); More than one of |pp=, |pages=, |at=, and |page= specified (help); Unknown parameter |ASIN-TLD= ignored (|asin-tld= suggested) (help); Unknown parameter |args.conferenceurl= ignored (help); Unknown parameter |booktitle= ignored (help); Unknown parameter |chapterlink= ignored (help); Unknown parameter |deadurl= ignored (|url-status= suggested) (help); Unknown parameter |laydate= ignored (help); Unknown parameter |subscription= ignored (|url-access= suggested) (help); Unknown parameter |titlelink= ignored (|title-link= suggested) (help); Unknown parameter |trans_title= ignored (|trans-title= suggested) (help)CS1 maint: ___location (link) CS1 maint: others (link) CS1 maint: unrecognized language (link) CS1 maint: year (link)
  • cite web/lua: [20 "title"]. 14. 24 (19). 25 (in 41). 2 (32 ed.). 33: 34 (published 7). 39. 9 [8]. p. 28. arXiv:44. ASIN 45. Bibcode:47. doi:48. ISBN 51. ISSN 52. JFM 53. JSTOR 54. LCCN 55. MR 0000056. OCLC 57. OL 58. OSTI 59. PMC 60. PMID 61. RFC 62. SSRN 63. Zbl 64. 50. Archived from [21 the original] (42) on 38. Retrieved 37 – via 36. 65 {{cite web}}: |chapter= ignored (help); Check |archiveurl= value (help); Check |arxiv= value (help); Check |asin= value (help); Check |bibcode= length (help); Check |doi= value (help); Check |isbn= value: length (help); Check |issn= value (help); Check |jfm= value (help); Check |lccn= value (help); Check |ol= value (help); Check |osti= value (help); Check |ssrn= value (help); Check |url= value (help); Check |zbl= value (help); Check date values in: |year=, |accessdate=, |date=, |publicationdate=, |archivedate=, and |year= / |date= mismatch (help); More than one of |pp= and |pages= specified (help); More than one of |pp=, |pages=, |at=, and |page= specified (help); Unknown parameter |ASIN-TLD= ignored (|asin-tld= suggested) (help); Unknown parameter |args.conferenceurl= ignored (help); Unknown parameter |booktitle= ignored (help); Unknown parameter |chapterlink= ignored (help); Unknown parameter |deadurl= ignored (|url-status= suggested) (help); Unknown parameter |laydate= ignored (help); Unknown parameter |subscription= ignored (|url-access= suggested) (help); Unknown parameter |titlelink= ignored (|title-link= suggested) (help); Unknown parameter |trans_title= ignored (|trans-title= suggested) (help)CS1 maint: ___location (link) CS1 maint: others (link) CS1 maint: unrecognized language (link) CS1 maint: year (link)

Issues in cite conference and corresponding citation

The {{citation}} template

{{citation | last1 = Alon | first1 = N. | author1-link = Noga Alon | last2 = Caro | first2 = Y. | contribution = On the number of subgraphs of prescribed type of planar graphs with a given number of vertices | editor1-last = Rosenfeld | editor1-first = M. | editor2-last = Zaks | editor2-first = J. | isbn = 978-0-444-86571-7 | mr = 0791009 | pages = 25–36 | publisher = Elsevier | series = Annals of Discrete Mathematics 20, North-Holland Mathematical Studies 87 | title = Convexity and Graph Theory: proceedings of the Conference on Convexity and Graph Theory, Israel, March 1981 | year = 1984}}

produces

Alon, N.; Caro, Y. (1984), "On the number of subgraphs of prescribed type of planar graphs with a given number of vertices", in Rosenfeld, M.; Zaks, J. (eds.), Convexity and Graph Theory: proceedings of the Conference on Convexity and Graph Theory, Israel, March 1981, Annals of Discrete Mathematics 20, North-Holland Mathematical Studies 87, Elsevier, pp. 25–36, ISBN 978-0-444-86571-7, MR 0791009

When I try {{citation/lua}} instead, as

Alon, N.; Caro, Y. (1984), "On the number of subgraphs of prescribed type of planar graphs with a given number of vertices", in Rosenfeld, M.; Zaks, J. (eds.), Convexity and Graph Theory: proceedings of the Conference on Convexity and Graph Theory, Israel, March 1981, Annals of Discrete Mathematics 20, North-Holland Mathematical Studies 87, Elsevier, pp. 25–36, ISBN 978-0-444-86571-7, MR 0791009

I see two severe problems: the |contribution= (the title of the paper) is entirely missing, and the semicolon separating the editor name is missing. As more minor issues, although you have fixed many of the dots already (thanks!) there is still one between the page numbers and ISBN, and the commas after the publisher and between the ISBN and MR are missing. By the way, the {{cite conference}} version of this citation,

Alon, N.; Caro, Y. (1984). "On the number of subgraphs of prescribed type of planar graphs with a given number of vertices". In Rosenfeld, M.; Zaks, J. (eds.). Convexity and Graph Theory: proceedings of the Conference on Convexity and Graph Theory, Israel, March 1981. Annals of Discrete Mathematics 20, North-Holland Mathematical Studies 87. Elsevier. pp. 25–36. ISBN 978-0-444-86571-7. MR 0791009. {{cite conference}}: Unknown parameter |booktitle= ignored (|book-title= suggested) (help)

has long had a problem where the period after the editor initial is doubled. There doesn't seem to currently be a {{cite conference/lua}} template, but when that one gets done I hope that it can fix this old bug. —David Eppstein (talk) 00:36, 21 February 2013 (UTC)Reply