Module talk:Sports table
Sorting
Is sorting based on class_rules or is that just never used? 2014–15_BeNe_League#League_table does not sort first 3 places correctly. -Koppapa (talk) 06:47, 10 October 2014 (UTC)
- I get it now. There is no sorting at all. Positions are set by team1=... and so on. -Koppapa (talk) 09:24, 10 October 2014 (UTC)
- Yes, that's correct, I followed the standings on the BeNe League website, but it's easy enough to change. Hopefully you find the new format easy to understand and edit. CRwikiCA talk 13:50, 10 October 2014 (UTC)
- An easy way to get around this confusion is to add comments in the table, such as <!-- Team positions --> above team1, team2 parameters and so on to explain what each section does and what the parameters are for (as many users dont read documentation). QED237 (talk) 14:31, 10 October 2014 (UTC)
- That could be a solution yes. CRwikiCA talk 15:11, 10 October 2014 (UTC)
- An easy way to get around this confusion is to add comments in the table, such as <!-- Team positions --> above team1, team2 parameters and so on to explain what each section does and what the parameters are for (as many users dont read documentation). QED237 (talk) 14:31, 10 October 2014 (UTC)
- Yes, that's correct, I followed the standings on the BeNe League website, but it's easy enough to change. Hopefully you find the new format easy to understand and edit. CRwikiCA talk 13:50, 10 October 2014 (UTC)
Head-to-head results
@CRwikiCA: The documentation seems to indicate that notes entered in |hth_TTT= will appear in the points column, but nothing shows up in the example or in my sandbox. -- Jkudlick (talk) 17:58, 4 November 2014 (UTC)
- Something went wrong when implementing the option to create different styles of tables. I'll try to find the issue and let you know when it's fixed.CRwikiCA talk 19:01, 4 November 2014 (UTC)
- @Jkudlick: I reverted the live version, so the functionality works now. I will resolve the issue in the sandbox and then bring it to the live version once it fully works. CRwikiCA talk 19:12, 4 November 2014 (UTC)
- I now resolved the issue and implemented it in the live version. CRwikiCA talk 19:26, 4 November 2014 (UTC)
- Awesome. Great work! -- Jkudlick (talk) 14:58, 5 November 2014 (UTC)
- I now resolved the issue and implemented it in the live version. CRwikiCA talk 19:26, 4 November 2014 (UTC)
- @Jkudlick: I reverted the live version, so the functionality works now. I will resolve the issue in the sandbox and then bring it to the live version once it fully works. CRwikiCA talk 19:12, 4 November 2014 (UTC)
res_col_header
For res_col_header= can you also have Comments as per 2014–15 Ukrainian First League ? Brudder Andrusha (talk) 05:28, 7 November 2014 (UTC)
- @Brudder Andrusha: Yes, see reply at WT:FOOTY:
| Pos | Team | Pld | W | D | L | GF | GA | GD | Pts | Comments |
|---|---|---|---|---|---|---|---|---|---|---|
| 1 | FIFA World Cup Dream Team | 5 | 5 | 0 | 0 | 10 | 0 | +10 | 15 | New |
It can be customized that way, although you might want to indicate the new status with footnotes instead:
| Pos | Team | Pld | W | D | L | GF | GA | GD | Pts | Qualification or relegation |
|---|---|---|---|---|---|---|---|---|---|---|
| 1 | FIFA World Cup Dream Team[a] | 5 | 5 | 0 | 0 | 10 | 0 | +10 | 15 | 1974 FIFA World Cup |
| 2 | Team 2 | 5 | 3 | 1 | 1 | 3 | 2 | +1 | 10 | |
| 3 | Team 3[b] | 5 | 3 | 0 | 2 | 3 | 3 | 0 | 9 | |
| 4 | DDD[a] | 5 | 1 | 1 | 3 | 1 | 4 | −3 | 4 | |
| 5 |  Gibraltar
|
5 | 0 | 0 | 5 | 0 | 6 | −6 | 0 |
Notes:
I hope this answers your questions. CRwikiCA talk 15:17, 7 November 2014 (UTC)
Passing parameters via template calls
Would it be possible to write the code to allow for parameter values to be passed via template call? I'm specifically thinking of |only_pld_pts=, which is presently coded so that a truncated table is displayed if called (even if no value is assigned). If you look at the UEFA Group Stage tables on the 2015 WWC qual article you can see that the tables are truncated to fit better in the article, but the tables are full size on the main UEFA article and on each of the group articles. Could the coding for |only_pld_pts= be changed to require a specific yes or true value to activate? If that can be done, would passing the value via the template call be possible, e.g. set |only_pld_pts={{{trunc}}} in the module and call {{2015 FIFA Women's World Cup Group A table|trunc=true}}? -- Jkudlick (talk) 12:38, 7 November 2014 (UTC)
- @Jkudlick:This would be possible, do you want me to implement it for the group A to see whether my idea works? I think having values yes, y, true, t and 1 (independent of case) would catch all options, or should there be more options? CRwikiCA talk 15:21, 7 November 2014 (UTC)
- @CRwikiCA:Those options should be enough. If you want to test it on Group A, I have no problem with that. -- Jkudlick (talk) 15:37, 7 November 2014 (UTC)
@Jkudlick: Done: Template:2015 FIFA Women's World Cup Group A table Template:2015 FIFA Women's World Cup Group A table I kept the same parameter name to keep it easier to follow if people end up reading the Lua code. CRwikiCA talk 17:29, 7 November 2014 (UTC)
- You rock! -- Jkudlick (talk) 17:33, 7 November 2014 (UTC)
Last updated and source
I would be in favour of this being changed to <small> text, in line with some of the other templates used on football pages (I'm not aware for other sports), such as Template:Fb rs (footer is at Template:Fb rs footer). I don't know if there's any guidelines or policies on the use of small text here, but I'd be in favour of a change. - 97rob (talk) 17:51, 6 December 2014 (UTC)
- Using <small></small> in table footers is likely a violation of MOS:FONTSIZE, thus the reason the footers in the module are not as small as many editors are accustomed to. -- Jkudlick tcs 18:28, 6 December 2014 (UTC)
- The size was indeed brought up in one of the discussions leading up to the introduction of the module. It is now set at the user-defined reference list size, which has 90% as default. Some small text on Wikipedia does indeed seem to violate MOS:FONTSIZE. CRwikiCA talk 20:38, 6 December 2014 (UTC)
About other sports
As this module is called "Sports table", are you going to prepare it for other sports (e.g., deleting the draws column for basketball, different point criteria at rugby union or volleyball, etc)? Great job, btw. Asturkian (talk) 11:42, 16 December 2014 (UTC)
- @Asturkian: That is the idea, when it has been rolled out to the football project and everything is working well (no errors) the plan is to spread the module to other sports as well. For example the table is currently called with
|style=footballbut also|style=WL OTworks (mainly as test) which is for tables without draw and has overtime wins (OTW) and overtime loss (OTL) instead (those names can be changed to i.e. shootout). The columns are decided in submodules (for example Module:Sports table/football or Module:Sports table/WL OT). I can give you example of thos kind of table. - For
|style=footballwe get
| Pos | Team | Pld | W | D | L | GF | GA | GD | Pts |
|---|---|---|---|---|---|---|---|---|---|
| 1 | FIFA World Cup Dream Team | 5 | 5 | 0 | 0 | 10 | 0 | +10 | 15 |
| 2 | Team 2 | 5 | 3 | 1 | 1 | 3 | 2 | +1 | 10 |
| 3 | Team 3 | 5 | 3 | 0 | 2 | 3 | 3 | 0 | 9 |
| 4 | DDD | 5 | 1 | 1 | 3 | 1 | 4 | −3 | 4 |
| 5 | Team 4 | 5 | 0 | 0 | 5 | 0 | 6 | −6 | 0 |
- For
|style=WL OTwe get
| Pos | Team | Pld | W | OTW | OTL | L | GF | GA | GD | Pts |
|---|---|---|---|---|---|---|---|---|---|---|
| 1 | FIFA World Cup Dream Team | 5 | 5 | 0 | 0 | 0 | 10 | 0 | +10 | 15 |
| 2 | Team 2 | 5 | 3 | 0 | 1 | 1 | 3 | 2 | +1 | 10 |
| 3 | Team 3 | 5 | 3 | 0 | 0 | 2 | 3 | 3 | 0 | 9 |
| 4 | DDD | 5 | 1 | 1 | 0 | 3 | 1 | 4 | −3 | 5 |
| 5 | Team 4 | 5 | 0 | 0 | 0 | 5 | 0 | 6 | −6 | 0 |
So as you see there are already ways to make new tables and there is plan to expand, just taking it one step at the time and start at football to see if any issues comes up. QED237 (talk) 13:56, 16 December 2014 (UTC)
- @Asturkian: When I have some time, I plan to generalize the documentation to make it easier for people to create sport specific versions. The module is created with sub-modules, so it should be relatively easy to change the columns (and their headings) for specific sports while keeping all the advanced options that are created by the core of the module. I don't think I have time for that until mid January, that should also lead to enough time to iron out the last issues that will come up from implementing the module in various football articles. One more major issues is to generally be able to switch between goals for/against/diff to points for/against/diff to reduce the need for a multitude of style modules that are almost identical. CRwikiCA talk 17:14, 16 December 2014 (UTC)
Adjust points
@Jkudlick and LRD NO: Based on the December discussion I reworded |adjust_points_TTT= for points adjustments (while leaving the old startpoints option in, but removing it from the documentation). CRwikiCA talk 20:25, 9 January 2015 (UTC)
- Cheers, CR. Top work as always. LRD 22:57, 9 January 2015 (UTC)
- Great work. This is definitely more intuitive. — Jkudlick tcs 01:34, 11 January 2015 (UTC)