Module talk:RoundN

This is an old revision of this page, as edited by Codehydro (talk | contribs) at 12:49, 24 March 2015 (More compact). The present address (URL) is a permanent link to this revision, which may differ significantly from the current revision.

Latest comment: 10 years ago by Codehydro in topic More compact
  • @Mr Stradivarius and Jackmcbarn: - Would you guys please take a look at this? As this is my third module, the module could probably benefit from your experienced eyes to spot potential bugs and ideas for improving the new features. The rendering of {{Round16}} and {{Round8}} are nearly identical, I think; I have not attempted to emulate the spacing of {{Round2}} and {{Round4}} but I don't see a good reason to display them exactly as long as the information conveyed is the same... perhaps those templates would benefit from standardization/a more compact form? What do you think? —CodeHydro 02:26, 2 January 2015 (UTC)Reply

Byes

Two byes to a match leave a black line to the next round, see

 
Quarter-finalsSemi-finalsFinal
 
          
 
 
 
 
Day 2
 
 
C
 
 
D
 
 
tdb
 
 
A
 
tdb
 
 
 
A
 
tdb
 
 
 
A
 
Day 1
 
 
 
A7
 
 
B5
 

-Koppapa (talk) 11:25, 6 January 2015 (UTC)Reply

  Done @Koppapa: Ha, I had actual set up my code to detect when both matches are skipped so I could remove the line. Silly me forgot to implement it! Good catch! Anyhow, while I was at it, I came up with a neat shorthand for skipmatch and also extended it beyond the first round. See Module talk:RoundN/testcases/3. Thanks again! —CodeHydro 03:44, 8 January 2015 (UTC)Reply

Comments

@Codehydro: It looks quite good to me. I haven't seen, that somebody would use colors, but ok - as a feature it is ok. You could get some input from WT:FOOTIE, as those templates are usually used by them. --Edgars2007 (talk/contribs) 09:15, 3 January 2015 (UTC)Reply

Please read before asking for seeds

RoundN is intended to replace templates like Template:Round16 which never used seeds. For seeds, use Module:TeamBracket. While it's hardly a challenge to add them, my thinking is that adding a check for seeds is more of a performance drag than helpful since there is already a module that supports them. As much as I want to make accommodate every possible need, the fact is too many features will slow down the module. Slow module = more servers resources used = more ad campaigns for donations = less pleasant wiki and slower page loads. Yes, this module does fancy things that Team bracket currently can't, like auto-bolding and score-summing, but these features save server resources because the mediawiki engine no longer has to parse wikibold markup in each parameter and Lua is more efficient at string processing. (If you want these features with seeds, let TeamBracket's programmers know that they may use RoundN's score cleaning/processing functions by adding require('Module:RoundN').scoreWasher to their code.) —CodeHydro 17:08, 27 January 2015 (UTC)Reply

More compact

Could it be possible to reduce a line the distance between the title of the rounds and the first match box? There is too much space between both. Asturkian (talk) 08:00, 29 January 2015 (UTC)Reply

BTW, you should add in the documentation, the information about |score-boxes= and the possibility of 2+sum. Asturkian (talk) 09:09, 29 January 2015 (UTC)Reply

@Asturkian: Sorry for the delayed respond. I didn't see the question until just now. I'm assuming you've left the date/place box blank, which would make it appear as though there were a big gap between the title and the first match. A simple work around could be to put an empty span tag <span /> as the first date parameter, which would minimize the size of the first date row. As for documenting the +sum switch, that is a beta feature which is not officially released. The documentation will be updated when Beta goes live. —CodeHydro 12:49, 24 March 2015 (UTC)Reply
@Codehydro: How does the score-boxes parameter work? QED237 (talk) 16:20, 23 March 2015 (UTC)Reply
@Qed237: Though I hate to do this, I must hold off on explaining it until the official release of Beta. Been working on a higher priority project so I haven't even touched RoundN since January (RoundN is expected to be used on a few thousand pages at most; the higher priority module is used on 2 million pages). Sorry, but, for now, you'll have to make do by studying Module talk:RoundN/testcases/4, Module talk:RoundN/testcases/5, and Module talk:RoundN/testcases/6 on your own. Very overwhelmed with work lately... and though I'm pretty fast at writing code, I'm awful slow when it comes to explaining it. (In fact, Beta has been 95% ready, but just updating the doc page would probably take me a couple of weeks... and it's probably going to be a while before I even get back to RoundN). —CodeHydro 12:49, 24 March 2015 (UTC)Reply

Chess

Used it here. It bolds ½ over 1½. Is there a way to change that automatically? Or is manually bolding the way to go? If non-numbers are removes, shouldn't be 1 be bold over nothing? -Koppapa (talk) 17:07, 17 March 2015 (UTC)Reply