Module talk:IPAddress
 | This module was considered for deletion on 2018 July 1. The result of the discussion was "keep". |
isIp
Takes a single argument, a string, and returns:
- "6" if it is a valid IPV6 address
- "4" if it is a valid IPV6 address
- empty string if it is neither.
When applied to {{PAGENAME}}, this helps determine whether a template is being placed on an anonymous user page/user talk page or not, as used in Template:AfC talk:
{{#if:{{IsIPAddress|{{PAGENAME}}}}|I'm on an anonymous IP user or user talk page|I'm on some other page}}
Note that extra whitespace is not permitted (e.g. "127.0.0.1 " with an extra space at the end is not a valid IP address).
isIpV6
Returns 1 if the given argument is a valid IPv6 address, else 0.
isIpV4
Returns 1 if the given argument is a valid IPv4 address, else 0.
More than 3 digits in a group
Is '00000000000005.10.10.10' a correct IPv4 address? --DixonD (talk) 07:53, 8 March 2013 (UTC)
- good question. it's not so much about "more than 3 digits" as it's about leading zeroes: is 12.02.4.4 legal? how about 12.00.4.4? what are the rules?
- current code allows those, as well as 1.00000000100.2.2, i.e, any number can be preceded by any number of 0's. it's relatively easy to disallow. from Dot-decimal notation#Caveat it can be concluded that preceding with 0's is not a good idea, and can lead to confusion- this may be interpreted sometimes to mean "octal". should i change the code to disallow? should we add it to the tests? peace - קיפודנחש (aka kipod) (talk) 09:06, 8 March 2013 (UTC)
- Yes, I think it is better to disallow. I would change the regexp from "^(%d+)%.(%d+)%.(%d+)%.(%d+)$" to something like "^(%d{1,3})%.(%d{1,3})%.(%d{1,3})%.(%d{1,3})$". --DixonD (talk) 12:11, 8 March 2013 (UTC)
- technically, what you suggest is not viable, because lua's string comparison is not real regex, and specifically, there's no support for quantifiers in curlies. It would also still allow 000 or 020 etc., which should also be disallowed. However, as i mentioned, the solution is not difficult. --קיפודנחש (aka kipod) (talk) 14:11, 8 March 2013 (UTC)
- i did it the way i thought is right, i.e., disallow leading 0 (i.e., 0 is OK, but 02 or 00 is not). this cause one test to fail, for the string "00.00.00.00". not sure if this should fail (your answer above indicate you think it should), in which case we need to modify the test, or maybe it should pass, in which case we should modify the code. wither is easy. can someone point to an authoritative source that explains which of the following (if any) is legal?
- technically, what you suggest is not viable, because lua's string comparison is not real regex, and specifically, there's no support for quantifiers in curlies. It would also still allow 000 or 020 etc., which should also be disallowed. However, as i mentioned, the solution is not difficult. --קיפודנחש (aka kipod) (talk) 14:11, 8 March 2013 (UTC)
- Yes, I think it is better to disallow. I would change the regexp from "^(%d+)%.(%d+)%.(%d+)%.(%d+)$" to something like "^(%d{1,3})%.(%d{1,3})%.(%d{1,3})%.(%d{1,3})$". --DixonD (talk) 12:11, 8 March 2013 (UTC)
00.00.00.00 000000012.13.14.15 012.13.14.15 01.02.03.04
- if no authoritative source can be found, your opinion will be appreciated anyway. also, is there past behavior we should emulate, regardless of "what's right"? thanks. peace - קיפודנחש (aka kipod) (talk) 16:37, 8 March 2013 (UTC)
- Ping in Ubuntu treats numbers starting with 0 as octal numbers. 012.13.14.15 is legal (actually in decimal: 10.13.14.15), but 08.8.8.8 is not valid (8 is not octal number). --Harriv (talk) 19:14, 16 March 2013 (UTC)
- if no authoritative source can be found, your opinion will be appreciated anyway. also, is there past behavior we should emulate, regardless of "what's right"? thanks. peace - קיפודנחש (aka kipod) (talk) 16:37, 8 March 2013 (UTC)
Requested move 13 July 2018
 | It has been proposed in this section that Module:IPAddress be renamed and moved to Module:Validate IP. A bot will list this discussion on the requested moves current discussions subpage within an hour of this tag being placed. The discussion may be closed 7 days after being opened, if consensus has been reached (see the closing instructions). Please base arguments on article title policy, and keep discussion succinct and civil. Please use {{subst:requested move}}. Do not use {{requested move/dated}} directly. |
Module:IPAddress → Module:Validate IP – Clearer module name; the current one is not meaningfully distinct from Module:IP {{3x|p}}ery (talk) 21:16, 13 July 2018 (UTC)
- Support: Module names should be even more accurately descriptive than template ones, since we do not need module names to be excessively concise for repeated typing in wikisource. — SMcCandlish ☏ ¢ 😼 22:33, 13 July 2018 (UTC)
- Oppose The term "IP" has no immediately clear meaning and "Validate IP" might mean anything—"Address" is needed for context and preciseness. "Validate IP Address" would be silly. This is a make-work proposal with no benefit. Despite the MfD there is no reason to dictate what this module might do in the future by giving it a one-function-only title. Johnuniq (talk) 00:00, 14 July 2018 (UTC)
- +1. also note all the interwiki. we do not yet have central (a la common) modules, so every interwiki is a direct copy. it is tangibly better to keep the same name used by all the other wikipedias that chose to copy this module. peace - קיפודנחש (aka kipod) (talk) 03:22, 16 July 2018 (UTC)