User talk:Jack who built the house/Gadget-referenceTooltips.js
Latest comment: 6 years ago by Yair rand in topic Two minor issues
Two minor issues
- This should probably load
ext.popups.imagesfrom en.wikipedia instead of ru.wikipedia. - Using
mw.cookiewithout overriding the prefix would result in existing users losing their current settings. This could be fixed by replacingmw.cookie.get( 'RTsettings' );withmw.cookie.get( 'RTsettings', '' );and{ path: '/', expires: 90 * SECONDS_IN_A_DAY }with{ path: '/', expires: 90 * SECONDS_IN_A_DAY, prefix: '' }.
--Yair rand (talk) 17:24, 30 December 2018 (UTC)
- Yair rand, well noticed! Done. Jack who built the house (talk) 04:49, 31 December 2018 (UTC)
- @Jack who built the house: One more thing I just noticed: The extra style tags added via
mw.util.addCSSwhen the tooltip is at the right edge aren't ever removed. Instead, they keep piling up in the head every time the user hovers over a reference, even if it's the same reference twice. I recommend removing the tags rather than just disabling them once they're no longer needed, or even better, set the styles to the element directly, rather than adding a style tag which I assume would be harder on performance. --Yair rand (talk) 06:22, 31 December 2018 (UTC) - Also, the bit around line 425 should probably check whether COMMENTED_TEXT_CLASS is empty.
.alone isn't a valid selector, so it breaks the script. --Yair rand (talk) 07:08, 31 December 2018 (UTC)
- @Jack who built the house: One more thing I just noticed: The extra style tags added via
- Yair rand, hm, do settings work with the current version at all? I try to change them, only to see the same behaviour after page refresh. Jack who built the house (talk) 06:32, 31 December 2018 (UTC)