Module talk:Find sources

This is an old revision of this page, as edited by Pppery (talk | contribs) at 01:02, 31 July 2020 (Template-protected edit request on 30 July 2020: Done). The present address (URL) is a permanent link to this revision, which may differ significantly from the current revision.

Request for proper capitalization

For proper capitalization, could someone please edit Module:Find sources/templates/Find sources to change "highbeam" to "HighBeam" and "wikipedia" to "Wikipedia"? Thanks! GoingBatty (talk) 18:47, 31 January 2016 (UTC)Reply

  Donexaosflux Talk 19:08, 31 January 2016 (UTC)Reply

Google

Is there any reason that Module:Find sources/links/google sets the results per page to 50 instead of the user’s preference (or if it’s by design, why not 100)? Also, can we document the as_eq parameter with a link to say, this documentation? —LLarson (said & done) 16:33, 5 July 2016 (UTC)Reply

  Done Having waited a sufficient amount of time with no objections, I removed the 50-results-per-page parameter from the Google search. —LLarson (said & done) 03:49, 15 February 2019 (UTC)Reply

The purpose of this edit is to provide increased privacy and security for users by having the Module:Find sources/links/jstor template generate an HTTPS link to JSTOR instead of the current HTTP link. The JSTOR search URL appears to support HTTPS. In Module:Find sources/links/jstor, please change http://www.jstor.org/ to https://www.jstor.org/ instead. --Elegie (talk) 05:53, 17 May 2017 (UTC)Reply

@Elegie:   Done -- John of Reading (talk) 06:11, 17 May 2017 (UTC)Reply

Update Google Images to use new-style URL and forced HTTPS

I switched the Google Image search format string to a newer format at Module:Find sources/links/google free images/sandbox, and was hoping for it to be applied to Module:Find sources/links/google free images.

The current template uses the old-style Google image search URL format, with google.com/image?tbm=isch instead of google.com/search?tbm=isch. Currently the old format redirects to the new format, but I think it would be better to just use the new format to avoid any broken links in the future. Also, the protocol-relative URL scheme is now obsolete so I changed it to use https:// instead. If this is applied and works out I might make some similar changes to the other Google URLs. Thanks, Habst (talk) 15:04, 24 June 2018 (UTC)Reply

  Done — JJMC89(T·C) 17:25, 24 June 2018 (UTC)Reply
@Habst: Thank you for the edit request! Fixes like these are very welcome. (And of course thank you to JJMC89 for carrying it out. :) — Mr. Stradivarius ♪ talk ♪ 12:30, 25 June 2018 (UTC)Reply

Some google searches using this module have "-wikipedia" at the end

I've noticed an issue occurring with Template:Find sources mainspace that I believe originates with this module..
An example of what is occurring:
On this diff you can see Template:Article for deletion/dated at the top. The first two Find sources links search with "-wikipedia" included in the search term, which seems to negatively affect the results coming back.
I'm hoping that someone may know what is wrong so that this can be corrected.

Too complicated

This module seems to me like it is needlessly complicated. Why is it a good idea to store the configuration for each template in its own module subpage instead of in the wikitext of the template? That appears to make it harder to edit for no apparent reason. {{3x|p}}ery (talk) 02:32, 15 February 2019 (UTC)Reply

I am guessing because auto-documentation template also uses it? —  HELLKNOWZ   ▎TALK 11:33, 15 February 2019 (UTC)Reply
It would still be possible to implement autodoc even without /templates cfg pages. {{3x|p}}ery (talk) 19:59, 15 February 2019 (UTC)Reply
As I have just done. I also think that the /autodoc template config pages should also be in Wikitext and associated with the template, but it's not clear exactly where. {{3x|p}}ery (talk) 21:09, 15 February 2019 (UTC)Reply

See Wikipedia:Templates for discussion/Log/2019 February 15#Module:Find sources/templates/find sources. {{3x|p}}ery (talk) 21:54, 15 February 2019 (UTC)Reply

Template-protected edit request on 30 July 2020

Please copy Module:Find sources/sandbox to Module:Find sources. This will allow the template to generate search queries for arbitrary page titles (specified by |title=) with parenthetical disambiguators separated from the main part of the title (this is already supported for the current page title).

Please also copy Template:Afd2/sandbox to Template:Afd2, which will make use of this new parameter.

I posted a section on Wikipedia talk:Articles for deletion#Find sources and parenthetical disambiguiators proposing these changes. There has been no response in the past week. The testcases are unaffected. The change is demonstrated in one of my sandboxes. Danski454 (talk) 20:16, 30 July 2020 (UTC)Reply

  Done Please document the new parameter. * Pppery * it has begun... 01:02, 31 July 2020 (UTC)Reply