Wikipedia

Module talk:WikiProject banner/Archive 13

< Module talk:WikiProject banner
This is an old revision of this page, as edited by Lowercase sigmabot III (talk | contribs) at 04:43, 6 November 2020 (Archiving 1 discussion(s) from Template talk:WPBannerMeta) (bot). The present address (URL) is a permanent link to this revision, which may differ significantly from the current revision.

Latest comment: 4 years ago by MSGJ in topic Inactive project layout
Archive 10Archive 11Archive 12Archive 13Archive 14Archive 15Archive 16

Automatic |tf_n=yes based on |TF_n_XYZ?

Latest comment: 5 years ago7 comments3 people in discussion

If someone fills in |TF_n_XYZ= (e.g. |TF_n_QUALITY=), would it be sensible to automatically trigger |tf_n=? I feel as though if you're assigning a taskforce quality rating, that it's safe to presume that taskforce should be activated. This would be particularly helpful for the WP:RATER tool. Since any text in |tf_n= will activate the section, the template could just include the nested parameters: 

|tf_n={{yesno|{{{tf 4|{{{TF_n_LINK|{{{TF_n_NAME|{{{TF_n_NESTED|{{{TF_n_IMAGE|{{{TF_n_TEXT|{{{TF_n_QUALITY|{{{TF_n_MAIN_CAT|¬}}}}}}}}}}}}}}}}}}}}}}}}|yes|¬=¬}}

Thoughts? T.Shafee(Evo&Evo)talk 12:24, 1 May 2020 (UTC)

|TF_n_QUALITY= is set at the project template, but the |tf_n= is set at each article. The quality is just inherited from the main quality rating of that article; it is not specified for each task force. — Martin (MSGJ · talk) 07:44, 2 May 2020 (UTC)
@Evolution and evolvability: just wondering if my answer made any sense? — Martin (MSGJ · talk) 08:10, 5 May 2020 (UTC)
@MSGJ:. Woops, I meant to use Template:TF n IMP rather than |TF_n_QUALITY= as the example. Because currently, if Template:TF n isn't filled in, the template will ignore Template:TF n IMP. The template I'm working on is {{WikiProject_Molecular_Biology}}.
Example: {{WikiProject Molecular Biology |class=Stub |importance=Low |RNA-imp=high |MCB-imp=low}} returns:
Please add the quality rating to the {{WikiProject banner shell}} template instead of this project banner. See WP:PIQA for details.
 Molecular Biology Stub‑class Low‑importance
 This article is within the scope of WikiProject Molecular Biology, a collaborative effort to improve the coverage of molecular biology on Wikipedia. If you would like to participate, please visit the project page, where you can join the discussion and see a list of open tasks.Molecular BiologyWikipedia:WikiProject Molecular BiologyTemplate:WikiProject Molecular BiologyMolecular Biology
StubThis article has been rated as Stub-class on Wikipedia's content assessment scale.
LowThis article has been rated as Low-importance on the project's importance scale.
but should really return:
Please add the quality rating to the {{WikiProject banner shell}} template instead of this project banner. See WP:PIQA for details.
 Molecular Biology: Genetics / Biophysics Stub‑class Low‑importance
 This article is within the scope of WikiProject Molecular Biology, a collaborative effort to improve the coverage of molecular biology on Wikipedia. If you would like to participate, please visit the project page, where you can join the discussion and see a list of open tasks.Molecular BiologyWikipedia:WikiProject Molecular BiologyTemplate:WikiProject Molecular BiologyMolecular Biology
StubThis article has been rated as Stub-class on Wikipedia's content assessment scale.
LowThis article has been rated as Low-importance on the project's importance scale.
 
This article is supported by the Genetics task force (assessed as Low-importance).
 
This article is within the scope of the Biophysics task force, a task force which is currently considered to be inactive.
So the query is more about whether we can automatically assume |TF_n= is yes if any of the |TF_n_XYZ= parameters are filled. T.Shafee(Evo&Evo)talk 12:26, 5 May 2020 (UTC)
Ah, I understand your point now. Typically the only taskforce parameter that is set at the article level is the importance. So you are saying that if |biophysics-imp= is set to any value, then we should assume that |biophysics=yes? That would be fairly simple to implement. Are there any possible side effects of doing this? What if |biophysics-imp=cheesecake, i.e. an unrecognised value - should that trigger the taskforce as well? — Martin (MSGJ · talk) 13:38, 5 May 2020 (UTC)
On this matter, I occasionally see a parameter pair compressed into a single one. Take for instance Talk:László Szőcs - here, the {{WikiProject Football}} has |variants=mid which is not-quite invalid - it is treated as if it were |variants=yes but I suspect that the intention was |variants=yes|variants-importance=mid. --Redrose64 🌹 (talk) 20:51, 13 May 2020 (UTC)
I've not need that before, but it is efficient. Currently this is not recognised by the template, but it might be logical to make the taskforce importance default to the value of the taskforce activiation parameter? — Martin (MSGJ · talk) 06:18, 14 May 2020 (UTC)

Protected edit request on 19 May 2020

Latest comment: 5 years ago3 comments2 people in discussion

Please change Template:WPBannerMeta/core to Template:WPBannerMeta/core/sandbox (+protection template) diff. This change makes it so that the JS for collapsible is initialized slightly sooner and bypasses the collapsible to mw-collapsible proxy wrapper of en.wp. —TheDJ (talk • contribs) 08:31, 19 May 2020 (UTC)

I put a test on Template:WPBannerMeta/testcases. The alignment is slightly different in the new version, but it is not an issue. — Martin (MSGJ · talk) 08:42, 20 May 2020 (UTC)
  Done no other comments so I have made the change. If the alignment change is worrying anyone we can revert/discuss — Martin (MSGJ · talk) 11:16, 22 May 2020 (UTC)

Detecting conflicts in class values

Latest comment: 5 years ago5 comments3 people in discussion

Is there a way to identify conflicts between a page's assigned class value and what would otherwise be automatically detected? E.g., a redirect or a page in the Category namespace tagged as stub-class. --Paul_012 (talk) 23:58, 9 March 2020 (UTC)

Not currently, but it would be simple enough to code on a particular project's banner — Martin (MSGJ · talk) 21:47, 10 March 2020 (UTC)
Thanks. It's not needed so much that I'd ask for an actual implementation; just something that I thought would be nice to have. --Paul_012 (talk) 14:54, 12 March 2020 (UTC)
We've only used automatic detection of a page's class value if no class is defined. (If the class is defined then this will always be used.) I think this is the right approach in general, but any project can change this default behaviour by using a custom class mask. — Martin (MSGJ · talk) 23:03, 5 May 2020 (UTC)
@MSGJ: There probably are a few other cases where it might be useful to do automatic detection. For example, if an article is in mainspace but is tagged as "Draft class", it certainly means that whoever moved it to mainspace forgot to remove that it was a draft, and it should be treated as if the class were left undefined. --Ahecht (TALK
PAGE) 21:30, 31 May 2020 (UTC)

Portal

Latest comment: 4 years ago3 comments2 people in discussion

I was just looking at the history of /core. This change looks invalid to me (incorrect syntax) so I'm not sure if it's achieving what it was meant to. — Martin (MSGJ · talk) 09:02, 6 October 2020 (UTC)

Yes, there's a misplaced pipe in one line. Instead of this: 
  {{#ifexist: Portal:{{{PORTAL|}}}|
it should have been this: 
  |{{#ifexist: Portal:{{{PORTAL|}}}
The purpose, IIRC, was to suppress the display of a redlinked portal at a time when a large number of portals were being deleted without all incoming links being removed. --Redrose64 🌹 (talk) 14:49, 6 October 2020 (UTC)
Never mind I see it was undone a few days later — Martin (MSGJ · talk) 18:25, 6 October 2020 (UTC)

Inactive project layout

Latest comment: 4 years ago35 comments5 people in discussion

The following is extremely jarring when encountered

The inactive project should be center-aligned just like the active ones. And the (Inactive) links should be at the same place as the (Raged X-class). Headbomb {t · c · p · b} 16:06, 1 October 2020 (UTC)

Okay, looks good to me. Can you code it in the sandbox? — Martin (MSGJ · talk) 16:33, 1 October 2020 (UTC)
It's something to do with Template:Inactive WikiProject banner I think. I figured someone here would know where the code was hosted and have a quick fix, but I suppose I can dig deeper. It will likely take me some time, as I don't know how this template is structured, or how it interacts with {{WPBS}}. Headbomb {t · c · p · b} 17:59, 1 October 2020 (UTC)
So far, this is looking beyond my skills. Headbomb {t · c · p · b} 18:10, 1 October 2020 (UTC)
How's that looking on your browser? — Martin (MSGJ · talk) 19:34, 1 October 2020 (UTC)
@MSGJ: looks tip top on every browser I have tried (Chrome, Firefox). Nothing displays on mobile though, but I believe that's normal behaviour. Headbomb {t · c · p · b} 19:35, 1 October 2020 (UTC)

Okay I think I'll wait for someone (is WOSlinker still around??) to check my changes to these templates:

— Martin (MSGJ · talk) 19:52, 1 October 2020 (UTC)

(If I was clever I would add the diff links, but I'm not) — Martin (MSGJ · talk) 19:53, 1 October 2020 (UTC)
@MSGJ:, the code you moved from the core to the main template needs to stay in core as the class and importance param values are normalised before being passed to the core template. See example below. -- WOSlinker (talk) 20:04, 1 October 2020 (UTC)
Ah yes, good catch. I was trying to simplify the logic in /core so I wouldn't need to work out the same thing three times! — Martin (MSGJ · talk) 20:58, 1 October 2020 (UTC)
Reverted to my previous version. Hopefully looking better now. Good to see you by the way. This is like the old days ... — Martin (MSGJ · talk) 21:00, 1 October 2020 (UTC)
Looking good now. -- WOSlinker (talk) 22:32, 1 October 2020 (UTC)
I added further testcases. Feel free to check {{WikiProject Resource Exchange}} / {{WikiProject Resource Exchange/sandbox}}. Headbomb {t · c · p · b} 02:57, 2 October 2020 (UTC)
That's the normal expected behaviour because that template doesn't do any assessments — Martin (MSGJ · talk) 07:12, 2 October 2020 (UTC)
Unless you're suggesting that every project should be right-aligned at the middle? — Martin (MSGJ · talk) 12:13, 2 October 2020 (UTC)
That is actually much easier to implement that way. How are we looking now? — Martin (MSGJ · talk) 12:23, 2 October 2020 (UTC)
Yes, Wikiproject names should always be centered in the usual style. Looks great here. Headbomb {t · c · p · b} 13:26, 2 October 2020 (UTC)

  Deployed, now just sit back and wait for the error reports to come in! — Martin (MSGJ · talk) 21:22, 2 October 2020 (UTC)

Woohoo, party time. Headbomb {t · c · p · b} 21:46, 2 October 2020 (UTC)

Couple more

There is one that still stands out, Template:MILHIST

Headbomb {t · c · p · b} 14:35, 4 October 2020 (UTC)

Milhist doesn't use this template, so can't do anything about that! — Martin (MSGJ · talk) 15:19, 4 October 2020 (UTC)
Well, it could be converted, or its html adjusted, or whatever. Headbomb {t · c · p · b} 15:23, 4 October 2020 (UTC)
Some changes in the sandbox should anyone wish to review. -- WOSlinker (talk) 16:32, 4 October 2020 (UTC)
Milhist is just one of three remaining WikiProject banners that do not use {{WPBannerMeta}}, the others being, so far as I know, {{Maths rating}} and {{WikiProject U.S. Roads}} - see Template:WPBannerMeta/Conversion. These held out against the general conversion that occurred 10+ years ago, and even though some considerable time has elapsed, these individual WikiProjects should each be asked to show their consensus before the banner is converted to WPBannerMeta (particularly so in the case of milhist which is both one of the oldest WikiProjects and one of those with the greatest activity). In all that time, the only conversions that I am aware of are {{WikiProject Tropical cyclones}} in July 2011, {{WikiProject Ships}} in August 2012, {{WikiProject Systems}} in September 2012, and {{WikiProject Anime and manga}} in August 2020 - almost eight years since the last one. --Redrose64 🌹 (talk) 19:21, 4 October 2020 (UTC)
WOSlinker's changes are a tweak to the spacing in the template, that's all — Martin (MSGJ · talk) 19:39, 4 October 2020 (UTC)
Yes, looks as though WikiProject U.S. Roads and Maths rating would need tweaking as well. -- WOSlinker (talk) 20:01, 4 October 2020 (UTC)
@Redrose64: You may want to poke in on MATHS; they're discussing that topic right now. WT:WPMATH#Proposed change to Template:Maths rating from 2018. --Izno (talk) 20:45, 4 October 2020 (UTC)
Code looks good WOSlinker. Question: because we have homogenised the display of these banners when nested, is it still necessary to use 3 columns with one empty cell? — Martin (MSGJ · talk) 20:06, 4 October 2020 (UTC)
@MSGJ: I've just removed the 3rd column in core/sandbox and it still looks ok, although the center line has moved a little. Does the hidden metadata need to be in the header or would that be better in the main description area? -- WOSlinker (talk) 20:27, 4 October 2020 (UTC)
Can't quite remember. I think it was something to fix a bug in Internet Explorer. Some related discussion at the bottom of Template talk:WPBannerMeta/Archive 6#Template:WikiProjectBoxing. I notice at the moment the second museum banner above is the best because it doesn't move sideways when uncollapsed. So you've done something right! — Martin (MSGJ · talk) 07:11, 5 October 2020 (UTC)
It still moves, just not a whole lot. Headbomb {t · c · p · b} 12:24, 5 October 2020 (UTC)
The current sandbox version with only the 2 table cells in the header seems to work ok in IE11. Also means that there's no need to update those 3 non-WPBannerMeta project banner templates. I'll wait until tommorrow incase there are any other comments and then copy into live. -- WOSlinker (talk) 07:27, 5 October 2020 (UTC)
Looks good from my perpective — Martin (MSGJ · talk) 11:56, 5 October 2020 (UTC)
Seems only US Roads and Maths need a bit of tweaking now. {{Maths rating}}/{{maths banner}} can be merged and converted to a proper {{WikiProject Mathematics}} with the current metabanner though (discussion). Headbomb {t · c · p · b} 14:31, 6 October 2020 (UTC)
I have coded a version in Template:Maths rating/sandbox sandbox and commented over there — Martin (MSGJ · talk) 12:31, 8 October 2020 (UTC)
Retrieved from "https://en.wikipedia.org/w/index.php?title=Module_talk:WikiProject_banner/Archive_13&oldid=987304273"