Module talk:Message box

(Redirected from Module talk:Message box/tmbox.css)
Latest comment: 14 hours ago by Izno in topic CSS instead of tables

Edit request 7 January 2025

edit

Description of suggested change: Currently, Template:Ambox/doc#talk says, "In order to make sure there is always a link to the talk page, you can use |talk={{{talk|#}}}." This implies that a "#" value for args.talk should just link to an article's talk page with no particular section, and several templates do this. However due to the code in Module:Message box, using just |talk=# actually creates a link with two pound signs like this: Module talk:Message box## (verified on Template:Ambox/testcases).

This type of double-hash URL actually causes errors, when I click on it I get these nonsensical messages No search results found for section "#" in archives. It may have been removed or renamed, or you may have followed a malformed link. and a popup saying This topic could not be found. It might have been deleted, moved or renamed.

I fixed it by adding a special case for "#" in Special:Diff/1268004582 and Special:Diff/1268011357, and verified functionality in the testcases.

Diff:

local talkLink = talkArgIsTalkPage and talk or (talkTitle.prefixedText .. '#' .. talk)
+
local talkLink = talkArgIsTalkPage and talk or (talkTitle.prefixedText .. (talk == '#' and '' or '#') .. talk)
'%s the [[%s#%s|talk page]].',
+
'%s the [[%s' .. (talk == '#' and '' or '#') .. '%s|talk page]].',

Thanks, --Habst (talk) 21:25, 7 January 2025 (UTC)Reply

  Done * Pppery * it has begun... 21:54, 29 January 2025 (UTC)Reply

Protected edit request on 22 March 2025

edit

Am writing to request for a page protection Brian Chira Smart boy Ke (talk) 00:51, 22 March 2025 (UTC)Reply

@Smart boy Ke:   Not done: this is the talk page for discussing improvements to the page Module:Message box. Requests for increases to a page protection level should be made at Wikipedia:Requests for page protection. --Redrose64 🌹 (talk) 07:56, 22 March 2025 (UTC)Reply

Update icons to Codex

edit

For Module:Message box/configuration Update icons to use the new Codex icons, I've colored them manually in c:Category:Wikimedia Codex icons with color, using the colors we used with near identical OOUI icons.

etc. In some cases cmbox will use different icon. waddie96 ★ (talk) 12:06, 10 August 2025 (UTC)Reply

NOTE: The current icons are licensed such that they do not need the link to work so that arribution works. These new icons are CC4 licensed, so attribution would be needed and the link= attribute would also need removing from the code if these are to be used. -- WOSlinker (talk) 12:23, 10 August 2025 (UTC)Reply
@WOSlinker Sorry, I didn't do the mass upload to c:Category:Wikimedia Codex icons with color, I requested it at Commons:Batch uploading/Wikimedia Codex icons, and I requested it be made with the appropriate license which is {{MIT License}} found in the gerrit:plugins/gitiles/design/codex/+/refs/heads/main/packages/codex-icons/LICENSE. Also in the package.json it says "license": "MIT".
Also some the icons have already been there for a few years, and marked with {{CC-by-4.0}}, mistakenly too I assume. Anyway, I marked my colourings of the icons with that too since it was a derivation.
Anyway, CC-by-4.0 is incorrect license. {{MIT License}} is the correct one. I will re-tag the ones at c:Category:Wikimedia Codex icons with color and all the ones at c:Category:Wikimedia Codex icons but the second one may take quite a while. waddie96 ★ (talk) 13:08, 10 August 2025 (UTC)Reply
MOS:PDI says that a blank |link= param - which is what we essentially do with mboxes - should not be used with CC BY-SA, GFDL, or similarly licensed images. I think that I'm right in saying that c:Template:MIT License falls within "similarly licensed images". --Redrose64 🌹 (talk) 13:24, 10 August 2025 (UTC)Reply
@Redrose64 But the same icons are implemented in the cdxMessage component in Codex, and this component is deployed on this very wiki. This component shows the exact same images (just not using our source which is Commons) from the same Gerrit repo to display or messages we see all over. The entire package/library has the GNU General Public License see gerrit:plugins/gitiles/design/codex/+/refs/heads/main/packages/codex/LICENSE. waddie96 ★ (talk) 13:49, 10 August 2025 (UTC)Reply
See Special:Version: codex-design-tokens GPL-2.0+, codex-icons MIT, codex GPL-2.0+, wikimedia/codex GPL-2.0-or-later waddie96 ★ (talk) 13:50, 10 August 2025 (UTC)Reply
@Redrose64 Also, is the use of the predecessor OOUI icons with MIT license in violation of copyright at mw:Module:Message box/configuration for example. waddie96 ★ (talk) 14:29, 10 August 2025 (UTC)Reply
Do we have consensus for these, has this change been discussed outside of this request ? Sohom (talk) 15:47, 10 August 2025 (UTC)Reply
@Redrose64 Where in the quoted policy does WP:PDI state a blank |link= param - which is what we essentially do with mboxes - should not be used with CC BY-SA, GFDL, or similarly licensed images.? I couldn't find it. waddie96 ★ (talk) 16:25, 10 August 2025 (UTC)Reply
Sorry, MOS:PDI. It's always confusing when otherwise-similar MOS: and WP: shortcuts take you to different places. --Redrose64 🌹 (talk) 16:28, 10 August 2025 (UTC)Reply
waddie96 ★ (talk) 16:39, 10 August 2025 (UTC)Reply
I've answered the edit request as   Not done for now: please establish a consensus for this alteration before using the {{Edit protected}} template. (non-admin closure) Aaron Liu (talk) 02:21, 11 August 2025 (UTC)Reply

CSS instead of tables

edit

Could this thing use <div style="display:table;"> and <div style="display:table-cell;"> instead of literal tables and table cells (<table>, <td>)?

Were the any previous attempts to remake this using <div>? If so, what was the consensus? Sapphaline (talk) 09:46, 20 August 2025 (UTC)Reply

A long time ago this would have been converted to divs but apparently IE sucked (this should not be news).
Today, I have User:Izno/Sandbox/Ambox with what are some skimmings and started a sandbox at Module:Message box/div. I have just done a very bad job of finishing this work. Izno (talk) 22:09, 24 August 2025 (UTC)Reply
Which might be closer to done than not, honestly. I think what it currently needs is to
  1. Double check the ambox work
  2. Add "soft" support for the other kinds of boxes (where soft is defined as module-supports but config disabled)
  3. Merge tested /div version but not CSS into main
  4. Enable boxes of each kind one by one.
  5. Fix bugs that are identified
  6. Move CSS over to better-named stylesheet
  7. Delete the /div CSS (I won't be too sad)
  8. Remove main support for table versions, possibly rename some things
Izno (talk) 22:42, 24 August 2025 (UTC)Reply
I have now put this plan in a publicly editable place at Module:Message box/div/doc. IznoPublic (talk) 00:26, 26 August 2025 (UTC)Reply