Template talk:Infobox NRHP
 | Template:Infobox NRHP is permanently protected from editing because it is a heavily used or highly visible template. Substantial changes should first be proposed and discussed here on this page. If the proposal is uncontroversial or has been discussed and is supported by consensus, editors may use {{edit template-protected}} to notify an administrator or template editor to make the requested edit. Usually, any contributor may edit the template's documentation to add usage notes or categories.
Any contributor may edit the template's sandbox. Functionality of the template can be checked using test cases. |
| This is the talk page for discussing improvements to the Infobox NRHP template. |
|
Archives: Index, 1, 2, 3, 4Auto-archiving period: 3 months  |
 | This template does not require a rating on Wikipedia's content assessment scale. It is of interest to the following WikiProjects: | ||||||||||||||
| |||||||||||||||
 | This template was considered for deletion on 2019 March 13. The result of the discussion was "keep". |
Index
|
||||
|
This page has archives. Sections older than 90 days may be auto-archived by Lowercase sigmabot III. |
Designation header lost color
edit
ResolvedI recently noticed that NRHP articles in New Jersey lost the orange banner color, which had been working for years. I could not find the cause. Over 1,400 articles use
- | designated_other1_name = New Jersey Register of Historic Places
- | designated_other1_abbr = NJRHP
- | designated_other1_link = New Jersey Register of Historic Places
instead of the simpler
- | designated_other1 = NJRHP
I plan to use the simpler form as I edit these articles.
Any thoughts on how to fix the templates? Thanks, Zeete (talk) 19:51, 30 April 2025 (UTC)
- Were the articles really broken, or did they just need a null edit to recover from my bad programming above? [Edited to add: No, they are really broken. See Fort Hancock and the Sandy Hook Proving Ground Historic District for example, which is showing a white background behind "New Jersey Register of Historic Places". This is the same problem I identified above with the "_name" extension to the parameter name. It looks like it used to work, but I was unable to find a code change that made it stop working.] – Jonesey95 (talk) 21:14, 30 April 2025 (UTC)
- @Jonesey95: It seems your change did not affect the loss of color. I tested using the sandbox, etc. Can not figure out where the error is, but it does not seem to be in the infobox NRHP template, and the designation template didn't seem to change. Thanks, Zeete (talk) 21:19, 30 April 2025 (UTC)
- @Jonesey95: Continuing to test: If I use Special:ExpandTemplates, the orange color comes back, but using other1=NJRHP doesn't work. If I copy a NJRHP article to my sandbox, including other1=NJRHP, preview has orange. Any thoughts? Thanks, Zeete (talk) 18:13, 1 May 2025 (UTC)
- OK, when I use ExpandTemplates and set the context to User:Foo (user namespace), the background color works and this is the resulting line: When I use ExpandTemplates and set the context to Foo (article namespace), the background color does not work and this is the resulting line:
<tr><td colspan="2" class="infobox-full-data"><div style="width:100%; text-align:center; line-height:1.5;color: #202122; background: #ffc94b">[[New Jersey Register of Historic Places|New Jersey Register of Historic Places]]</div> </td></tr>
My initial assessment is that the error-tracking category is interfering with the assignment of the background color. We can move the category assignment to a better ___location, or fix the articles in that category, or both. There may be an entirely other explanation; my track record on this page is mixed. – Jonesey95 (talk) 18:26, 1 May 2025 (UTC)<tr><td colspan="2" class="infobox-full-data"><div style="width:100%; text-align:center; line-height:1.5;color: #202122; background: #ffc94b[[Category:Articles using Template:Designation with invalid designation]]">[[New Jersey Register of Historic Places|New Jersey Register of Historic Places]]</div> </td>[[Category:NRHP infobox needing cleanup]]</tr>
- @Jonesey95: I've never seen the invalid designation in my edits. Why does this change with namespace? Is this a parser issue? Thanks, Zeete (talk) 18:37, 1 May 2025 (UTC)
- The category being stuck inside the div tag meant that neither the div tag's color nor the category worked properly. I have fixed it. The category is slowly populating with valid entries. The fix is generally to modify {{Designation/text}} and {{Designation/color}}, or to fix the designation to match a supported value. – Jonesey95 (talk) 18:52, 1 May 2025 (UTC)
- @Jonesey95: Orange is back! Thanks, Zeete (talk) 19:22, 1 May 2025 (UTC)
- The category being stuck inside the div tag meant that neither the div tag's color nor the category worked properly. I have fixed it. The category is slowly populating with valid entries. The fix is generally to modify {{Designation/text}} and {{Designation/color}}, or to fix the designation to match a supported value. – Jonesey95 (talk) 18:52, 1 May 2025 (UTC)
- @Jonesey95: I've never seen the invalid designation in my edits. Why does this change with namespace? Is this a parser issue? Thanks, Zeete (talk) 18:37, 1 May 2025 (UTC)
- OK, when I use ExpandTemplates and set the context to User:Foo (user namespace), the background color works and this is the resulting line:
Upon further checking, I am still putting this category in the wrong place. It needs to appear only if the phrase "Invalid designation" is shown in the infobox. I haven't tracked down the exact spot in the braces to put the category, so I have reverted to the version prior to all of my changes. – Jonesey95 (talk) 19:39, 1 May 2025 (UTC)
- I have located one source of "Invalid designation" output produced by this template. It is in {{Infobox NRHP/conv}}. I have added tracking to that template. It checks for valid input to
|nrhp_type=. – Jonesey95 (talk) 22:48, 1 May 2025 (UTC)
Automatic mapframe switcher
editI am having an issue with Thurston County Courthouse (Washington) after updating the infobox to use an interactive map: the zoom levels and feature outlines look correct when previewing edits, but the final saved article shows an infobox map that is fully zoomed out. I would appreciate guidance for using the switcher correctly. Thank you! OceanLoop (talk) 07:05, 14 July 2025 (UTC)
Lua coordinate error
editI am trying to implement an interactive, switched map which appeared to work well for Washington State Capitol. When I try the same with Olympia National Bank, I get the error: Lua error: Coordinates must be specified on Wikidata or in |coord=. - I do not understand what it means, nor what to do to resolve it; the "coordinates" are specified, both on Wikidata and the infobox coordinates field. Can anyone point out what is missing? User:OceanLoop/sandbox/nrhp also demonstrates the issue. OceanLoop (talk) 04:26, 24 July 2025 (UTC)
- It works for me if I remove the reference from the
|coordinates=parameter value. The reference may need to be in its own parameter, as shown in {{Infobox historic site}}. – Jonesey95 (talk) 13:43, 24 July 2025 (UTC)
Changing boundary increase/decrease parameters
editThe current set of parameters for managing historic district boundary changes are inadequate, and have been for some time. They only allow for distinct boundary increases or decreases, when in recent years the NPS has approved boundary revisions that are in fact both an increase and a decrease; see e.g. "Thomson Commercial Historic District (Boundary Increase and Decrease)" in this recent list of upudates.
I can think of a few ways to address this. One is to describe each change as a revision or boundary change (using "revision[n]", "revision[n]_date", etc, or "boundary_change[n]") instead of "increase[n]" and "decrease[n]", and adding a "revision[n]_type" or "boundary_change[n]_type" parameter which describes what kind of revision it is (which text would follow the refnum in the rendered infobox).
I am not a template editor, so I have no idea how difficult this is to do. It would also require some backfill, eventually editing occurrences of the then-deprecated "increase[n]" and "decrease[n]" parameters, presumably a (semi-)automatable task. Magic♪piano 13:56, 29 July 2025 (UTC)
Template-protected edit request on 13 August 2025
edit | This edit request to Template:Infobox NRHP/conv has been answered. Set the |answered= parameter to no to reactivate your request. |
I cannot figure out how this CHANGE X to Y thing works for this request, so I'll just explain my request:
Reviewing the source code, I see that "formercp" was omitted for some reason. What I would like is for "formercp" to be added to the list of formerXX designations so it can be used for former contributing properties that are no longer contributing. Gb321 (talk) 04:23, 13 August 2025 (UTC)
- Code may also need to be added to Template:Designation/text. Please provide an example of an article where this designation would be useful. – Jonesey95 (talk) 12:54, 13 August 2025 (UTC)
- Karl's Building
- Hotel Lankershim
- Nelson Building
- O. T. Johnson Building
- O. T. Johnson Block Gb321 (talk) 15:41, 13 August 2025 (UTC)
- Thanks. Examples always help. I think that I have made the necessary updates. Does Karl's Building look right to you now? – Jonesey95 (talk) 17:19, 15 August 2025 (UTC)